Distribute vrf aware #3246

pguibert6WIND · 2018-10-25T15:15:14Z

This issue is preparing some work so that distribute list is indexed by vrf_id and by interface name.
A new API will be made available to daemons, so that daemons can give the vrf_id used.

this is the method proposed to make distribute list compliant with multiple vrf instances of daemons.

LabN-CI · 2018-10-25T15:43:38Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `08fcc80`
Date	10/25/2018
Start	11:20:28
Finish	11:43:32
Run-Time	23:04
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-10-25-11:20:28.txt
Log	autoscript-2018-10-25-11:21:06.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-10-25T16:17:27Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5763/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for distribute.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #99: FILE: /tmp/f1-28291/distribute.c:99:
Report for distribute.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #57: FILE: /tmp/f1-28291/distribute.h:57:
Report for eigrp_filter.h | 6 issues
===============================================
< ERROR: space prohibited before that close parenthesis ')'
< #37: FILE: /tmp/f1-28291/eigrp_filter.h:37:
< WARNING: function definition argument 'struct distribute *' should also have an identifier name
< #37: FILE: /tmp/f1-28291/eigrp_filter.h:37:
< WARNING: function definition argument 'vrf_id_t' should also have an identifier name
< #37: FILE: /tmp/f1-28291/eigrp_filter.h:37:
Report for ripngd.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #1582: FILE: /tmp/f1-28291/ripngd.c:1582:
< WARNING: line over 80 characters
< #1714: FILE: /tmp/f1-28291/ripngd.c:1714:

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA 6cd8547

No Changes in Static Analysis warnings compared to base

donaldsharp · 2018-10-28T20:02:36Z

I think this is the wrong approach to the problem. We need a disthash per vrf instead of a global dist hash. additionally we should take the approach of the distribute-list being moved under the vrf so the creation functions of the distribute lists just know their appropriate distribute hash to use.

donaldsharp

distribute-list creation should be moved under the vrf subsection in the cli and lib/distribute.c should pick up the vrf from the defun's and passed around that way.

pguibert6WIND · 2018-10-29T15:34:41Z

| distribute-list creation should be moved under the vrf subsection
With that approach, I see some problems:

how to handle current vty on routing daemon ( has it to be deprecated/removed immediately ?)
plus the below problems identified

before

router rip vrf r1-cust1
distribute-list acl1 in eth0
exit
router ripng vrf r1-cust1
distribute-list acl2 in eth0
exit

after

vrf r1-cust1
distribute-list acl3 in eth0
distribute-list acl4 in eth0    <--- PROBLEM 2 : the last one will be kept
router rip vrf r1-cust1
exit
router ripng vrf r1-cust1
exit

PROBLEM 3: which distribute -list should be associated to which daemon ?
Should we add a command under each daemon to reference the distribute-list to use ?

pguibert6WIND · 2018-10-30T07:20:46Z

| need a disthash per vrf instead of a global dist hash

This need does not solve the above problems.
please lets specify something.

pguibert6WIND · 2018-10-30T14:18:18Z

discussion with Donald. two points discussed:

do not use VRF_DEFAULT. that define should be avoided. for that instead of using that define in the impacted daemons, the vrf_id field will be used in each daemon that needs it.
about the configuration breakage, Donald proposed to split the router configuration in two. distribute-list per vrf per daemon should be made visible.

vrf default
 rip distribute-list ACL2 interface eth2
exit-vrf
vrf vrf1
 rip distribute-list ACL1 interface eth1
exit-vrf
router rip vrf vrf1
 network 1.2.3.0/24
exit
router rip
 network 2.2.3.0/24
exit

pguibert6WIND · 2018-11-06T08:42:41Z

set to on hold thepull request.
lets discuss with David so that a specification is put in place before going ahead with all that.

LabN-CI · 2018-11-20T10:24:05Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git pull/3246 `0a28a4e` (merge failed)
Date	11/20/2018
Start	05:00:19
Finish	05:23:54
Run-Time	23:35
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-11-20-05:00:19.txt
Log	autoscript-2018-11-20-05:01:02.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-11-20T10:58:30Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5975/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA dc079d4

No Changes in Static Analysis warnings compared to base

NetDEF-CI · 2018-11-22T17:27:24Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5994/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Successful
OmniOS amd64 build: Successful
Debian 9 amd64 build: Successful
NetBSD 7 amd64 build: Successful
Ubuntu 16.04 amd64 build: Successful
CentOS 6 amd64 build: Successful
CentOS 7 amd64 build: Successful
Ubuntu 12.04 amd64 build: Successful
FreeBSD 10 amd64 build: Successful
Ubuntu 14.04 amd64 build: Successful
Debian 8 amd64 build: Successful
OpenBSD 6 amd64 build: Successful
FreeBSD 11 amd64 build: Successful
NetBSD 6 amd64 build: Successful
Ubuntu 18.04 amd64 build: Successful

Fedora 24 amd64 build: Failed

Fedora 24 amd64 build: No useful log found

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Fedora 24 amd64 build: Failed

Fedora 24 amd64 build: No useful log found

Report for distribute.c | 12 issues
===============================================
< WARNING: line over 80 characters
< #134: FILE: /tmp/f1-13585/distribute.c:134:
< ERROR: spaces required around that '+=' (ctx:VxW)
< #167: FILE: /tmp/f1-13585/distribute.c:167:
< WARNING: line over 80 characters
< #293: FILE: /tmp/f1-13585/distribute.c:293:
< WARNING: line over 80 characters
< #327: FILE: /tmp/f1-13585/distribute.c:327:
< WARNING: line over 80 characters
< #362: FILE: /tmp/f1-13585/distribute.c:362:
< WARNING: line over 80 characters
< #403: FILE: /tmp/f1-13585/distribute.c:403:
Report for distribute.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #56: FILE: /tmp/f1-13585/distribute.h:56:
Report for eigrp_filter.h | 6 issues
===============================================
< ERROR: space prohibited before that close parenthesis ')'
< #37: FILE: /tmp/f1-13585/eigrp_filter.h:37:
< WARNING: function definition argument 'struct distribute *' should also have an identifier name
< #37: FILE: /tmp/f1-13585/eigrp_filter.h:37:
< WARNING: function definition argument 'vrf_id_t' should also have an identifier name
< #37: FILE: /tmp/f1-13585/eigrp_filter.h:37:
Report for ripngd.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #1582: FILE: /tmp/f1-13585/ripngd.c:1582:
< WARNING: line over 80 characters
< #1714: FILE: /tmp/f1-13585/ripngd.c:1714:

LabN-CI · 2018-11-22T17:34:10Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `1ff2fae`
Date	11/22/2018
Start	12:10:27
Finish	12:34:03
Run-Time	23:36
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-11-22-12:10:27.txt
Log	autoscript-2018-11-22-12:11:10.log.bz2

For details, please contact louberger

LabN-CI · 2018-11-23T12:54:16Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `74b05d1`
Date	11/23/2018
Start	07:30:29
Finish	07:54:08
Run-Time	23:39
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-11-23-07:30:29.txt
Log	autoscript-2018-11-23-07:31:14.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-11-23T13:27:05Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5995/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA 4b53ce0

No Changes in Static Analysis warnings compared to base

LabN-CI · 2018-11-23T14:34:07Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `6db0809`
Date	11/23/2018
Start	09:10:28
Finish	09:34:00
Run-Time	23:32
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-11-23-09:10:28.txt
Log	autoscript-2018-11-23-09:11:13.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-11-23T15:11:10Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5996/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA 4b53ce0

No Changes in Static Analysis warnings compared to base

pguibert6WIND · 2018-11-28T16:36:20Z

Hi @donaldsharp ,

are you ready for a second review, please?

rwestphal · 2018-12-03T20:16:03Z

I think indexing distribute-lists by both the interface name and VRF name is a valid solution, but not the ideal one IMO. If we add multi-instance support to ripd, ripngd, eigrpd or babeld in the future, we'll need to change the global disthash hash to index distribute-lists by the protocol process-ID or AS in addition to the other fields, and things can start to get messy.

What I would suggest is to encapsulate all the distribute-list global variables (disthash and some hooks) inside of a distribute_ctx container (a C structure), and include this container inside of the relevant routing protocol instances. Then update all distribute-list functions to accept a distribute_ctx container and operate based on this container. I think it's better to arrange our data structures hierarchically since this usually leads to simpler code that is easier to maintain. As an example, if we have a distribute_ctx member in the rip structure, it's much easier to remember that this container needs to be deallocated when deleting the corresponding rip instance. Performing iterations and lookups is easier as well since we don't need to worry about filtering out distribute-lists from other routing instances.

Last but not least, the first commit of this PR introduces a few API changes but the affected daemons are updated on the subsequent commits. This means none of these commits should compile except the last one, which is bad if we think in terms of git-bisect. Splitting PRs into smaller commits is usually good but in cases like this I think all changes must be squashed together.

pguibert6WIND · 2018-12-03T20:27:46Z

Hi Renato,
both remarks are valid, especially since I think that container_ctx will match the NB API.

pguibert6WIND · 2018-12-04T15:00:16Z

Hi Renato, here are the changes:

I just did the distribute_ctx encapsulation. I mean, there is no use case, as far as I know to have several AS-instances in the same vrf. so I did not create linked list for now. All is static.
I gathered previous commits in a single one.

NetDEF-CI · 2018-12-04T16:09:45Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6063/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for distribute.h | 4 issues
===============================================
< WARNING: function definition argument 'struct distribute *' should also have an identifier name
< #57: FILE: /tmp/f1-26116/distribute.h:57:
< WARNING: function definition argument 'struct distribute *' should also have an identifier name
< #58: FILE: /tmp/f1-26116/distribute.h:58:

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA b59d17b
Base image data for Git b59d17b does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6063/artifact/shared/static_analysis/index.html

LabN-CI · 2018-12-04T16:31:36Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `04434bd`
Date	12/04/2018
Start	11:08:01
Finish	11:31:30
Run-Time	23:29
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-12-04-11:08:01.txt
Log	autoscript-2018-12-04-11:08:42.log.bz2

For details, please contact louberger

LabN-CI · 2018-12-10T13:34:03Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `af0de7e`
Date	12/10/2018
Start	08:10:31
Finish	08:33:56
Run-Time	23:25
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-12-10-08:10:31.txt
Log	autoscript-2018-12-10-08:11:13.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-12-10T14:15:27Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6136/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for distribute.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #178: FILE: /tmp/f1-22338/distribute.c:178:

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA ca65419

No Changes in Static Analysis warnings compared to base

NetDEF-CI · 2018-12-10T14:17:23Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6137/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for distribute.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #178: FILE: /tmp/f1-22822/distribute.c:178:

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA ca65419

No Changes in Static Analysis warnings compared to base

pguibert6WIND · 2018-12-10T14:36:29Z

Hi @rwestphal ,
I did what you requested. I hope the result is ok. Two points to mention:

I kept the hook pointers under the structure. distribute_ctx
when the vty handler will be called, from rip or ripng, I am using the first distribute_ctx available. for sure, I need to do the ctx <-> vty relationship, or I should say the ctx <-> nb api relationship (I).

hence the next changes:

I made a proposal for a new yang distribute_ctx model
what is not done is to fill in the stubs of distribute_nb api.

I think it is best that you review the data model, knowing that you may have some remarks; also, I think that I should add to RIP model a keyword like ' container rip-distribute-list { use distribute-list }`. Is not it the answer to the question I was asking before ?

LabN-CI · 2018-12-10T15:37:41Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `9fc1ed6`
Date	12/10/2018
Start	10:14:05
Finish	10:37:34
Run-Time	23:29
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-12-10-10:14:05.txt
Log	autoscript-2018-12-10-10:14:46.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-12-10T15:46:03Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6139/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Ubuntu 12.04 deb pkg check: Successful
Static analyzer (clang): Successful
IPv6 protocols on Ubuntu 14.04: Successful
Ubuntu 16.04 deb pkg check: Successful
Fedora 24 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Topology tests on Ubuntu 16.04 amd64: Successful
Debian 9 deb pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful
Topotest tests on Ubuntu 16.04 i386: Successful

CentOS 6 rpm pkg check: Failed

CentOS 6 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6139/artifact/CENTOS6PKG/ErrorLog/log_package_start.txt
CentOS 6 rpm pkg check: No useful log found

Warnings Generated during build:

Checkout code: Successful with additional warnings:

CentOS 6 rpm pkg check: Failed

CentOS 6 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6139/artifact/CENTOS6PKG/ErrorLog/log_package_start.txt
CentOS 6 rpm pkg check: No useful log found

Report for distribute_northbound.c | 20 issues
===============================================
WARNING: line over 80 characters
#26: FILE: /tmp/f1-1862/distribute_northbound.c:26:
+static int lib_distribute_list_create(enum nb_event event, const struct lyd_node *dnode, union nb_resource *resource)

WARNING: line over 80 characters
#32: FILE: /tmp/f1-1862/distribute_northbound.c:32:
+static int lib_distribute_list_delete(enum nb_event event, const struct lyd_node *dnode)

WARNING: line over 80 characters
#41: FILE: /tmp/f1-1862/distribute_northbound.c:41:
+static int lib_distribute_list_interface_name_modify(enum nb_event event, const struct lyd_node *dnode, union nb_resource *resource)

WARNING: line over 80 characters
#47: FILE: /tmp/f1-1862/distribute_northbound.c:47:
+static int lib_distribute_list_interface_name_delete(enum nb_event event, const struct lyd_node *dnode)

WARNING: line over 80 characters
#63: FILE: /tmp/f1-1862/distribute_northbound.c:63:
+			.xpath = "/frr-distribute-list:lib/distribute-list/interface-name",

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA 27dcf6d
Base image data for Git 27dcf6d does not exist - compare skipped

LabN-CI · 2018-12-17T13:34:08Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `c492d6b`
Date	12/17/2018
Start	08:10:33
Finish	08:34:01
Run-Time	23:28
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-12-17-08:10:33.txt
Log	autoscript-2018-12-17-08:11:15.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-12-17T13:52:15Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6204/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Ubuntu 12.04 deb pkg check: Successful
Static analyzer (clang): Successful
Ubuntu 16.04 deb pkg check: Successful
Topology tests on Ubuntu 18.04 amd64: Successful
IPv6 protocols on Ubuntu 14.04: Successful
Fedora 24 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
CentOS 7 rpm pkg check: Successful
Topology tests on Ubuntu 16.04 amd64: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Debian 9 deb pkg check: Successful
Topotest tests on Ubuntu 16.04 i386: Successful

CentOS 6 rpm pkg check: Failed

CentOS 6 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6204/artifact/CENTOS6PKG/ErrorLog/log_package_start.txt
CentOS 6 rpm pkg check: No useful log found

Warnings Generated during build:

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6204/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6204/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6204/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6204/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6204/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6204/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA b31c2a2
Base image data for Git b31c2a2 does not exist - compare skipped

LabN-CI · 2018-12-17T14:04:07Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `42d2c8a`
Date	12/17/2018
Start	08:40:30
Finish	09:04:00
Run-Time	23:30
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-12-17-08:40:30.txt
Log	autoscript-2018-12-17-08:41:13.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-12-17T14:37:18Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6205/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6205/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6205/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6205/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6205/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6205/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6205/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA b31c2a2

No Changes in Static Analysis warnings compared to base

rwestphal

Thanks for the updates Phillippe, I'm very happy with the latest changes. Please address a few additional review comments and I should approve this. As we discussed previously, please try to squash the three latest commits into a single one as the changes are easier to review when they are all together.

babeld/babeld.h

babeld/babel_filter.c

babeld/babeld.c

lib/distribute.c

ripd/ripd.h

ripngd/ripngd.h

babeld/babeld.c

babeld/babel_filter.c

lib/distribute.c

NetDEF-CI · 2018-12-18T18:21:29Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Successful
FreeBSD 11 amd64 build: Successful
Fedora 24 amd64 build: Successful
NetBSD 6 amd64 build: Successful
Ubuntu 18.04 amd64 build: Successful
Ubuntu 16.04 i386 build: Successful
OmniOS amd64 build: Successful
Debian 9 amd64 build: Successful
NetBSD 7 amd64 build: Successful
Ubuntu 16.04 amd64 build: Successful
CentOS 6 amd64 build: Successful
CentOS 7 amd64 build: Successful
Ubuntu 12.04 amd64 build: Successful
FreeBSD 10 amd64 build: Successful
Debian 8 amd64 build: Successful

Ubuntu 14.04 amd64 build: Failed

DejaGNU Unittests (make check) failed for Ubuntu 14.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI001BUILD/ErrorLog/log_pytests.txt
Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI001BUILD/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Ubuntu 14.04 amd64 build: Failed

DejaGNU Unittests (make check) failed for Ubuntu 14.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI001BUILD/ErrorLog/log_pytests.txt
Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI001BUILD/config.status/config.status

Report for distribute.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #561: FILE: /tmp/f1-11090/distribute.c:561:

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

NetDEF-CI · 2018-12-18T23:37:40Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for distribute.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #561: FILE: /tmp/f1-11090/distribute.c:561:

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6234/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA 5704786

No Changes in Static Analysis warnings compared to base

pguibert6WIND · 2018-12-19T15:40:48Z

ci:rerun

LabN-CI · 2018-12-20T07:11:46Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `a6edabc`
Date	12/20/2018
Start	01:47:10
Finish	02:11:38
Run-Time	24:28
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-12-20-01:47:10.txt
Log	autoscript-2018-12-20-01:48:53.log.bz2

For details, please contact louberger

in order to enforce the vrf_id to return, from a vrf name, a check is done on the vrf_name_to_id callback. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

a distribute_ctx context pointer is returned after initialisation to the calling daemon. this context pointer will be further used to do discussion with distribute service. Today, there is no specific problem with old api, since the pointer is the same in all the memory process. but the pointer will be different if we have multiple instances. Right now, this is not the case, but if that happens, that work will be used for that. distribute-list initialisation is split in two. the vty initialisation is done at global level, while the context initialisation is done for each routing daemon instance. babel daemon is being equipped with a routing returning the main babel instance. also, a delete routine is available when the daemon routing instance is suppressed. a list of contexts is used inside distribute_list. This will permit distribute_list utility to handle in the same daemon to handle more than one context. This will be very useful in the vrf context. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

LabN-CI · 2018-12-28T18:17:16Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3246 `03a3849`
Date	12/28/2018
Start	12:52:37
Finish	13:17:07
Run-Time	24:30
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-12-28-12:52:37.txt
Log	autoscript-2018-12-28-12:54:21.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-12-28T18:25:02Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6285/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for distribute.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #561: FILE: /tmp/f1-31064/distribute.c:561:

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6285/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6285/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6285/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6285/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6285/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6285/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

CLANG Static Analyzer Summary

Github Pull Request 3246, comparing to Git base SHA 71c4e0c

No Changes in Static Analysis warnings compared to base

pguibert6WIND mentioned this pull request Oct 25, 2018

distribute-list is indexed by ifname only - need to extend to (ifname,vrf) #3243

Closed

donaldsharp self-requested a review October 28, 2018 20:02

donaldsharp requested changes Oct 28, 2018

View reviewed changes

pguibert6WIND force-pushed the distribute_vrf_aware branch from 08fcc80 to 0a28a4e Compare November 20, 2018 09:58

pguibert6WIND force-pushed the distribute_vrf_aware branch from 0a28a4e to 1ff2fae Compare November 22, 2018 17:06

pguibert6WIND force-pushed the distribute_vrf_aware branch from 1ff2fae to 74b05d1 Compare November 23, 2018 12:26

pguibert6WIND force-pushed the distribute_vrf_aware branch from 74b05d1 to 6db0809 Compare November 23, 2018 14:10

pguibert6WIND mentioned this pull request Nov 28, 2018

*: remove the configuration lock from all daemons #3378

Merged

pguibert6WIND force-pushed the distribute_vrf_aware branch from 6db0809 to 04434bd Compare December 4, 2018 14:59

pguibert6WIND force-pushed the distribute_vrf_aware branch 2 times, most recently from 38d1202 to af0de7e Compare December 10, 2018 13:08

FRRouting deleted a comment from NetDEF-CI Dec 10, 2018

pguibert6WIND force-pushed the distribute_vrf_aware branch from af0de7e to 9fc1ed6 Compare December 10, 2018 14:31

pguibert6WIND added the review & merge me look at me! label Dec 10, 2018

pguibert6WIND force-pushed the distribute_vrf_aware branch 2 times, most recently from c492d6b to 42d2c8a Compare December 17, 2018 13:29

rwestphal reviewed Dec 17, 2018

View reviewed changes

pguibert6WIND force-pushed the distribute_vrf_aware branch from 42d2c8a to a6edabc Compare December 18, 2018 17:53

pguibert6WIND added 2 commits December 28, 2018 18:18

lib: enforce vrf_name_to_id by returning default_vrf when name is null

2569910

in order to enforce the vrf_id to return, from a vrf name, a check is done on the vrf_name_to_id callback. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

pguibert6WIND force-pushed the distribute_vrf_aware branch from a6edabc to 03a3849 Compare December 28, 2018 17:19

rwestphal mentioned this pull request Dec 31, 2018

rip(ng)d: add VRF support #3548

Merged

rwestphal merged commit dd6f112 into FRRouting:master Jan 2, 2019

Distribute vrf aware #3246

Distribute vrf aware #3246

Conversation

pguibert6WIND commented Oct 25, 2018

LabN-CI commented Oct 25, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Oct 25, 2018

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Checkout code: Successful with additional warnings:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

donaldsharp commented Oct 28, 2018

donaldsharp left a comment

Choose a reason for hiding this comment

pguibert6WIND commented Oct 29, 2018

pguibert6WIND commented Oct 30, 2018

pguibert6WIND commented Oct 30, 2018 • edited Loading

pguibert6WIND commented Nov 6, 2018

LabN-CI commented Nov 20, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 20, 2018

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

NetDEF-CI commented Nov 22, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Fedora 24 amd64 build: Failed

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Fedora 24 amd64 build: Failed

LabN-CI commented Nov 22, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Nov 23, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 23, 2018

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

LabN-CI commented Nov 23, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 23, 2018

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

pguibert6WIND commented Nov 28, 2018

rwestphal commented Dec 3, 2018

pguibert6WIND commented Dec 3, 2018

pguibert6WIND commented Dec 4, 2018

NetDEF-CI commented Dec 4, 2018

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Checkout code: Successful with additional warnings:

CLANG Static Analyzer Summary

4 Static Analyzer issues remaining.

LabN-CI commented Dec 4, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Dec 10, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Dec 10, 2018

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Checkout code: Successful with additional warnings:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

NetDEF-CI commented Dec 10, 2018

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Checkout code: Successful with additional warnings:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

pguibert6WIND commented Dec 10, 2018

LabN-CI commented Dec 10, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Dec 10, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Successful

pguibert6WIND commented Oct 30, 2018 •

edited

Loading