Fix mgmtd abort (core) during exit with in-progress config change #20356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjardin
approved these changes
Jan 2, 2026
Contributor
vjardin
left a comment
vjardin
left a comment
There was a problem hiding this comment.
LGTM, the core detection fix (**/*.dmp with recursive=True) is a helpful bonus.
Signed-off-by: Christian Hopps <chopps@labn.net>
- Need to vty_terminate() (i.e., vty_close our vtys) before we cleanup the mgmt client sessions associated with those vtys. vty_terminate() is normally done in frr_fini(), but we also need to do our client cleanup before calling frr_fini() as we need the event system still initialized and frr_fini() cleans it up. Signed-off-by: Christian Hopps <chopps@labn.net>
choppsv1
force-pushed
the
chopps/fix-clenaup-abort
branch
from
dff0465 to
3d4aa96
Compare
Jafaral
approved these changes
Jan 3, 2026
Member
|
@Mergifyio backport stable/10.5 |
✅ Backports have been createdDetails
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to close mgmtd vtys before we closed our loopback mgmtd client connection which is used by those vtys.
Add a regression test which reproduces the issue before the fix has been applied.
Also fix core detection for topotests
fixes #20305