frr-reload: fix deleting active interface #20335
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make frr-reload use 'no interface' only for deleted interfaces, for active interfaces don't run 'no interface', run 'no' for all commands in interface section.
This was the behavior before #16723, which was a fix for case when interface was deleted from system: in this case inner commands with 'no' failed, and 'no interface' works.
But if interface is still active and whole configuration for the interface is deleted FRR issues error 'Failed to create cfgdata: only inactive interfaces can be deleted', so in this case it is proper to run 'no' version of all commands in section, but not 'no interface'.
How to test: