Skip to content

bgpd: update source address for bgp neighbor #20330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riw777 merged 1 commit into from
Jan 6, 2026
+6 −0
Merged

bgpd: update source address for bgp neighbor #20330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bgpd/bgp_fsm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,6 +1995,9 @@ bgp_connect_success(struct peer_connection *connection)
/* Send an open message */
bgp_open_send(connection);

if (peer->bfd_config)
Copy link
Member

@donaldsharp donaldsharp Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the call to bgp_peer_bfd_update_source in bgp_establish() if this is done here? In other words why is it needed here -vs- there.

Copy link
Member

@donaldsharp donaldsharp Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the case of bgp_connect_success_w_delayopen? Won't that not work?

Copy link
Contributor Author

@anlancs anlancs Dec 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repush it for bgp_connect_success_w_delayopen, which is also with this problem.

Copy link
Contributor Author

@anlancs anlancs Dec 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the commit log: the bgp_establish can’t be reached for bfd strict mode without this commit in this case.

bgp_peer_bfd_update_source(peer);

return BGP_FSM_SUCCESS;
}

Expand Down Expand Up @@ -2054,6 +2057,9 @@ bgp_connect_success_w_delayopen(struct peer_connection *connection)
peer->host, peer->delayopen,
bgp_peer_get_connection_direction(connection));

if (peer->bfd_config)
bgp_peer_bfd_update_source(peer);

return BGP_FSM_SUCCESS;
}

Expand Down
Loading