Handle RESTCONF RPC/Action input format #20208
Merged
+204
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
For RPCs, RESTCONF uses a different input/output data format. This needs to be flagged when calling libyang functions etc, so pass a restconf bool around to identify when this is the case. Signed-off-by: Christian Hopps <chopps@labn.net>
frrbot
bot
added
libfrr
mgmt
donaldsharp
reviewed
Dec 6, 2025
| return ret; | ||
| } | ||
| assert(output->child == NULL); | ||
| /* yang_dnode_free(output); */ |
Member
There was a problem hiding this comment.
do we care about this memory leak?
Contributor
Author
There was a problem hiding this comment.
yeah, left over from some testing.. fixed.
Member
|
all in all fix up the verify source problems and let ci rerun and I'll get this in. |
choppsv1
force-pushed
the
chopps/rpc-restconf-format
branch
from
99b3efc to
3bdd895
Compare
Previously was only testing an action. Add RPC w/o args and w/ args to unit tests. Signed-off-by: Christian Hopps <chopps@labn.net>
choppsv1
force-pushed
the
chopps/rpc-restconf-format
branch
from
3bdd895 to
50a4e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RPCs, RESTCONF uses a different input/output data format. This needs to be
flagged when calling libyang functions etc, so pass a restconf bool around to
identify when this is the case.
Also testing: Previously was only testing a YANG Action. Add RPC w and w/ args to unit
tests.