zebra: reset rtadv info on interface deletion #18220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguibert6WIND
force-pushed
the
zebra_rtadv_reset
branch
from
8fae1b0 to
dd7c53e
Compare
When BGP is requested to leave (systemctl stop bgpd), BGP may not have the time to flush all its contexts, including the rtadv information. > Feb 21 14:32:23 dut-vm zebra[998]: [N5M5Y-J5BPG][EC 4043309121] Client 'bgp' (session id 1) encountered an error and is shutting down. > Feb 21 14:32:23 dut-vm zebra[998]: [YDZ55-W3VM6] release_daemon_table_chunks: Released 0 table chunks > Feb 21 14:32:23 dut-vm zebra[998]: [ZJPTG-6AP36] release_daemon_label_chunks: Releasing chunks for client proto bgp, instance 0, session 0 > Feb 21 14:32:23 dut-vm zebra[998]: [MP8WF-MBM3F] release_daemon_label_chunks: Released 0 label chunks > Feb 21 14:32:23 dut-vm zebra[998]: [JPSA8-5KYEA] client 37 disconnected 0 bgp routes removed from the rib > Feb 21 14:32:23 dut-vm zebra[998]: [S929C-NZR3N] client 37 disconnected 0 bgp nhgs removed from the rib > Feb 21 14:32:23 dut-vm zebra[998]: [YDZ55-W3VM6] release_daemon_table_chunks: Released 0 table chunks > Feb 21 14:32:23 dut-vm zebra[998]: [KQB7H-NPVW9] /build/make-pkg/output/_packages/cp-routing/src/zebra/zebra_ptm.c:1343 fai > led to find process pid registration > Feb 21 14:32:23 dut-vm zebra[998]: [ZJPTG-6AP36] release_daemon_label_chunks: Releasing chunks for client proto bgp, instan > ce 0, session 1 > Feb 21 14:32:23 dut-vm zebra[998]: [WAX6A-X2VK5] Releasing label chunk: 103 - 103 > Feb 21 14:32:23 dut-vm zebra[998]: [MP8WF-MBM3F] release_daemon_label_chunks: Released 1 label chunks > Feb 21 14:32:23 dut-vm zebra[998]: [JPSA8-5KYEA] client 42 disconnected 0 bgp routes removed from the rib > Feb 21 14:32:23 dut-vm zebra[998]: [S929C-NZR3N] client 42 disconnected 0 bgp nhgs removed from the rib > Feb 21 14:32:31 dut-vm zebra[998]: [JY2SR-KEYTH] ntfp2(default:4): Tx RA, socket 9 When the BGP leave is detected by ZEBRA, one should ensure that no interfaces have rtadvd enabled by BGP. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
force-pushed
the
zebra_rtadv_reset
branch
from
dd7c53e to
001f54e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a BGP ipv6 with extended nexthop encoding, the deletion of an interface does not reset the rtadv per interface information.
Actually, if the same interface is readded, the rtadv information is still persistent:
Actually, when deleting an interface, the interface is kept on default vrf with the original ifname but an ifindex set to 0. If BGP did not have time to undo the rtadv, then the rtadv configured is kept and is turned on, the next time the interface is used. Fix this by resetting the rtadv configuration at interface deletion.