-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isisd: Request SRv6 locator after zebra connection #18178
Merged
donaldsharp
merged 2 commits into
FRRouting:master
from
cscarpitta:fix/isis_request_srv6_locator
Feb 15, 2025
Merged
isisd: Request SRv6 locator after zebra connection #18178
donaldsharp
merged 2 commits into
FRRouting:master
from
cscarpitta:fix/isis_request_srv6_locator
Feb 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a function that iterates over all IS-IS areas and asks the SRv6 Manager for information about the configured locators. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
When SRv6 is enabled and an SRv6 locator is specified in the IS-IS configuration, IS-IS may attempt to request SRv6 locator information from zebra before the connection is fully established. If this occurs, the request fails with the following error: ``` 2025/02/14 21:41:20 ISIS: [HR66R-TWQYD][EC 100663302] srv6_manager_get_locator: invalid zclient socket ```` As a result, IS-IS is unable to obtain the locator information, preventing SRv6 from working. This commit fixes the issue by ensuring IS-IS requests SRv6 locator information once the connection with zebra is successfully established. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
This also fixes intermittent failures of |
@Mergifyio backport dev/10.3 |
✅ Backports have been created
|
@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
ton31337
added a commit
that referenced
this pull request
Feb 16, 2025
isisd: Request SRv6 locator after zebra connection (backport #18178)
donaldsharp
added a commit
that referenced
this pull request
Feb 16, 2025
isisd: Request SRv6 locator after zebra connection (backport #18178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SRv6 is enabled and an SRv6 locator is specified in the IS-IS configuration, IS-IS may attempt to request SRv6 locator information from zebra before the connection is fully established. If this occurs, the request fails with the following error:
As a result, IS-IS is unable to obtain the locator information, preventing SRv6 from working.
This PR fixes the issue by ensuring IS-IS requests SRv6 locator information once the connection with zebra is successfully established.