Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isisd: Request SRv6 locator after zebra connection #18178

Merged

Conversation

cscarpitta
Copy link
Contributor

When SRv6 is enabled and an SRv6 locator is specified in the IS-IS configuration, IS-IS may attempt to request SRv6 locator information from zebra before the connection is fully established. If this occurs, the request fails with the following error:

2025/02/14 21:41:20 ISIS: [HR66R-TWQYD][EC 100663302] srv6_manager_get_locator: invalid zclient socket

As a result, IS-IS is unable to obtain the locator information, preventing SRv6 from working.

This PR fixes the issue by ensuring IS-IS requests SRv6 locator information once the connection with zebra is successfully established.

This commit adds a function that iterates over all IS-IS areas and asks
the SRv6 Manager for information about the configured locators.

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
When SRv6 is enabled and an SRv6 locator is specified in the IS-IS
configuration, IS-IS may attempt to request SRv6 locator information from
zebra before the connection is fully established. If this occurs, the
request fails with the following error:

```
2025/02/14 21:41:20 ISIS: [HR66R-TWQYD][EC 100663302] srv6_manager_get_locator: invalid zclient socket
````

As a result, IS-IS is unable to obtain the locator information,
preventing SRv6 from working.

This commit fixes the issue by ensuring IS-IS requests SRv6 locator
information once the connection with zebra is successfully established.

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
@cscarpitta
Copy link
Contributor Author

cscarpitta commented Feb 15, 2025

This also fixes intermittent failures of isis_srv6_topo1 and srv6_sid_manager topotests that occur when the topotests are run on a heavily loaded system.

@donaldsharp donaldsharp merged commit b2c960a into FRRouting:master Feb 15, 2025
16 checks passed
@donaldsharp
Copy link
Member

@Mergifyio backport dev/10.3

Copy link

mergify bot commented Feb 15, 2025

backport dev/10.3

✅ Backports have been created

@cscarpitta
Copy link
Contributor Author

@Mergifyio backport stable/10.2 stable/10.1 stable/10.0

Copy link

mergify bot commented Feb 15, 2025

backport stable/10.2 stable/10.1 stable/10.0

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants