WIP: ospfd: Unicast direct acknowledgements on P2MP interfaces - Do Not Merge Yet #17866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:rerun |
The commit c706f0e changed OSPF to send all OSPF Ack packets as multicast on point-to-multipoint (P2MP) interfaces. Experience has proved that sending direct Acks as multicast doesn't offer any convergence benefits and will be more inefficient in situations where the underlying network topology relies on replication for multicast. Additionally, sending all these acknowledgements as multicast complicates the debugging of packet captures. Sending these direct acks as unicast also elmiinated the case where the same LSA could be sent in a single packet. Signed-off-by: Acee Lindem <acee@lindem.com>
aceelindem
force-pushed
the
aceelindem/ospf-p2mp-unicast-direct-ack
branch
from
31ff0d9 to
e0b6eb9
Compare
|
CI:rerun |
aceelindem
changed the title
|
let me know when you're ready for review on this ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit c706f0e changed OSPF to send all OSPF Ack packets as multicast on point-to-multipoint (P2MP) interfaces. Experience has proved that sending direct Acks as multicast doesn't offer any convergence benefits and will be more inefficient in situations where the underlying network topology relies on replication for multicast. Additionally, sending all these acknowledgements as multicast complicates the debugging of packet captures.
Sending these direct acks as unicast also elmiinated the case where the same LSA could be sent in a single packet.