Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: add rpki current state #17728

Merged
merged 2 commits into from
Jan 1, 2025
Merged

bgpd: add rpki current state #17728

merged 2 commits into from
Jan 1, 2025

Conversation

dmytroshytyi-6WIND
Copy link
Contributor

Display rpki_curr_state in the output and provide a topotest to theck the json field:

                "version": 2,
                "rpkiValidationState": "valid",
                "bestpath": {
                    "overall": true,
                    "selectionReason": "First path received"
                },

@pguibert6WIND @dmytroshytyi-6WIND
bgpd: display rpki state in 'show bgp ipvX detail'
24302c2 
The rpki current state was ignored when calling for the 'show bgp ipvX
detail' command. Handle the support for this, with json support too.

> "rpkiValidationState" : "valid",
> "rpkiValidationState" : "invalid",
> "rpkiValidationState" : "not used",
> "rpkiValidationState" : "not found",

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
@frrbot frrbot bot added bgp tests Topotests, make check, etc labels Dec 27, 2024
@ton31337
Copy link
Member

Please fix frrbot before merging.

@ton31337 ton31337 mentioned this pull request Dec 27, 2024
Closed
@dmytroshytyi-6WIND
tests: add bgp rpki topo1 rpkiValidationState
5f50b98 
Topotest to verify the next key-value "rpkiValidationState": "valid"

Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
@dmytroshytyi-6WIND
Copy link
Contributor Author

Hi @ton31337,

Thank you for review.
frrbot looks ok after format update of topotest.

Thanks,
Dmytro.

pguibert6WIND
pguibert6WIND approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@pguibert6WIND pguibert6WIND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ton31337 ton31337 merged commit 3acfcef into FRRouting:master Jan 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 approved these changes

@pguibert6WIND pguibert6WIND pguibert6WIND approved these changes

Assignees
No one assigned
Labels
bgp master size/L tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmytroshytyi-6WIND @ton31337 @pguibert6WIND