Skip to content

isisd: route leak at different levels #16604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

isisd: route leak at different levels #16604

wants to merge 1 commit into from
+100 −5

Conversation

JosiahMg
Copy link
Contributor

isis: Route leak between different levels of ISIS

in level-1-2 router device

level-2 leak to level-1:

 redistribute ipv4 isis level-1 [metric] [route-map]

level-1 leak to level-2:

 redistribute ipv4 isis level-2

@frrbot frrbot bot added the isis label Aug 18, 2024
@JosiahMg
Copy link
Contributor Author

for ipv6:

redistribute ipv6 isis level-1 [metric] [route-map]
redistribute ipv6 isis level-2 [metric] [route-map]

@JosiahMg JosiahMg force-pushed the isis-route-leak branch 2 times, most recently from b771c36 to 79b3ca6 Compare August 18, 2024 13:37
@github-actions github-actions bot added size/L and removed size/M labels Aug 18, 2024
@JosiahMg JosiahMg force-pushed the isis-route-leak branch 2 times, most recently from eadb7b5 to 415fe05 Compare August 18, 2024 13:52
@JosiahMg
isisd: route leak at different levels
af37348 
Signed-off-by: JosiahMg <JosiahMg@163.com>
ton31337
ton31337 requested changes Aug 24, 2024
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without documentation and topotest this can't be accepted unfortunately anyway.

riw777
riw777 reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs topo test and documentation ...

@JosiahMg
Copy link
Contributor Author

needs topo test and documentation ...

copy that

@odd22
Copy link
Member

odd22 commented Sep 10, 2024

Redistribute route means that the router should send them to its neighbors (LSPs in case of IS-IS). But, I don't saw in your patch how this happen.

In addition, does your PR not overlap with #15863?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 left review comments

@ton31337 ton31337 ton31337 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
autoclose isis master size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JosiahMg @odd22 @riw777 @ton31337