Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmtd: add empty notif xpath map for completeness #16183

Merged
merged 2 commits into from
Jun 10, 2024
Merged

mgmtd: add empty notif xpath map for completeness #16183

merged 2 commits into from
Jun 10, 2024

Conversation

choppsv1
Copy link
Contributor

@choppsv1 choppsv1 commented Jun 6, 2024

doc: add some text on native message API and notif xpath array

ton31337
ton31337 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but to be consistent, I think you missed adding this debug message:

__dbg("Total Notif XPath Maps: %u", darr_len(be_notif_xpath_map));

choppsv1 added 2 commits June 7, 2024 05:50
@choppsv1
mgmtd: add empty notif xpath map for completeness
a1dd57b 
New back-end clients may need to add notification static allocations so
we should have it available for those users, rather than requiring the
new user delve into the mgmtd infra and modify it themselves.

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
doc: add some text on native message API and notif xpath array
491e608 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1 choppsv1 force-pushed the chopps/notif-doc-update branch from f3c355a to 491e608 Compare June 7, 2024 09:51
@github-actions github-actions bot added the rebase PR needs rebase label Jun 7, 2024
@choppsv1
Copy link
Contributor Author

choppsv1 commented Jun 7, 2024

LGTM, but to be consistent, I think you missed adding this debug message:

__dbg("Total Notif XPath Maps: %u", darr_len(be_notif_xpath_map));

Thanks, fixed.

@ton31337 ton31337 merged commit d5b0c76 into FRRouting:master Jun 10, 2024
10 checks passed
@choppsv1 choppsv1 deleted the chopps/notif-doc-update branch January 18, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
master rebase PR needs rebase size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@choppsv1 @ton31337