Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Ignore validating the attribute flags if path-attribute is configured #15895

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented May 1, 2024

Closes #15884

…igured

E.g. Cisco sends AIGP attribute as transitive, but it's wrong. Hence, the session
is teared down, because of this bgp_attr_flag_invalid() test.

Relax this check if we have `neighbor X path-attribute <discard|treat-as-withdraw>`
configured.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@frrbot frrbot bot added bgp tests Topotests, make check, etc labels May 1, 2024
@ton31337
Copy link
Member Author

ton31337 commented May 1, 2024

@Mergifyio backport stable/10.0 stable/9.1

Copy link

mergify bot commented May 1, 2024

backport stable/10.0 stable/9.1

✅ Backports have been created

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit ee85385 into FRRouting:master May 7, 2024
13 checks passed
donaldsharp added a commit that referenced this pull request May 8, 2024
bgpd: Ignore validating the attribute flags if path-attribute is configured (backport #15895)
donaldsharp added a commit that referenced this pull request May 8, 2024
bgpd: Ignore validating the attribute flags if path-attribute is configured (backport #15895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants