-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babeld: Add interval and router-id field checking #15698
Open
zmw12306
wants to merge
2
commits into
FRRouting:master
Choose a base branch
from
zmw12306:babel_nonzero_interval
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The router-id check should also be done in Seqno Request |
riw777
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This needs to be rebased and the build failure fixed ... |
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
|
zmw12306
force-pushed
the
babel_nonzero_interval
branch
from
September 3, 2024 18:44
a4ed94c
to
18559e2
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
zmw12306
force-pushed
the
babel_nonzero_interval
branch
from
September 3, 2024 18:48
18559e2
to
077c9ad
Compare
Signed-off-by: zmw12306 <zmw12306@gmail.com>
zmw12306
force-pushed
the
babel_nonzero_interval
branch
from
September 3, 2024 19:50
077c9ad
to
6797ec0
Compare
Signed-off-by: Mingwei Zheng <zmw12306@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 8966: https://www.rfc-editor.org/rfc/rfc8966.html#name-details-of-specific-tlvs
Add checking for interval and router-id:
The interval MUST NOT be 0 in Acknowledgment Request, IHU, Update
The Router-Id MUST NOT consist of all zeroes or all ones.