bgpd: add resolved_prefix visibility on nht #15636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguibert6WIND
force-pushed
the
resolved_prefix_bgp
branch
from
48def30 to
e152654
Compare
ton31337
requested changes
Mar 29, 2024
The nexthop tracking never displays the prefix that has been used in ZEBRA to resolve its nexthop. This information will be useful if some decision has to be taken regarding any loops, that is to say if for instance a BGP prefix is resolved over a prefix in ZEBRA that is exactly the same. Store the value in bgp nexthop context, and display it. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
force-pushed
the
resolved_prefix_bgp
branch
2 times, most recently
from
e20faa9 to
98d0339
Compare
pguibert6WIND
force-pushed
the
resolved_prefix_bgp
branch
from
98d0339 to
e20faa9
Compare
ton31337
approved these changes
Mar 30, 2024
| } else { | ||
| vty_out(vty, " %s valid [IGP metric %d], #paths %d", | ||
| buf, bnc->metric, bnc->path_count); | ||
| if (peer) | ||
| vty_out(vty, ", peer %s", peer->host); | ||
| if (bnc->is_evpn_gwip_nexthop) | ||
| vty_out(vty, " EVPN Gateway IP"); | ||
| vty_out(vty, "\n Resolved prefix %pFX", |
There was a problem hiding this comment.
Will this align with the existing CLI output? I see 2 spaces here. Or is this intentional?
There was a problem hiding this comment.
#show bgp nexthop
192.168.3.3 valid [IGP metric 0], #paths 1
Resolved prefix 192.168.3.0/24
gate 192.168.5.10, if r1-eth2
Last update: Mon Apr 1 21:55:16 2024
@mobash-rasool , this is intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nexthop tracking never displays the prefix that has been used in ZEBRA to resolve its nexthop. This information will be useful if some decision has to be taken regarding any loops, that is to say if for instance a BGP prefix is resolved over a prefix in ZEBRA that is exactly the same.
Store the value in bgp nexthop context, and display it.