nhrpd: unset noarp flag using a zapi message #15173
Conversation
| @@ -351,6 +351,7 @@ void nhrp_interface_update(struct interface *ifp) | |||
| if (!if_ad->configured) { | |||
| os_configure_dmvpn(ifp->ifindex, ifp->name, | |||
| afi2family(afi)); | |||
| nhrp_interface_update_arp(ifp, true); | |||
There was a problem hiding this comment.
did you move this out of "configure_dmvpn" on purpose, for some specific reason?
There was a problem hiding this comment.
the goal is to migrate all things from nhrp_linux.c
zebra/interface.h
Outdated
| @@ -314,6 +314,8 @@ extern int if_ipv6_address_install(struct interface *ifp, struct prefix *prefix, | |||
| extern int if_ip_address_uinstall(struct interface *ifp, struct prefix *prefix); | |||
| extern int if_shutdown(struct interface *ifp); | |||
| extern int if_no_shutdown(struct interface *ifp); | |||
| extern int if_arp_set(struct interface *ifp); | |||
There was a problem hiding this comment.
looks like these two functions are almost identical - could you converge to one, that takes a boolean?
There was a problem hiding this comment.
other functions in interface.* are dispatched. Just used the same pattern.
Moreover, it is more readable
There was a problem hiding this comment.
well, "same pattern", we have lots of patterns that are old, and that we don't want to continue to use, eh?
for me, the duplication of code is enough that it's not clearer: it'd be better to have 20 lines once, and then just the two different "set/unset" lines.
lib/zclient.c
Outdated
|
|
||
| zclient_create_header(s, ZEBRA_INTERFACE_SET_ARP, ifp->vrf->vrf_id); | ||
|
|
||
| stream_putl(s, ifp->vrf->vrf_id); |
There was a problem hiding this comment.
do you need this, since we have the vrf id in the message already?
louis-6wind
force-pushed
the
nhrp-noarp
branch
2 times, most recently
from
e142b77 to
7f037f1
Compare
Add a ZAPI message to control the setting of the IFF_NOARP flag. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Unset the IFF_NOARP interface flag using a ZAPI message. It removes the dependency to if.h headers. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Test the absence the NOARP flag on rX-gre0 interfaces. It is present by default. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Remove the unused netlink_configure_arp() declaration. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
louis-6wind
force-pushed
the
nhrp-noarp
branch
from
7f037f1 to
6a44127
Compare
Unset the IFF_NOARP interface flag using a ZAPI message. It removes the dependency to if.h headers.