vtysh_config: do not warn about non-existing configuration file

[nivelus]

We not always check return status, so it is not fatal to have missing file. And when it is fatal, we check status and print another message.

[ton31337]

And when it is fatal, we check status and print another message.

Which one?

[nivelus]

frr/vtysh/vtysh_config.c

Line 741 in 4a2ece9

"[%d|%s] Configuration file[%s] processing failure: %d\n",

-- code is a bit different from what I have (Debian 12).

[ton31337]

But processing failure: does not give the real reason why it's failed... Then we need to pass it logging there (vtysh_apply_config()) too?

[nivelus]

How about returning tuple (FRR error code and errno if needed or 0 otherwise) from vtysh_read_config, and translating errno to text in vtysh_apply_config functions? Or we can map errno to FRR error code, but I think it will create unneeded mess. vtysh_read_config is static, and used only here, so it's cheap to change return value.

[ton31337]

What if doing the reverse? Moving this kind of code:

		if (do_fork)
			fprintf(stderr,
				"[%d|%s] Configuration file[%s] processing failure: %d\n",
				getpid(), my_client, frr_config, ret);
		else
			fprintf(stderr,
				"Configuration file[%s] processing failure: %d\n",
				frr_config, ret);

to vtysh_read_config()?

[github-actions]

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.