Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lib dependency on mgmtd #14815

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Remove lib dependency on mgmtd #14815

merged 2 commits into from
Nov 22, 2023

Conversation

idryzhov
Copy link
Contributor

Common library code should not depend on the code of specific daemon.

@frrbot frrbot bot added libfrr mgmt FRR Management Infra labels Nov 17, 2023
@ton31337
Copy link
Member

ci:rerun

@idryzhov
lib, mgmtd: move common header to lib
c0568d4 
The common header included from lib and other daemons should be located
in lib, not in mgmt directory.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
@idryzhov
lib, mgmtd: remove function duplication
057f442 
And also remove lib dependency on mgmtd.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
@idryzhov
Copy link
Contributor Author

ci:rerun

1 similar comment
@idryzhov
Copy link
Contributor Author

ci:rerun

@donaldsharp donaldsharp requested a review from choppsv1 November 21, 2023 16:24
choppsv1
choppsv1 reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@choppsv1 choppsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what is being fixed with this change. Is it some redhat issue? We are moving #defines that are only used by mgmtd into lib, which seems wrong to me, no one else should need or be using them.

choppsv1
choppsv1 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@choppsv1 choppsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From slack...

The lib/mgmtd_client.h required the defines, and lib/ shouldn't reach into daemon dirs for includes.

@choppsv1 choppsv1 merged commit 79b7b8d into FRRouting:master Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choppsv1 choppsv1 choppsv1 approved these changes

Assignees
No one assigned
Labels
libfrr master mgmt FRR Management Infra size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idryzhov @ton31337 @choppsv1