Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Drop unnecessary null-termination for fqdn #14651

Merged
merged 1 commit into from
Oct 25, 2023
Merged

bgpd: Drop unnecessary null-termination for fqdn #14651

merged 1 commit into from
Oct 25, 2023

Conversation

ton31337
Copy link
Member

str[len] is already null terminated before:

		if (len > BGP_MAX_HOSTNAME) {
			memcpy(&str, data, BGP_MAX_HOSTNAME);
			str[BGP_MAX_HOSTNAME] = '\0';
		} else if (len) {
			memcpy(&str, data, len);
			str[len] = '\0';
		}

CID: 1569357

@ton31337
bgpd: Drop unnecessary null-termination for fqdn
0df6464 
str[len] is already null terminated before:

```
		if (len > BGP_MAX_HOSTNAME) {
			memcpy(&str, data, BGP_MAX_HOSTNAME);
			str[BGP_MAX_HOSTNAME] = '\0';
		} else if (len) {
			memcpy(&str, data, len);
			str[len] = '\0';
		}
```

CID: 1569357

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@frrbot frrbot bot added the bgp label Oct 25, 2023
riw777
riw777 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 91c5a47 into FRRouting:master Oct 25, 2023
@ton31337 ton31337 deleted the fix/bgpd_coverity_fqdn_capability branch October 25, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
bgp master size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ton31337 @riw777