Test sponging #14112
Merged
Test sponging #14112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran test under high load and system rejected the sharp install of routes. Only reason that that would happen would be if the address had not been set by the kernel yet. The test log files had timestamp precision and the addition of the sharp routes was under 1/10 of a second after the address was attempted to be installed. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Upstream ( and locally ) this test fails. The adj-sid value being looked for in the testing is a dynamic value that is assigned based upon how the network comes up. The reality is that there is no enforced order of what the adj-sid can be. As such this test looking for this value makes no sense. Let's remove that from the test. Additionally bring the isis hello-interval to 1 down from 3 to make things converge faster. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This test is failing upstream regularly, when inspecting the log files we see that the route being looked for is in a queued state when the test fails. Give this test more time for when the system is under severe load. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This test was failing upstream a bunch of times. Upon examining the log files as well as the test script it was noticed that the bfd peers were checked to see that they had come up. But both the timers used for bgp as well as not checking that bgp has actually come up would cause the test to fail in subsuquent steps if bgp has not come up. Test that bgp peering is actually established before testing link down events. It's possible this test might need to be revisited to ensure that the routes are actually installed and ready to go before as well, but I am not seeing that right now. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Current isis tests use a variety of hello timers as well as hello-multiplier, let's modify all of the isis test cases to use 1 and 10. This cleans up some spurious test failures I was seeing locally. As an example without these changes running isis_tilfa_topo1 2r6 times I would see 5-10 test failures now I am seeing ~2 test failures. In any event part of the problem was that some tests were not fully converged when looking at them under heavy system load. Changing this to 1/10 gives us 10 chances to see the incoming packet. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-13190/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13190/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun tests failed that I did not change |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13192/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun multicast failure these changes don't touch multicast |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13193/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a bunch of tests that are frequently failing. see individual commits