[draft] pimd: Auto enable pim-passive when IGMP is turned on.

[routingrocks]

Issue:
In order for IGMP to work (standalone), PIM should be enabled on the interface, which causes the sending of PIM control packets on the interface .This breaks a bunch of conformance tests, such as RFC3918 L3 tests.

Fix :

Automatically enable pim-passive when IGMP is enabled.

Signed-off-by: Rajesh Varatharaj rvaratharaj@nvidia.com

[Jafaral]

AFAIK, enabling PIM is not enough if you also don't have an RP configured.

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12576/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-12576/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

• Topotests Ubuntu 18.04 amd64 part 9
• Addresssanitizer topotests part 8
• Topotests debian 10 amd64 part 2
• Static analyzer (clang)
• Addresssanitizer topotests part 6
• Topotests Ubuntu 18.04 i386 part 5
• Ubuntu 20.04 deb pkg check
• Topotests Ubuntu 18.04 i386 part 0
• Ubuntu 18.04 deb pkg check
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 arm8 part 6
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 3
• Debian 9 deb pkg check
• Addresssanitizer topotests part 4
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests debian 10 amd64 part 5
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 arm8 part 7
• Topotests Ubuntu 18.04 arm8 part 8
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 amd64 part 5
• Topotests Ubuntu 18.04 amd64 part 2
• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests Ubuntu 18.04 i386 part 3
• Topotests debian 10 amd64 part 8
• Debian 10 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests Ubuntu 18.04 arm8 part 9
• Addresssanitizer topotests part 2
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 2
• Addresssanitizer topotests part 3
• Topotests debian 10 amd64 part 9
• Addresssanitizer topotests part 9
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12576/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-12576/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12576/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Report for pim_igmp.c | 10 issues
===============================================
< WARNING: please, no spaces at the start of a line
< #1197: FILE: /tmp/f1-550567/pim_igmp.c:1197:
< WARNING: braces {} are not necessary for single statement blocks
< #1197: FILE: /tmp/f1-550567/pim_igmp.c:1197:
< ERROR: code indent should use tabs where possible
< #1198: FILE: /tmp/f1-550567/pim_igmp.c:1198:
< WARNING: please, no spaces at the start of a line
< #1198: FILE: /tmp/f1-550567/pim_igmp.c:1198:
< WARNING: please, no spaces at the start of a line
< #1199: FILE: /tmp/f1-550567/pim_igmp.c:1199:

[riw777]

AFAIK, enabling PIM is not enough if you also don't have an RP configured.

This is correct ... Juniper and Cisco only enable when there is an RP configured.

https://techhub.hpe.com/eginfolib/networking/docs/switches/7500/5200-1936a_ip-multi_cg/content/495505207.htm

[riw777]

this should check for an RP before enabling

[riw777]

is anyone still working on this?

[riw777]

@frrbot autoclose in 1 month