tests: fixing pim6 topotest bugs (backport #13726) #13744
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Christian Hopps <chopps@labn.net> (cherry picked from commit 71231d3)
- Remove use of bespoke socat - Use ipv6 support in mcast-tester.py - do not run processes in the background behind munet/micronet's back with `&` (ever) -- use popen or the helper class Signed-off-by: Christian Hopps <chopps@labn.net> (cherry picked from commit efedb18)
This is a good way to run a per-test background helper process. Here the helper object is created before the test function requesting it (through param name match), and then cleaned up after the test function exits (pass or failed). A context manager is used to further guarantee the cleanup is done. Signed-off-by: Christian Hopps <chopps@labn.net> (cherry picked from commit b28bc25)
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12152/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12152/ This is a comment from an automated CI system. |
This is an automatic backport of pull request #13726 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com