vrrp: check return value for turning off multicast for v6 #13731

loganaden · 2023-06-08T10:50:48Z

CID1519841: check return value and set error

NetDEF-CI · 2023-06-08T14:09:28Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12125/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12125/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12125/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12125/artifact/TOPO9U18I386/TopotestDetails/

Successful on other platforms/tests

Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 8
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 6
Debian 10 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 5
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12125/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12125/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12125/artifact/TOPO9U18I386/TopotestDetails/

Report for vrrp.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1247: FILE: /tmp/f1-2169260/vrrp.c:1247:
< WARNING: please, no spaces at the start of a line
< #1247: FILE: /tmp/f1-2169260/vrrp.c:1247:
< ERROR: code indent should use tabs where possible
< #1248: FILE: /tmp/f1-2169260/vrrp.c:1248:
< WARNING: please, no spaces at the start of a line
< #1248: FILE: /tmp/f1-2169260/vrrp.c:1248:

ton31337 · 2023-06-08T14:30:34Z

Need to fix styling:

diff --git a/vrrpd/vrrp.c b/vrrpd/vrrp.c
index 939bd0f3c..b14a6ecc4 100644
--- a/vrrpd/vrrp.c
+++ b/vrrpd/vrrp.c
@@ -1242,10 +1242,10 @@ static int vrrp_socket(struct vrrp_router *r)
 		/* Turn off multicast loop on Tx */
 		if (setsockopt_ipv6_multicast_loop(r->sock_tx, 0) < 0) {
 			zlog_warn(VRRP_LOGPFX VRRP_LOGPFX_VRID VRRP_LOGPFX_FAM
-				"Failed to turn off IPv6 multicast",
-				r->vr->vrid, family2str(r->family));
-                        failed = true;
-                        goto done;
+				  "Failed to turn off IPv6 multicast",
+				  r->vr->vrid, family2str(r->family));
+			failed = true;
+			goto done;
 		}
 
 		/* Bind Rx socket to exact interface */

CID1519841: check return value and set error Signed-off-by: Loganaden Velvindron <logan@cyberstorm.mu>

NetDEF-CI · 2023-06-13T16:32:22Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12288/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12288/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12288/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12288/artifact/TOPO9U18I386/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Debian 10 deb pkg check
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 9
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 1
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 7
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12288/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12288/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12288/artifact/TOPO9U18I386/TopotestDetails/

Report for vrrp.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1247: FILE: /tmp/f1-2161995/vrrp.c:1247:
< WARNING: please, no spaces at the start of a line
< #1247: FILE: /tmp/f1-2161995/vrrp.c:1247:
< ERROR: code indent should use tabs where possible
< #1248: FILE: /tmp/f1-2161995/vrrp.c:1248:
< WARNING: please, no spaces at the start of a line
< #1248: FILE: /tmp/f1-2161995/vrrp.c:1248:

NetDEF-CI · 2023-06-13T16:57:31Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12287/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12287/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Addresssanitizer topotests part 4: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `ce1`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000004826 (pc 0x7f79d91b03a6 bp 0x00000000029c sp 0x7ffd2dca8fb0 T0)
        #0 0x7f79d91b03a5  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5)
        #1 0x7f79d91b1443  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2b443)
        #2 0x7f79d9264772 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde772)
        #3 0x55919db341bf in qfree lib/memory.c:130
        #4 0x55919db498c1 in nexthop_free lib/nexthop.c:383
        #5 0x55919db498f3 in nexthops_free lib/nexthop.c:393
        #6 0x55919da0712c in zebra_nhg_free_members zebra/zebra_nhg.c:1609
        #7 0x55919da0712c in zebra_nhg_free zebra/zebra_nhg.c:1634
        #8 0x55919d9e11d5 in mpls_ftn_uninstall_all zebra/zebra_mpls.c:3484
        #9 0x55919d9e1e1a in zebra_mpls_cleanup_zclient_labels zebra/zebra_mpls.c:2526
        #10 0x55919daa1639 in hook_call_zserv_client_close zebra/zserv.c:561
        #11 0x55919daa1639 in zserv_client_free zebra/zserv.c:580
        #12 0x55919daa1639 in zserv_close_client zebra/zserv.c:701
        #13 0x55919d946ac0 in sigint zebra/main.c:156
        #14 0x55919dba3c14 in frr_sigevent_process lib/sigevent.c:115
        #15 0x55919dbce8cf in event_fetch lib/event.c:1761
        #16 0x55919db16a62 in frr_run lib/libfrr.c:1212
        #17 0x55919d947394 in main zebra/main.c:472
        #18 0x7f79d7ac0c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #19 0x55919d913ce9 in _start (/usr/lib/frr/zebra+0x2f7ce9)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5) 

---------------
## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `ce2`

    ERROR: AddressSanitizer: SEGV on unknown address 0x0000000048fd (pc 0x7fcd981525f0 bp 0x619000af6e80 sp 0x7ffcd826cef8 T0)
        #0 0x7fcd981525ef  (/lib/x86_64-linux-gnu/libc.so.6+0xbb5ef)
        #1 0x7fcd997a5080  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x27080)
        #2 0x7fcd9985ccf0 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdecf0)
        #3 0x55cc01e6482b in qcalloc lib/memory.c:105
        #4 0x55cc01ccc77a in dplane_ctx_alloc zebra/zebra_dplane.c:651
        #5 0x55cc01cd64c3 in dplane_route_update_internal zebra/zebra_dplane.c:3676
        #6 0x55cc01cd6cf1 in dplane_route_delete zebra/zebra_dplane.c:3992
        #7 0x55cc01d52446 in rib_uninstall_kernel zebra/zebra_rib.c:741
        #8 0x55cc01d6115b in rib_close_table zebra/zebra_rib.c:4668
        #9 0x55cc01d7a16b in zebra_vrf_disable zebra/zebra_vrf.c:192
        #10 0x55cc01f0904d in vrf_disable lib/vrf.c:325
        #11 0x55cc01f09550 in vrf_terminate_single lib/vrf.c:512
        #12 0x55cc01f09d93 in vrf_terminate lib/vrf.c:543
        #13 0x55cc01c77ca2 in zebra_finalize zebra/main.c:207
        #14 0x55cc01f01cd8 in event_call lib/event.c:1995
        #15 0x55cc01e47a57 in frr_run lib/libfrr.c:1213
        #16 0x55cc01c78394 in main zebra/main.c:472
        #17 0x7fcd980b8c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #18 0x55cc01c44ce9 in _start (/usr/lib/frr/zebra+0x2f7ce9)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libc.so.6+0xbb5ef) 

---------------

Addresssanitizer topotests part 4: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12287/artifact/ASANP4/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASANP4-12287/test

Topology Tests failed for Addresssanitizer topotests part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12287/artifact/ASANP4/Topotest-Logs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 9: Incomplete

(check logs for details)

Addresssanitizer topotests part 7: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-12287/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12287/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12287/artifact/TOPOU1804/TopotestDetails/

Addresssanitizer topotests part 6: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Debian 9 deb pkg check
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 7

NetDEF-CI · 2023-06-13T18:08:36Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12294/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 1: Incomplete

(check logs for details)

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12294/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12294/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12294/artifact/TOPO9DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Addresssanitizer topotests part 0
Debian 10 deb pkg check
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 9
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 9
Debian 9 deb pkg check
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2

riw777

looks good

riw777 · 2023-06-21T12:45:38Z

ospf failure
ci:rerun

NetDEF-CI · 2023-06-21T16:13:48Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12449/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

github-actions bot added size/XS master labels Jun 8, 2023

ton31337 mentioned this pull request Jun 8, 2023

vrrp: Check ret value. #13172

Closed

vrrp: check return value for turning off multicast for v6

56e52d8

CID1519841: check return value and set error Signed-off-by: Loganaden Velvindron <logan@cyberstorm.mu>

loganaden force-pushed the cid1519841 branch from eaac340 to 56e52d8 Compare June 13, 2023 12:56

github-actions bot added the rebase PR needs rebase label Jun 13, 2023

riw777 self-requested a review June 20, 2023 15:49

riw777 approved these changes Jun 21, 2023

View reviewed changes

mobash-rasool approved these changes Jun 21, 2023

View reviewed changes

mobash-rasool merged commit d94c373 into FRRouting:master Jun 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vrrp: check return value for turning off multicast for v6 #13731

vrrp: check return value for turning off multicast for v6 #13731

loganaden commented Jun 8, 2023

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

ton31337 commented Jun 8, 2023

NetDEF-CI commented Jun 13, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 13, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Jun 13, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

riw777 left a comment

riw777 commented Jun 21, 2023

NetDEF-CI commented Jun 21, 2023

vrrp: check return value for turning off multicast for v6 #13731

vrrp: check return value for turning off multicast for v6 #13731

Conversation

loganaden commented Jun 8, 2023

NetDEF-CI commented Jun 8, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

ton31337 commented Jun 8, 2023

NetDEF-CI commented Jun 13, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 13, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Jun 13, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

riw777 left a comment

Choose a reason for hiding this comment

riw777 commented Jun 21, 2023

NetDEF-CI commented Jun 21, 2023

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

NetDEF-CI commented Jun 13, 2023 •

edited

Loading

NetDEF-CI commented Jun 13, 2023 •

edited

Loading

NetDEF-CI commented Jun 13, 2023 •

edited

Loading