bgpd: Fix memory leak #13537

Keelan10 · 2023-05-16T10:48:19Z

Free VRF to VPN SID resources on BGP VRF shutdown

This PR resolves the following memory leaks detected by ASan:

./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144:Direct leak of 592 byte(s) in 2 object(s) allocated from:
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #0 0x7f49ab936037 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #1 0x7f49ab4dc1ee in qcalloc lib/memory.c:105
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #2 0x7f49ab4ef696 in srv6_locator_chunk_alloc lib/srv6.c:135
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #3 0x55673b2dc11b in ensure_vrf_tovpn_sid_per_af bgpd/bgp_mplsvpn.c:752
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #4 0x55673b2dcaad in ensure_vrf_tovpn_sid bgpd/bgp_mplsvpn.c:846
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #5 0x55673b2d7180 in vpn_leak_postchange bgpd/bgp_mplsvpn.h:259
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #6 0x55673b2ea87e in vpn_leak_postchange_all bgpd/bgp_mplsvpn.c:3397
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #7 0x55673b488e57 in bgp_zebra_process_srv6_locator_chunk bgpd/bgp_zebra.c:3259
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #8 0x7f49ab609c22 in zclient_read lib/zclient.c:4134
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #9 0x7f49ab5b6bf7 in event_call lib/event.c:1995
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #10 0x7f49ab49f99d in frr_run lib/libfrr.c:1185
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #11 0x55673b1ce59d in main bgpd/bgp_main.c:505
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #12 0x7f49aae86d09 in __libc_start_main ../csu/libc-start.c:308
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144:Direct leak of 32 byte(s) in 2 object(s) allocated from:
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #0 0x7f49ab936037 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #1 0x7f49ab4dc1ee in qcalloc lib/memory.c:105
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #2 0x55673b2d9bdb in vpn_leak_zebra_vrf_sid_update_per_af bgpd/bgp_mplsvpn.c:386
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #3 0x55673b2da50b in vpn_leak_zebra_vrf_sid_update bgpd/bgp_mplsvpn.c:448
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #4 0x55673b2d73d3 in vpn_leak_postchange bgpd/bgp_mplsvpn.h:271
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #5 0x55673b2ea87e in vpn_leak_postchange_all bgpd/bgp_mplsvpn.c:3397
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #6 0x55673b488e57 in bgp_zebra_process_srv6_locator_chunk bgpd/bgp_zebra.c:3259
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #7 0x7f49ab609c22 in zclient_read lib/zclient.c:4134
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #8 0x7f49ab5b6bf7 in event_call lib/event.c:1995
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #9 0x7f49ab49f99d in frr_run lib/libfrr.c:1185
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #10 0x55673b1ce59d in main bgpd/bgp_main.c:505
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #11 0x7f49aae86d09 in __libc_start_main ../csu/libc-start.c:308
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144:Direct leak of 32 byte(s) in 2 object(s) allocated from:
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #0 0x7f49ab936037 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #1 0x7f49ab4dc1ee in qcalloc lib/memory.c:105
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #2 0x55673b2dc153 in ensure_vrf_tovpn_sid_per_af bgpd/bgp_mplsvpn.c:753
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #3 0x55673b2dcaad in ensure_vrf_tovpn_sid bgpd/bgp_mplsvpn.c:846
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #4 0x55673b2d7180 in vpn_leak_postchange bgpd/bgp_mplsvpn.h:259
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #5 0x55673b2ea87e in vpn_leak_postchange_all bgpd/bgp_mplsvpn.c:3397
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #6 0x55673b488e57 in bgp_zebra_process_srv6_locator_chunk bgpd/bgp_zebra.c:3259
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #7 0x7f49ab609c22 in zclient_read lib/zclient.c:4134
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #8 0x7f49ab5b6bf7 in event_call lib/event.c:1995
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #9 0x7f49ab49f99d in frr_run lib/libfrr.c:1185
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #10 0x55673b1ce59d in main bgpd/bgp_main.c:505
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-    #11 0x7f49aae86d09 in __libc_start_main ../csu/libc-start.c:308
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-
./bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r2.bgpd.asan.1083144-SUMMARY: AddressSanitizer: 656 byte(s) leaked in 6 allocation(s).

./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770:Direct leak of 296 byte(s) in 1 object(s) allocated from:
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #0 0x7f1d6a6d7037 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #1 0x7f1d6a27d1ee in qcalloc lib/memory.c:105
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #2 0x7f1d6a290696 in srv6_locator_chunk_alloc lib/srv6.c:135
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #3 0x55bcb2a7511b in ensure_vrf_tovpn_sid_per_af bgpd/bgp_mplsvpn.c:752
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #4 0x55bcb2a75aad in ensure_vrf_tovpn_sid bgpd/bgp_mplsvpn.c:846
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #5 0x55bcb2a70180 in vpn_leak_postchange bgpd/bgp_mplsvpn.h:259
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #6 0x55bcb2a83861 in vpn_leak_postchange_all bgpd/bgp_mplsvpn.c:3391
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #7 0x55bcb2c21e57 in bgp_zebra_process_srv6_locator_chunk bgpd/bgp_zebra.c:3259
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #8 0x7f1d6a3aac22 in zclient_read lib/zclient.c:4134
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #9 0x7f1d6a357bf7 in event_call lib/event.c:1995
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #10 0x7f1d6a24099d in frr_run lib/libfrr.c:1185
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #11 0x55bcb296759d in main bgpd/bgp_main.c:505
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #12 0x7f1d69c27d09 in __libc_start_main ../csu/libc-start.c:308
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770:Direct leak of 16 byte(s) in 1 object(s) allocated from:
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #0 0x7f1d6a6d7037 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #1 0x7f1d6a27d1ee in qcalloc lib/memory.c:105
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #2 0x55bcb2a72bdb in vpn_leak_zebra_vrf_sid_update_per_af bgpd/bgp_mplsvpn.c:386
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #3 0x55bcb2a7350b in vpn_leak_zebra_vrf_sid_update bgpd/bgp_mplsvpn.c:448
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #4 0x55bcb2a703d3 in vpn_leak_postchange bgpd/bgp_mplsvpn.h:271
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #5 0x55bcb2a83861 in vpn_leak_postchange_all bgpd/bgp_mplsvpn.c:3391
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #6 0x55bcb2c21e57 in bgp_zebra_process_srv6_locator_chunk bgpd/bgp_zebra.c:3259
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #7 0x7f1d6a3aac22 in zclient_read lib/zclient.c:4134
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #8 0x7f1d6a357bf7 in event_call lib/event.c:1995
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #9 0x7f1d6a24099d in frr_run lib/libfrr.c:1185
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #10 0x55bcb296759d in main bgpd/bgp_main.c:505
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #11 0x7f1d69c27d09 in __libc_start_main ../csu/libc-start.c:308
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770:Direct leak of 16 byte(s) in 1 object(s) allocated from:
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #0 0x7f1d6a6d7037 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #1 0x7f1d6a27d1ee in qcalloc lib/memory.c:105
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #2 0x55bcb2a75153 in ensure_vrf_tovpn_sid_per_af bgpd/bgp_mplsvpn.c:753
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #3 0x55bcb2a75aad in ensure_vrf_tovpn_sid bgpd/bgp_mplsvpn.c:846
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #4 0x55bcb2a70180 in vpn_leak_postchange bgpd/bgp_mplsvpn.h:259
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #5 0x55bcb2a83861 in vpn_leak_postchange_all bgpd/bgp_mplsvpn.c:3391
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #6 0x55bcb2c21e57 in bgp_zebra_process_srv6_locator_chunk bgpd/bgp_zebra.c:3259
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #7 0x7f1d6a3aac22 in zclient_read lib/zclient.c:4134
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #8 0x7f1d6a357bf7 in event_call lib/event.c:1995
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #9 0x7f1d6a24099d in frr_run lib/libfrr.c:1185
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #10 0x55bcb296759d in main bgpd/bgp_main.c:505
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-    #11 0x7f1d69c27d09 in __libc_start_main ../csu/libc-start.c:308
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-
./bgp_srv6l3vpn_route_leak.test_bgp_srv6l3vpn_route_leak/pe1.bgpd.asan.1066770-SUMMARY: AddressSanitizer: 328 byte(s) leaked in 3 allocation(s).

Free VRF to VPN SID resources on BGP VRF shutdown Signed-off-by: Keelan Cannoo <keelan.cannoo@icloud.com>

ton31337

Please add a full backtrace into the commit for the history.

ton31337 · 2023-05-16T12:21:39Z

bgpd/bgp_mplsvpn.c

+	struct bgp *bgp;
+	struct bgp *bgp_default = bgp_get_default();
+
+	assert(bgp_default);


Maybe we should check BGP_FLAG_DELETE_IN_PROGRESS?

NetDEF-CI · 2023-05-16T13:11:52Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/artifact/TOPO3U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/artifact/TOPO3U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 3: No useful log found

Topotests debian 10 amd64 part 3: Failed (click for details)

Topotests debian 10 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/artifact/TOPO3DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/artifact/TOPO3DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 3: No useful log found

Successful on other platforms/tests

Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 5
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 1
Static analyzer (clang)
Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 1
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/artifact/TOPO3U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/artifact/TOPO3U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 3: No useful log found

Topotests debian 10 amd64 part 3: Failed (click for details)

Topotests debian 10 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/artifact/TOPO3DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11575/artifact/TOPO3DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 3: No useful log found

Report for bgp_mplsvpn.c | 6 issues
===============================================
< ERROR: open brace '{' following function declarations go on the next line
< #3870: FILE: /tmp/f1-1084466/bgp_mplsvpn.c:3870:
< WARNING: suspect code indent for conditional statements (16, 16)
< #3878: FILE: /tmp/f1-1084466/bgp_mplsvpn.c:3878:
< WARNING: adding a line without newline at end of file
< #3883: FILE: /tmp/f1-1084466/bgp_mplsvpn.c:3883:

NetDEF-CI · 2023-05-16T13:19:55Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 6: Failed (click for details)

Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/artifact/TOPO6DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/artifact/TOPO6DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 6: No useful log found

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/artifact/TOPO6U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/artifact/TOPO6U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 6: No useful log found

Successful on other platforms/tests

Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 1
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 9
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 6: Failed (click for details)

Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/artifact/TOPO6DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/artifact/TOPO6DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 6: No useful log found

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/artifact/TOPO6U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11576/artifact/TOPO6U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 6: No useful log found

Report for bgp_mplsvpn.c | 2 issues
===============================================
< WARNING: adding a line without newline at end of file
< #3884: FILE: /tmp/f1-1102939/bgp_mplsvpn.c:3884:

ton31337 · 2023-05-17T18:51:06Z

@Mergifyio backport stable/8.5

mergify · 2023-05-17T18:51:09Z

backport stable/8.5

🟠 Waiting for conditions to match

merged [:pushpin: backport requirement]

frrbot bot added the bgp label May 16, 2023

github-actions bot added size/S master labels May 16, 2023

bgpd: Fix memory leak

0b5afac

Free VRF to VPN SID resources on BGP VRF shutdown Signed-off-by: Keelan Cannoo <keelan.cannoo@icloud.com>

Keelan10 force-pushed the bgpd-memory-leak branch from 7b274ed to 0b5afac Compare May 16, 2023 10:50

ton31337 requested changes May 16, 2023

View reviewed changes

github-actions bot added the backport label May 17, 2023

Keelan10 closed this May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bgpd: Fix memory leak #13537

bgpd: Fix memory leak #13537

Keelan10 commented May 16, 2023

ton31337 left a comment

ton31337 May 16, 2023

NetDEF-CI commented May 16, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented May 16, 2023

ton31337 commented May 17, 2023

mergify bot commented May 17, 2023

bgpd: Fix memory leak #13537

bgpd: Fix memory leak #13537

Conversation

Keelan10 commented May 16, 2023

ton31337 left a comment

Choose a reason for hiding this comment

ton31337 May 16, 2023

Choose a reason for hiding this comment

NetDEF-CI commented May 16, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented May 16, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

ton31337 commented May 17, 2023

mergify bot commented May 17, 2023

🟠 Waiting for conditions to match

NetDEF-CI commented May 16, 2023 •

edited

Loading