Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: display BGP Link-State attributes #13299

Closed
wants to merge 20 commits into from
Closed

bgpd: display BGP Link-State attributes #13299

wants to merge 20 commits into from

Conversation

louis-6wind
Copy link
Contributor

Continuation of #12649

Add display of BGP Link-State attributes

@louis-6wind louis-6wind marked this pull request as draft April 13, 2023 15:58
@louis-6wind louis-6wind force-pushed the bgp-link-state-attr branch from 0bdeca4 to 3c3605b Compare April 13, 2023 16:24
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 13, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10870/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10870/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10870/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10870/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_nlri_node_descriptor_json:
bgpd/bgp_linkstate_tlv.c:579:55: error: format %pSY expects argument of type uint8_t {aka unsigned char} *, but argument 4 has type uint64_t * {aka long unsigned int *} [-Werror=format=]
bgpd/bgp_linkstate_tlv.c:583:55: error: format %pPN expects argument of type uint8_t {aka unsigned char} *, but argument 4 has type uint64_t * {aka long unsigned int *} [-Werror=format=]
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_list_display:
bgpd/bgp_linkstate_tlv.c:1986:23: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
 1986 |    vty_out(vty, "%s%llu", i == 0 ? "" : ", ",
 1987 |     pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_display:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10870/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Ubuntu 16.04 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 arm8 build
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 11 amd64 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 ppc64le build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10870/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10870/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10870/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_nlri_node_descriptor_json:
bgpd/bgp_linkstate_tlv.c:579:55: error: format %pSY expects argument of type uint8_t {aka unsigned char} *, but argument 4 has type uint64_t * {aka long unsigned int *} [-Werror=format=]
bgpd/bgp_linkstate_tlv.c:583:55: error: format %pPN expects argument of type uint8_t {aka unsigned char} *, but argument 4 has type uint64_t * {aka long unsigned int *} [-Werror=format=]
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_list_display:
bgpd/bgp_linkstate_tlv.c:1986:23: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
 1986 |    vty_out(vty, "%s%llu", i == 0 ? "" : ", ",
 1987 |     pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_display:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10870/artifact/DEB11AMD64/config.status/config.status

<stdin>:5078: new blank line at EOF.
+
<stdin>:7117: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for bgpd.c | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #4326: FILE: /tmp/f1-177959/bgpd.c:4326:
< WARNING: please, no spaces at the start of a line
< #4326: FILE: /tmp/f1-177959/bgpd.c:4326:
< ERROR: code indent should use tabs where possible
< #4327: FILE: /tmp/f1-177959/bgpd.c:4327:
< WARNING: please, no spaces at the start of a line
< #4327: FILE: /tmp/f1-177959/bgpd.c:4327:
< ERROR: code indent should use tabs where possible
< #4348: FILE: /tmp/f1-177959/bgpd.c:4348:
< WARNING: please, no spaces at the start of a line
< #4348: FILE: /tmp/f1-177959/bgpd.c:4348:
< ERROR: code indent should use tabs where possible
< #4349: FILE: /tmp/f1-177959/bgpd.c:4349:
< WARNING: please, no spaces at the start of a line
< #4349: FILE: /tmp/f1-177959/bgpd.c:4349:
Report for bgpd.h | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #2543: FILE: /tmp/f1-177959/bgpd.h:2543:
< WARNING: please, no spaces at the start of a line
< #2543: FILE: /tmp/f1-177959/bgpd.h:2543:
< ERROR: code indent should use tabs where possible
< #2544: FILE: /tmp/f1-177959/bgpd.h:2544:
< WARNING: please, no spaces at the start of a line
< #2544: FILE: /tmp/f1-177959/bgpd.h:2544:
< ERROR: code indent should use tabs where possible
< #2565: FILE: /tmp/f1-177959/bgpd.h:2565:
< WARNING: please, no spaces at the start of a line
< #2565: FILE: /tmp/f1-177959/bgpd.h:2565:
< ERROR: code indent should use tabs where possible
< #2566: FILE: /tmp/f1-177959/bgpd.h:2566:
< WARNING: please, no spaces at the start of a line
< #2566: FILE: /tmp/f1-177959/bgpd.h:2566:
Report for bgp_errors.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #456: FILE: /tmp/f1-177959/bgp_errors.c:456:
< WARNING: line over 80 characters
< #461: FILE: /tmp/f1-177959/bgp_errors.c:461:
< WARNING: line over 80 characters
< #462: FILE: /tmp/f1-177959/bgp_errors.c:462:
< WARNING: line over 80 characters
< #466: FILE: /tmp/f1-177959/bgp_errors.c:466:
Report for bgp_linkstate_tlv.c | 214 issues
===============================================
ERROR: that open brace { should be on the previous line
#40: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:40:
+	[BGP_LS_TLV_LINK_LOCAL_REMOTE_IDENTIFIERS] =
+		{"Link Local/Remote Identifiers", 2, 2, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:51:
+	[BGP_LS_TLV_IP_REACHABILITY_INFORMATION] =
+		{"IP Reachability Information", 2, 17, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#73: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:73:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_LOCAL_NODE] =
+		{"IPv4 Router-ID of Local Node", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#75: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:75:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_LOCAL_NODE] =
+		{"IPv6 Router-ID of Local Node", 16, 16, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#77: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:77:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_REMOTE_NODE] =
+		{"IPv4 Router-ID of Remote Node", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#79: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:79:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_REMOTE_NODE] =
+		{"IPv6 Router-ID of Remote Node", 16, 16, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#89: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:89:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION] =
+		{"Flexible Algorithm Definition", 4, MAX_SZ, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:91:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_ANY_AFFINITY] =
+		{"Flexible Algorithm Exclude Any Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#93: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:93:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ANY_AFFINITY] =
+		{"Flexible Algorithm Include Any Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#95: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:95:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ALL_AFFINITY] =
+		{"Flexible Algorithm Include All Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#97: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:97:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION_FLAGS] =
+		{"Flexible Algorithm Definition Flags", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#99: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:99:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_PREFIX_METRIC] =
+		{"Flexible Algorithm Prefix Metric", 8, 8, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#101: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:101:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_SRLG] =
+		{"Flexible Algorithm Exclude SRLG", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#107: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:107:
+	[BGP_LS_TLV_MAX_RESERVABLE_LINK_BANDWIDTH] =
+		{"Max. reservable link bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#133: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:133:
+	[BGP_LS_TLV_MIN_MAX_UNIDIRECTIONAL_LINK_DELAY] =
+		{"Min/Max Unidirectional Link Delay", 8, 8, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#135: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:135:
+	[BGP_LS_TLV_UNIDIRECTIONAL_DELAY_VARIATION] =
+		{"Unidirectional Delay Variation", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#139: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:139:
+	[BGP_LS_TLV_UNIDIRECTIONAL_RESIDUAL_BANDWIDTH] =
+		{"Unidirectional Residual Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#141: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:141:
+	[BGP_LS_TLV_UNIDIRECTIONAL_AVAILABLE_BANDWIDTH] =
+		{"Unidirectional Available Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#143: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:143:
+	[BGP_LS_TLV_UNIDIRECTIONAL_UTILIZED_BANDWIDTH] =
+		{"Unidirectional Utilized Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#147: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:147:
+	[BGP_LS_TLV_APPLICATION_SPECIFIC_LINK_ATTRIBUTES] =
+		{"Application-Specific Link Attributes", 11, MAX_SZ,

ERROR: that open brace { should be on the previous line
#166: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:166:
+	[BGP_LS_TLV_L2_BUNDLE_MEMBER_ATTRIBUTES] =
+		{"L2 Bundle Member Attributes", 4, MAX_SZ, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#168: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:168:
+	[BGP_LS_TLV_EXTENDED_ADMINISTRATIVE_GROUP] =
+		{"Extended Administrative Group", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#180: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:180:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_HEAD_END_ADDRESS_TLV] =
+		{"IPv4/6 Tunnel Head-end address TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#183: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:183:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_TAIL_END_ADDRESS_TLV] =
+		{"IPv4/6 Tunnel Tail-end address TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#186: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:186:
+	[BGP_LS_TLV_SR_POLICY_CP_DESCRIPTOR_TLV] =
+		{"SR Policy CP Descriptor TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#189: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:189:
+	[BGP_LS_TLV_MPLS_LOCAL_CROSS_CONNECT_TLV] =
+		{"MPLS Local Cross Connect TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#192: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:192:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_INTERFACE_TLV] =
+		{"MPLS Cross Connect Interface TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#201: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:201:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_UNSUPPORTED] =
+		{"Flexible Algorithm Unsupported", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#206: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:206:
+	[BGP_LS_TLV_IS_IS_SRV6_LAN_END_X_SID_TLV] =
+		{"IS-IS SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#209: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:209:
+	[BGP_LS_TLV_OSPFV3_SRV6_LAN_END_X_SID_TLV] =
+		{"OSPFv3 SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#233: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:233:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_METRIC_SUB_TLV] =
+		{"SR Segment List Metric sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#236: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:236:
+	[BGP_LS_TLV_SR_AFFINITY_CONSTRAINT_SUB_TLV] =
+		{"SR Affinity Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#242: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:242:
+	[BGP_LS_TLV_SR_BANDWIDTH_CONSTRAINT_SUB_TLV] =
+		{"SR Bandwidth Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#245: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:245:
+	[BGP_LS_TLV_SR_DISJOINT_GROUP_CONSTRAINT_SUB_TLV] =
+		{"SR Disjoint Group Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

WARNING: line over 80 characters
#732: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:732:
+		assert(!"bgp_linkstate_nlri_link_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_link_descriptor_decode', this function's name, in a string
#732: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:732:
+		assert(!"bgp_linkstate_nlri_link_descriptor_decode() must not be called for this TLV type!");

WARNING: line over 80 characters
#1070: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:1070:
+		assert(!"bgp_linkstate_nlri_prefix4_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_prefix4_descriptor_decode', this function's name, in a string
#1070: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:1070:
+		assert(!"bgp_linkstate_nlri_prefix4_descriptor_decode() must not be called for this TLV type!");

WARNING: Block comments use * on subsequent lines
#1092: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:1092:
+		/*
+		   The Type and Length fields of the TLV are defined in Table 6.

WARNING: line over 80 characters
#1351: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:1351:
+		assert(!"bgp_linkstate_nlri_prefix6_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_prefix6_descriptor_decode', this function's name, in a string
#1351: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:1351:
+		assert(!"bgp_linkstate_nlri_prefix6_descriptor_decode() must not be called for this TLV type!");

WARNING: Block comments use * on subsequent lines
#1373: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:1373:
+		/*
+		   The Type and Length fields of the TLV are defined in Table 6.

WARNING: Missing a blank line after declarations
#1765: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:1765:
+	json_object *json_type = json_object_new_object();
+	json_object_object_add(json, "linkStateNLRI", json_type);

WARNING: braces {} are not necessary for single statement blocks
#2345: FILE: /tmp/f1-177959/bgp_linkstate_tlv.c:2345:
+	if (json) {
+	}
Report for bgp_linkstate_tlv.h | 9 issues
===============================================
WARNING: Block comments use * on subsequent lines
#15: FILE: /tmp/f1-177959/bgp_linkstate_tlv.h:15:
+/* RFC7752 Link-State NLRI Protocol-ID values
+	+-------------+----------------------------------+

WARNING: line over 80 characters
#39: FILE: /tmp/f1-177959/bgp_linkstate_tlv.h:39:
+ * https://www.iana.org/assignments/bgp-ls-parameters/bgp-ls-parameters.xhtml#node-descriptor-link-descriptor-prefix-descriptor-attribute-tlv
Report for bgp_vty.c | 4 issues
===============================================
< ERROR: code indent should use tabs where possible
< #10288: FILE: /tmp/f1-177959/bgp_vty.c:10288:
< WARNING: please, no spaces at the start of a line
< #10288: FILE: /tmp/f1-177959/bgp_vty.c:10288:
Report for prefix.h | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #358: FILE: /tmp/f1-177959/prefix.h:358:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 13, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10872/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10872/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10872/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10872/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_list_display:
bgpd/bgp_linkstate_tlv.c:1988:23: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
 1988 |    vty_out(vty, "%s%llu", i == 0 ? "" : ", ",
 1989 |     pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_display:
bgpd/bgp_linkstate_tlv.c:2034:20: error: format %llu expects argument of type long long unsigned int, but argument 3 has type uint64_t {aka long unsigned int} [-Werror=format=]
 2034 |   vty_out(vty, "%llu\n", pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10872/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Ubuntu 18.04 ppc64le build
  • FreeBSD 12 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • OpenBSD 7 amd64 build
  • Ubuntu 16.04 arm7 build
  • CentOS 7 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 22.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 20.04 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 16.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10872/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10872/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10872/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_list_display:
bgpd/bgp_linkstate_tlv.c:1988:23: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
 1988 |    vty_out(vty, "%s%llu", i == 0 ? "" : ", ",
 1989 |     pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_display:
bgpd/bgp_linkstate_tlv.c:2034:20: error: format %llu expects argument of type long long unsigned int, but argument 3 has type uint64_t {aka long unsigned int} [-Werror=format=]
 2034 |   vty_out(vty, "%llu\n", pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10872/artifact/DEB11AMD64/config.status/config.status

<stdin>:5083: new blank line at EOF.
+
<stdin>:7122: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for bgpd.c | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #4326: FILE: /tmp/f1-351807/bgpd.c:4326:
< WARNING: please, no spaces at the start of a line
< #4326: FILE: /tmp/f1-351807/bgpd.c:4326:
< ERROR: code indent should use tabs where possible
< #4327: FILE: /tmp/f1-351807/bgpd.c:4327:
< WARNING: please, no spaces at the start of a line
< #4327: FILE: /tmp/f1-351807/bgpd.c:4327:
< ERROR: code indent should use tabs where possible
< #4348: FILE: /tmp/f1-351807/bgpd.c:4348:
< WARNING: please, no spaces at the start of a line
< #4348: FILE: /tmp/f1-351807/bgpd.c:4348:
< ERROR: code indent should use tabs where possible
< #4349: FILE: /tmp/f1-351807/bgpd.c:4349:
< WARNING: please, no spaces at the start of a line
< #4349: FILE: /tmp/f1-351807/bgpd.c:4349:
Report for bgpd.h | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #2543: FILE: /tmp/f1-351807/bgpd.h:2543:
< WARNING: please, no spaces at the start of a line
< #2543: FILE: /tmp/f1-351807/bgpd.h:2543:
< ERROR: code indent should use tabs where possible
< #2544: FILE: /tmp/f1-351807/bgpd.h:2544:
< WARNING: please, no spaces at the start of a line
< #2544: FILE: /tmp/f1-351807/bgpd.h:2544:
< ERROR: code indent should use tabs where possible
< #2565: FILE: /tmp/f1-351807/bgpd.h:2565:
< WARNING: please, no spaces at the start of a line
< #2565: FILE: /tmp/f1-351807/bgpd.h:2565:
< ERROR: code indent should use tabs where possible
< #2566: FILE: /tmp/f1-351807/bgpd.h:2566:
< WARNING: please, no spaces at the start of a line
< #2566: FILE: /tmp/f1-351807/bgpd.h:2566:
Report for bgp_errors.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #456: FILE: /tmp/f1-351807/bgp_errors.c:456:
< WARNING: line over 80 characters
< #461: FILE: /tmp/f1-351807/bgp_errors.c:461:
< WARNING: line over 80 characters
< #462: FILE: /tmp/f1-351807/bgp_errors.c:462:
< WARNING: line over 80 characters
< #466: FILE: /tmp/f1-351807/bgp_errors.c:466:
Report for bgp_linkstate_tlv.c | 214 issues
===============================================
ERROR: that open brace { should be on the previous line
#40: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:40:
+	[BGP_LS_TLV_LINK_LOCAL_REMOTE_IDENTIFIERS] =
+		{"Link Local/Remote Identifiers", 2, 2, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:51:
+	[BGP_LS_TLV_IP_REACHABILITY_INFORMATION] =
+		{"IP Reachability Information", 2, 17, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#73: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:73:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_LOCAL_NODE] =
+		{"IPv4 Router-ID of Local Node", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#75: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:75:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_LOCAL_NODE] =
+		{"IPv6 Router-ID of Local Node", 16, 16, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#77: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:77:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_REMOTE_NODE] =
+		{"IPv4 Router-ID of Remote Node", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#79: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:79:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_REMOTE_NODE] =
+		{"IPv6 Router-ID of Remote Node", 16, 16, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#89: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:89:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION] =
+		{"Flexible Algorithm Definition", 4, MAX_SZ, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:91:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_ANY_AFFINITY] =
+		{"Flexible Algorithm Exclude Any Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#93: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:93:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ANY_AFFINITY] =
+		{"Flexible Algorithm Include Any Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#95: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:95:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ALL_AFFINITY] =
+		{"Flexible Algorithm Include All Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#97: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:97:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION_FLAGS] =
+		{"Flexible Algorithm Definition Flags", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#99: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:99:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_PREFIX_METRIC] =
+		{"Flexible Algorithm Prefix Metric", 8, 8, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#101: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:101:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_SRLG] =
+		{"Flexible Algorithm Exclude SRLG", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#107: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:107:
+	[BGP_LS_TLV_MAX_RESERVABLE_LINK_BANDWIDTH] =
+		{"Max. reservable link bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#133: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:133:
+	[BGP_LS_TLV_MIN_MAX_UNIDIRECTIONAL_LINK_DELAY] =
+		{"Min/Max Unidirectional Link Delay", 8, 8, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#135: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:135:
+	[BGP_LS_TLV_UNIDIRECTIONAL_DELAY_VARIATION] =
+		{"Unidirectional Delay Variation", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#139: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:139:
+	[BGP_LS_TLV_UNIDIRECTIONAL_RESIDUAL_BANDWIDTH] =
+		{"Unidirectional Residual Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#141: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:141:
+	[BGP_LS_TLV_UNIDIRECTIONAL_AVAILABLE_BANDWIDTH] =
+		{"Unidirectional Available Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#143: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:143:
+	[BGP_LS_TLV_UNIDIRECTIONAL_UTILIZED_BANDWIDTH] =
+		{"Unidirectional Utilized Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#147: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:147:
+	[BGP_LS_TLV_APPLICATION_SPECIFIC_LINK_ATTRIBUTES] =
+		{"Application-Specific Link Attributes", 11, MAX_SZ,

ERROR: that open brace { should be on the previous line
#166: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:166:
+	[BGP_LS_TLV_L2_BUNDLE_MEMBER_ATTRIBUTES] =
+		{"L2 Bundle Member Attributes", 4, MAX_SZ, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#168: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:168:
+	[BGP_LS_TLV_EXTENDED_ADMINISTRATIVE_GROUP] =
+		{"Extended Administrative Group", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#180: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:180:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_HEAD_END_ADDRESS_TLV] =
+		{"IPv4/6 Tunnel Head-end address TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#183: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:183:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_TAIL_END_ADDRESS_TLV] =
+		{"IPv4/6 Tunnel Tail-end address TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#186: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:186:
+	[BGP_LS_TLV_SR_POLICY_CP_DESCRIPTOR_TLV] =
+		{"SR Policy CP Descriptor TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#189: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:189:
+	[BGP_LS_TLV_MPLS_LOCAL_CROSS_CONNECT_TLV] =
+		{"MPLS Local Cross Connect TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#192: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:192:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_INTERFACE_TLV] =
+		{"MPLS Cross Connect Interface TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#201: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:201:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_UNSUPPORTED] =
+		{"Flexible Algorithm Unsupported", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#206: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:206:
+	[BGP_LS_TLV_IS_IS_SRV6_LAN_END_X_SID_TLV] =
+		{"IS-IS SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#209: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:209:
+	[BGP_LS_TLV_OSPFV3_SRV6_LAN_END_X_SID_TLV] =
+		{"OSPFv3 SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#233: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:233:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_METRIC_SUB_TLV] =
+		{"SR Segment List Metric sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#236: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:236:
+	[BGP_LS_TLV_SR_AFFINITY_CONSTRAINT_SUB_TLV] =
+		{"SR Affinity Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#242: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:242:
+	[BGP_LS_TLV_SR_BANDWIDTH_CONSTRAINT_SUB_TLV] =
+		{"SR Bandwidth Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#245: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:245:
+	[BGP_LS_TLV_SR_DISJOINT_GROUP_CONSTRAINT_SUB_TLV] =
+		{"SR Disjoint Group Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

WARNING: line over 80 characters
#734: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:734:
+		assert(!"bgp_linkstate_nlri_link_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_link_descriptor_decode', this function's name, in a string
#734: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:734:
+		assert(!"bgp_linkstate_nlri_link_descriptor_decode() must not be called for this TLV type!");

WARNING: line over 80 characters
#1072: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:1072:
+		assert(!"bgp_linkstate_nlri_prefix4_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_prefix4_descriptor_decode', this function's name, in a string
#1072: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:1072:
+		assert(!"bgp_linkstate_nlri_prefix4_descriptor_decode() must not be called for this TLV type!");

WARNING: Block comments use * on subsequent lines
#1094: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:1094:
+		/*
+		   The Type and Length fields of the TLV are defined in Table 6.

WARNING: line over 80 characters
#1353: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:1353:
+		assert(!"bgp_linkstate_nlri_prefix6_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_prefix6_descriptor_decode', this function's name, in a string
#1353: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:1353:
+		assert(!"bgp_linkstate_nlri_prefix6_descriptor_decode() must not be called for this TLV type!");

WARNING: Block comments use * on subsequent lines
#1375: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:1375:
+		/*
+		   The Type and Length fields of the TLV are defined in Table 6.

WARNING: Missing a blank line after declarations
#1767: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:1767:
+	json_object *json_type = json_object_new_object();
+	json_object_object_add(json, "linkStateNLRI", json_type);

WARNING: braces {} are not necessary for single statement blocks
#2348: FILE: /tmp/f1-351807/bgp_linkstate_tlv.c:2348:
+	if (json) {
+	}
Report for bgp_linkstate_tlv.h | 9 issues
===============================================
WARNING: Block comments use * on subsequent lines
#15: FILE: /tmp/f1-351807/bgp_linkstate_tlv.h:15:
+/* RFC7752 Link-State NLRI Protocol-ID values
+	+-------------+----------------------------------+

WARNING: line over 80 characters
#39: FILE: /tmp/f1-351807/bgp_linkstate_tlv.h:39:
+ * https://www.iana.org/assignments/bgp-ls-parameters/bgp-ls-parameters.xhtml#node-descriptor-link-descriptor-prefix-descriptor-attribute-tlv
Report for bgp_vty.c | 4 issues
===============================================
< ERROR: code indent should use tabs where possible
< #10288: FILE: /tmp/f1-351807/bgp_vty.c:10288:
< WARNING: please, no spaces at the start of a line
< #10288: FILE: /tmp/f1-351807/bgp_vty.c:10288:
Report for prefix.h | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #358: FILE: /tmp/f1-351807/prefix.h:358:

@louis-6wind louis-6wind force-pushed the bgp-link-state-attr branch from 3c3605b to c5f3e36 Compare April 17, 2023 10:07
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 17, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10925/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10925/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10925/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10925/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_list_display:
bgpd/bgp_linkstate_tlv.c:1988:23: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
 1988 |    vty_out(vty, "%s%llu", i == 0 ? "" : ", ",
 1989 |     pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_display:
bgpd/bgp_linkstate_tlv.c:2034:20: error: format %llu expects argument of type long long unsigned int, but argument 3 has type uint64_t {aka long unsigned int} [-Werror=format=]
 2034 |   vty_out(vty, "%llu\n", pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10925/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 arm7 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm7 build
  • Redhat 9 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 16.04 arm8 build
  • Redhat 8 amd64 build
  • Ubuntu 18.04 i386 build
  • OpenBSD 7 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 22.04 amd64 build
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10925/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10925/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10925/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_list_display:
bgpd/bgp_linkstate_tlv.c:1988:23: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
 1988 |    vty_out(vty, "%s%llu", i == 0 ? "" : ", ",
 1989 |     pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_integer_display:
bgpd/bgp_linkstate_tlv.c:2034:20: error: format %llu expects argument of type long long unsigned int, but argument 3 has type uint64_t {aka long unsigned int} [-Werror=format=]
 2034 |   vty_out(vty, "%llu\n", pnt_decode64(&pnt));
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10925/artifact/DEB11AMD64/config.status/config.status

<stdin>:5087: new blank line at EOF.
+
<stdin>:7126: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for bgpd.c | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #4326: FILE: /tmp/f1-252286/bgpd.c:4326:
< WARNING: please, no spaces at the start of a line
< #4326: FILE: /tmp/f1-252286/bgpd.c:4326:
< ERROR: code indent should use tabs where possible
< #4327: FILE: /tmp/f1-252286/bgpd.c:4327:
< WARNING: please, no spaces at the start of a line
< #4327: FILE: /tmp/f1-252286/bgpd.c:4327:
< ERROR: code indent should use tabs where possible
< #4348: FILE: /tmp/f1-252286/bgpd.c:4348:
< WARNING: please, no spaces at the start of a line
< #4348: FILE: /tmp/f1-252286/bgpd.c:4348:
< ERROR: code indent should use tabs where possible
< #4349: FILE: /tmp/f1-252286/bgpd.c:4349:
< WARNING: please, no spaces at the start of a line
< #4349: FILE: /tmp/f1-252286/bgpd.c:4349:
Report for bgpd.h | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #2543: FILE: /tmp/f1-252286/bgpd.h:2543:
< WARNING: please, no spaces at the start of a line
< #2543: FILE: /tmp/f1-252286/bgpd.h:2543:
< ERROR: code indent should use tabs where possible
< #2544: FILE: /tmp/f1-252286/bgpd.h:2544:
< WARNING: please, no spaces at the start of a line
< #2544: FILE: /tmp/f1-252286/bgpd.h:2544:
< ERROR: code indent should use tabs where possible
< #2565: FILE: /tmp/f1-252286/bgpd.h:2565:
< WARNING: please, no spaces at the start of a line
< #2565: FILE: /tmp/f1-252286/bgpd.h:2565:
< ERROR: code indent should use tabs where possible
< #2566: FILE: /tmp/f1-252286/bgpd.h:2566:
< WARNING: please, no spaces at the start of a line
< #2566: FILE: /tmp/f1-252286/bgpd.h:2566:
Report for bgp_errors.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #456: FILE: /tmp/f1-252286/bgp_errors.c:456:
< WARNING: line over 80 characters
< #461: FILE: /tmp/f1-252286/bgp_errors.c:461:
< WARNING: line over 80 characters
< #462: FILE: /tmp/f1-252286/bgp_errors.c:462:
< WARNING: line over 80 characters
< #466: FILE: /tmp/f1-252286/bgp_errors.c:466:
Report for bgp_linkstate_tlv.c | 214 issues
===============================================
ERROR: that open brace { should be on the previous line
#40: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:40:
+	[BGP_LS_TLV_LINK_LOCAL_REMOTE_IDENTIFIERS] =
+		{"Link Local/Remote Identifiers", 2, 2, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:51:
+	[BGP_LS_TLV_IP_REACHABILITY_INFORMATION] =
+		{"IP Reachability Information", 2, 17, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#73: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:73:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_LOCAL_NODE] =
+		{"IPv4 Router-ID of Local Node", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#75: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:75:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_LOCAL_NODE] =
+		{"IPv6 Router-ID of Local Node", 16, 16, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#77: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:77:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_REMOTE_NODE] =
+		{"IPv4 Router-ID of Remote Node", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#79: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:79:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_REMOTE_NODE] =
+		{"IPv6 Router-ID of Remote Node", 16, 16, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#89: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:89:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION] =
+		{"Flexible Algorithm Definition", 4, MAX_SZ, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:91:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_ANY_AFFINITY] =
+		{"Flexible Algorithm Exclude Any Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#93: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:93:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ANY_AFFINITY] =
+		{"Flexible Algorithm Include Any Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#95: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:95:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ALL_AFFINITY] =
+		{"Flexible Algorithm Include All Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#97: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:97:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION_FLAGS] =
+		{"Flexible Algorithm Definition Flags", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#99: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:99:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_PREFIX_METRIC] =
+		{"Flexible Algorithm Prefix Metric", 8, 8, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#101: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:101:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_SRLG] =
+		{"Flexible Algorithm Exclude SRLG", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#107: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:107:
+	[BGP_LS_TLV_MAX_RESERVABLE_LINK_BANDWIDTH] =
+		{"Max. reservable link bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#133: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:133:
+	[BGP_LS_TLV_MIN_MAX_UNIDIRECTIONAL_LINK_DELAY] =
+		{"Min/Max Unidirectional Link Delay", 8, 8, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#135: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:135:
+	[BGP_LS_TLV_UNIDIRECTIONAL_DELAY_VARIATION] =
+		{"Unidirectional Delay Variation", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#139: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:139:
+	[BGP_LS_TLV_UNIDIRECTIONAL_RESIDUAL_BANDWIDTH] =
+		{"Unidirectional Residual Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#141: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:141:
+	[BGP_LS_TLV_UNIDIRECTIONAL_AVAILABLE_BANDWIDTH] =
+		{"Unidirectional Available Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#143: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:143:
+	[BGP_LS_TLV_UNIDIRECTIONAL_UTILIZED_BANDWIDTH] =
+		{"Unidirectional Utilized Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#147: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:147:
+	[BGP_LS_TLV_APPLICATION_SPECIFIC_LINK_ATTRIBUTES] =
+		{"Application-Specific Link Attributes", 11, MAX_SZ,

ERROR: that open brace { should be on the previous line
#166: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:166:
+	[BGP_LS_TLV_L2_BUNDLE_MEMBER_ATTRIBUTES] =
+		{"L2 Bundle Member Attributes", 4, MAX_SZ, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#168: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:168:
+	[BGP_LS_TLV_EXTENDED_ADMINISTRATIVE_GROUP] =
+		{"Extended Administrative Group", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#180: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:180:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_HEAD_END_ADDRESS_TLV] =
+		{"IPv4/6 Tunnel Head-end address TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#183: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:183:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_TAIL_END_ADDRESS_TLV] =
+		{"IPv4/6 Tunnel Tail-end address TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#186: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:186:
+	[BGP_LS_TLV_SR_POLICY_CP_DESCRIPTOR_TLV] =
+		{"SR Policy CP Descriptor TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#189: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:189:
+	[BGP_LS_TLV_MPLS_LOCAL_CROSS_CONNECT_TLV] =
+		{"MPLS Local Cross Connect TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#192: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:192:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_INTERFACE_TLV] =
+		{"MPLS Cross Connect Interface TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#201: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:201:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_UNSUPPORTED] =
+		{"Flexible Algorithm Unsupported", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#206: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:206:
+	[BGP_LS_TLV_IS_IS_SRV6_LAN_END_X_SID_TLV] =
+		{"IS-IS SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#209: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:209:
+	[BGP_LS_TLV_OSPFV3_SRV6_LAN_END_X_SID_TLV] =
+		{"OSPFv3 SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#233: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:233:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_METRIC_SUB_TLV] =
+		{"SR Segment List Metric sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#236: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:236:
+	[BGP_LS_TLV_SR_AFFINITY_CONSTRAINT_SUB_TLV] =
+		{"SR Affinity Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#242: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:242:
+	[BGP_LS_TLV_SR_BANDWIDTH_CONSTRAINT_SUB_TLV] =
+		{"SR Bandwidth Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#245: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:245:
+	[BGP_LS_TLV_SR_DISJOINT_GROUP_CONSTRAINT_SUB_TLV] =
+		{"SR Disjoint Group Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

WARNING: line over 80 characters
#734: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:734:
+		assert(!"bgp_linkstate_nlri_link_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_link_descriptor_decode', this function's name, in a string
#734: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:734:
+		assert(!"bgp_linkstate_nlri_link_descriptor_decode() must not be called for this TLV type!");

WARNING: line over 80 characters
#1072: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:1072:
+		assert(!"bgp_linkstate_nlri_prefix4_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_prefix4_descriptor_decode', this function's name, in a string
#1072: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:1072:
+		assert(!"bgp_linkstate_nlri_prefix4_descriptor_decode() must not be called for this TLV type!");

WARNING: Block comments use * on subsequent lines
#1094: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:1094:
+		/*
+		   The Type and Length fields of the TLV are defined in Table 6.

WARNING: line over 80 characters
#1353: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:1353:
+		assert(!"bgp_linkstate_nlri_prefix6_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_prefix6_descriptor_decode', this function's name, in a string
#1353: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:1353:
+		assert(!"bgp_linkstate_nlri_prefix6_descriptor_decode() must not be called for this TLV type!");

WARNING: Block comments use * on subsequent lines
#1375: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:1375:
+		/*
+		   The Type and Length fields of the TLV are defined in Table 6.

WARNING: Missing a blank line after declarations
#1767: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:1767:
+	json_object *json_type = json_object_new_object();
+	json_object_object_add(json, "linkStateNLRI", json_type);

WARNING: braces {} are not necessary for single statement blocks
#2348: FILE: /tmp/f1-252286/bgp_linkstate_tlv.c:2348:
+	if (json) {
+	}
Report for bgp_linkstate_tlv.h | 9 issues
===============================================
WARNING: Block comments use * on subsequent lines
#15: FILE: /tmp/f1-252286/bgp_linkstate_tlv.h:15:
+/* RFC7752 Link-State NLRI Protocol-ID values
+	+-------------+----------------------------------+

WARNING: line over 80 characters
#39: FILE: /tmp/f1-252286/bgp_linkstate_tlv.h:39:
+ * https://www.iana.org/assignments/bgp-ls-parameters/bgp-ls-parameters.xhtml#node-descriptor-link-descriptor-prefix-descriptor-attribute-tlv
Report for bgp_vty.c | 4 issues
===============================================
< ERROR: code indent should use tabs where possible
< #10288: FILE: /tmp/f1-252286/bgp_vty.c:10288:
< WARNING: please, no spaces at the start of a line
< #10288: FILE: /tmp/f1-252286/bgp_vty.c:10288:
Report for prefix.h | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #358: FILE: /tmp/f1-252286/prefix.h:358:

@louis-6wind louis-6wind force-pushed the bgp-link-state-attr branch from c5f3e36 to 5aab870 Compare April 17, 2023 11:06
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 17, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10926/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10926/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10926/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10926/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:
bgpd/bgp_linkstate_tlv.c:2046:46: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 4 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 2046 |    json_object_string_addf(json, "data", "%pI4", pnt);
bgpd/bgp_linkstate_tlv.c:2049:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 2049 |   vty_out(vty, "%pI4\n", pnt);
bgpd/bgp_linkstate_tlv.c:2052:46: error: format %pI6 expects argument of type struct in6_addr *, but argument 4 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 2052 |    json_object_string_addf(json, "data", "%pI6", pnt);
bgpd/bgp_linkstate_tlv.c:2055:20: error: format %pI6 expects argument of type struct in6_addr *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10926/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Ubuntu 16.04 arm7 build
  • Ubuntu 18.04 arm7 build
  • FreeBSD 11 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 16.04 amd64 build
  • OpenBSD 7 amd64 build
  • FreeBSD 12 amd64 build
  • Redhat 8 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 22.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 18.04 ppc64le build
  • Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10926/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10926/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10926/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:
bgpd/bgp_linkstate_tlv.c:2046:46: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 4 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 2046 |    json_object_string_addf(json, "data", "%pI4", pnt);
bgpd/bgp_linkstate_tlv.c:2049:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 2049 |   vty_out(vty, "%pI4\n", pnt);
bgpd/bgp_linkstate_tlv.c:2052:46: error: format %pI6 expects argument of type struct in6_addr *, but argument 4 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 2052 |    json_object_string_addf(json, "data", "%pI6", pnt);
bgpd/bgp_linkstate_tlv.c:2055:20: error: format %pI6 expects argument of type struct in6_addr *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10926/artifact/DEB11AMD64/config.status/config.status

<stdin>:5087: new blank line at EOF.
+
<stdin>:7126: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for bgpd.c | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #4326: FILE: /tmp/f1-676706/bgpd.c:4326:
< WARNING: please, no spaces at the start of a line
< #4326: FILE: /tmp/f1-676706/bgpd.c:4326:
< ERROR: code indent should use tabs where possible
< #4327: FILE: /tmp/f1-676706/bgpd.c:4327:
< WARNING: please, no spaces at the start of a line
< #4327: FILE: /tmp/f1-676706/bgpd.c:4327:
< ERROR: code indent should use tabs where possible
< #4348: FILE: /tmp/f1-676706/bgpd.c:4348:
< WARNING: please, no spaces at the start of a line
< #4348: FILE: /tmp/f1-676706/bgpd.c:4348:
< ERROR: code indent should use tabs where possible
< #4349: FILE: /tmp/f1-676706/bgpd.c:4349:
< WARNING: please, no spaces at the start of a line
< #4349: FILE: /tmp/f1-676706/bgpd.c:4349:
Report for bgpd.h | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #2543: FILE: /tmp/f1-676706/bgpd.h:2543:
< WARNING: please, no spaces at the start of a line
< #2543: FILE: /tmp/f1-676706/bgpd.h:2543:
< ERROR: code indent should use tabs where possible
< #2544: FILE: /tmp/f1-676706/bgpd.h:2544:
< WARNING: please, no spaces at the start of a line
< #2544: FILE: /tmp/f1-676706/bgpd.h:2544:
< ERROR: code indent should use tabs where possible
< #2565: FILE: /tmp/f1-676706/bgpd.h:2565:
< WARNING: please, no spaces at the start of a line
< #2565: FILE: /tmp/f1-676706/bgpd.h:2565:
< ERROR: code indent should use tabs where possible
< #2566: FILE: /tmp/f1-676706/bgpd.h:2566:
< WARNING: please, no spaces at the start of a line
< #2566: FILE: /tmp/f1-676706/bgpd.h:2566:
Report for bgp_errors.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #456: FILE: /tmp/f1-676706/bgp_errors.c:456:
< WARNING: line over 80 characters
< #461: FILE: /tmp/f1-676706/bgp_errors.c:461:
< WARNING: line over 80 characters
< #462: FILE: /tmp/f1-676706/bgp_errors.c:462:
< WARNING: line over 80 characters
< #466: FILE: /tmp/f1-676706/bgp_errors.c:466:
Report for bgp_linkstate_tlv.c | 214 issues
===============================================
ERROR: that open brace { should be on the previous line
#40: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:40:
+	[BGP_LS_TLV_LINK_LOCAL_REMOTE_IDENTIFIERS] =
+		{"Link Local/Remote Identifiers", 2, 2, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:51:
+	[BGP_LS_TLV_IP_REACHABILITY_INFORMATION] =
+		{"IP Reachability Information", 2, 17, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#73: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:73:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_LOCAL_NODE] =
+		{"IPv4 Router-ID of Local Node", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#75: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:75:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_LOCAL_NODE] =
+		{"IPv6 Router-ID of Local Node", 16, 16, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#77: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:77:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_REMOTE_NODE] =
+		{"IPv4 Router-ID of Remote Node", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#79: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:79:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_REMOTE_NODE] =
+		{"IPv6 Router-ID of Remote Node", 16, 16, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#89: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:89:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION] =
+		{"Flexible Algorithm Definition", 4, MAX_SZ, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:91:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_ANY_AFFINITY] =
+		{"Flexible Algorithm Exclude Any Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#93: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:93:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ANY_AFFINITY] =
+		{"Flexible Algorithm Include Any Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#95: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:95:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ALL_AFFINITY] =
+		{"Flexible Algorithm Include All Affinity", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#97: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:97:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION_FLAGS] =
+		{"Flexible Algorithm Definition Flags", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#99: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:99:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_PREFIX_METRIC] =
+		{"Flexible Algorithm Prefix Metric", 8, 8, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#101: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:101:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_SRLG] =
+		{"Flexible Algorithm Exclude SRLG", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#107: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:107:
+	[BGP_LS_TLV_MAX_RESERVABLE_LINK_BANDWIDTH] =
+		{"Max. reservable link bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#133: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:133:
+	[BGP_LS_TLV_MIN_MAX_UNIDIRECTIONAL_LINK_DELAY] =
+		{"Min/Max Unidirectional Link Delay", 8, 8, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#135: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:135:
+	[BGP_LS_TLV_UNIDIRECTIONAL_DELAY_VARIATION] =
+		{"Unidirectional Delay Variation", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#139: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:139:
+	[BGP_LS_TLV_UNIDIRECTIONAL_RESIDUAL_BANDWIDTH] =
+		{"Unidirectional Residual Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#141: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:141:
+	[BGP_LS_TLV_UNIDIRECTIONAL_AVAILABLE_BANDWIDTH] =
+		{"Unidirectional Available Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#143: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:143:
+	[BGP_LS_TLV_UNIDIRECTIONAL_UTILIZED_BANDWIDTH] =
+		{"Unidirectional Utilized Bandwidth", 4, 4, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#147: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:147:
+	[BGP_LS_TLV_APPLICATION_SPECIFIC_LINK_ATTRIBUTES] =
+		{"Application-Specific Link Attributes", 11, MAX_SZ,

ERROR: that open brace { should be on the previous line
#166: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:166:
+	[BGP_LS_TLV_L2_BUNDLE_MEMBER_ATTRIBUTES] =
+		{"L2 Bundle Member Attributes", 4, MAX_SZ, UNDEF_MULTPL},

ERROR: that open brace { should be on the previous line
#168: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:168:
+	[BGP_LS_TLV_EXTENDED_ADMINISTRATIVE_GROUP] =
+		{"Extended Administrative Group", 4, MAX_SZ, 4},

ERROR: that open brace { should be on the previous line
#180: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:180:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_HEAD_END_ADDRESS_TLV] =
+		{"IPv4/6 Tunnel Head-end address TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#183: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:183:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_TAIL_END_ADDRESS_TLV] =
+		{"IPv4/6 Tunnel Tail-end address TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#186: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:186:
+	[BGP_LS_TLV_SR_POLICY_CP_DESCRIPTOR_TLV] =
+		{"SR Policy CP Descriptor TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#189: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:189:
+	[BGP_LS_TLV_MPLS_LOCAL_CROSS_CONNECT_TLV] =
+		{"MPLS Local Cross Connect TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#192: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:192:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_INTERFACE_TLV] =
+		{"MPLS Cross Connect Interface TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#201: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:201:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_UNSUPPORTED] =
+		{"Flexible Algorithm Unsupported", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#206: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:206:
+	[BGP_LS_TLV_IS_IS_SRV6_LAN_END_X_SID_TLV] =
+		{"IS-IS SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#209: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:209:
+	[BGP_LS_TLV_OSPFV3_SRV6_LAN_END_X_SID_TLV] =
+		{"OSPFv3 SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#233: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:233:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_METRIC_SUB_TLV] =
+		{"SR Segment List Metric sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#236: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:236:
+	[BGP_LS_TLV_SR_AFFINITY_CONSTRAINT_SUB_TLV] =
+		{"SR Affinity Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#242: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:242:
+	[BGP_LS_TLV_SR_BANDWIDTH_CONSTRAINT_SUB_TLV] =
+		{"SR Bandwidth Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

ERROR: that open brace { should be on the previous line
#245: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:245:
+	[BGP_LS_TLV_SR_DISJOINT_GROUP_CONSTRAINT_SUB_TLV] =
+		{"SR Disjoint Group Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ,

WARNING: line over 80 characters
#734: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:734:
+		assert(!"bgp_linkstate_nlri_link_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_link_descriptor_decode', this function's name, in a string
#734: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:734:
+		assert(!"bgp_linkstate_nlri_link_descriptor_decode() must not be called for this TLV type!");

WARNING: line over 80 characters
#1072: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:1072:
+		assert(!"bgp_linkstate_nlri_prefix4_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_prefix4_descriptor_decode', this function's name, in a string
#1072: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:1072:
+		assert(!"bgp_linkstate_nlri_prefix4_descriptor_decode() must not be called for this TLV type!");

WARNING: Block comments use * on subsequent lines
#1094: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:1094:
+		/*
+		   The Type and Length fields of the TLV are defined in Table 6.

WARNING: line over 80 characters
#1353: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:1353:
+		assert(!"bgp_linkstate_nlri_prefix6_descriptor_decode() must not be called for this TLV type!");

WARNING: Prefer using '"%s...", __func__' to using 'bgp_linkstate_nlri_prefix6_descriptor_decode', this function's name, in a string
#1353: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:1353:
+		assert(!"bgp_linkstate_nlri_prefix6_descriptor_decode() must not be called for this TLV type!");

WARNING: Block comments use * on subsequent lines
#1375: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:1375:
+		/*
+		   The Type and Length fields of the TLV are defined in Table 6.

WARNING: Missing a blank line after declarations
#1767: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:1767:
+	json_object *json_type = json_object_new_object();
+	json_object_object_add(json, "linkStateNLRI", json_type);

WARNING: braces {} are not necessary for single statement blocks
#2348: FILE: /tmp/f1-676706/bgp_linkstate_tlv.c:2348:
+	if (json) {
+	}
Report for bgp_linkstate_tlv.h | 9 issues
===============================================
WARNING: Block comments use * on subsequent lines
#15: FILE: /tmp/f1-676706/bgp_linkstate_tlv.h:15:
+/* RFC7752 Link-State NLRI Protocol-ID values
+	+-------------+----------------------------------+

WARNING: line over 80 characters
#39: FILE: /tmp/f1-676706/bgp_linkstate_tlv.h:39:
+ * https://www.iana.org/assignments/bgp-ls-parameters/bgp-ls-parameters.xhtml#node-descriptor-link-descriptor-prefix-descriptor-attribute-tlv
Report for bgp_vty.c | 4 issues
===============================================
< ERROR: code indent should use tabs where possible
< #10288: FILE: /tmp/f1-676706/bgp_vty.c:10288:
< WARNING: please, no spaces at the start of a line
< #10288: FILE: /tmp/f1-676706/bgp_vty.c:10288:
Report for prefix.h | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #358: FILE: /tmp/f1-676706/prefix.h:358:

@louis-6wind louis-6wind force-pushed the bgp-link-state-attr branch from 5aab870 to 2373675 Compare April 17, 2023 15:05
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 17, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10929/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10929/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10929/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10929/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_nlri_node_descriptor_display:
bgpd/bgp_linkstate_tlv.c:408:36: error: format %pSY expects argument of type uint8_t {aka unsigned char} *, but argument 5 has type uint64_t * {aka long unsigned int *} [-Werror=format=]
bgpd/bgp_linkstate_tlv.c:412:36: error: format %pPN expects argument of type uint8_t {aka unsigned char} *, but argument 5 has type uint64_t * {aka long unsigned int *} [-Werror=format=]
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:
bgpd/bgp_linkstate_tlv.c:1940:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 1940 |   vty_out(vty, "%pI4\n", pnt);
bgpd/bgp_linkstate_tlv.c:1947:20: error: format %pI6 expects argument of type struct in6_addr *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 1947 |   vty_out(vty, "%pI6\n", pnt);

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10929/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Ubuntu 18.04 i386 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 16.04 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm8 build
  • Redhat 8 amd64 build
  • OpenBSD 7 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Redhat 9 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 arm7 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10929/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10929/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10929/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_nlri_node_descriptor_display:
bgpd/bgp_linkstate_tlv.c:408:36: error: format %pSY expects argument of type uint8_t {aka unsigned char} *, but argument 5 has type uint64_t * {aka long unsigned int *} [-Werror=format=]
bgpd/bgp_linkstate_tlv.c:412:36: error: format %pPN expects argument of type uint8_t {aka unsigned char} *, but argument 5 has type uint64_t * {aka long unsigned int *} [-Werror=format=]
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:
bgpd/bgp_linkstate_tlv.c:1940:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 1940 |   vty_out(vty, "%pI4\n", pnt);
bgpd/bgp_linkstate_tlv.c:1947:20: error: format %pI6 expects argument of type struct in6_addr *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 1947 |   vty_out(vty, "%pI6\n", pnt);

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10929/artifact/DEB11AMD64/config.status/config.status

<stdin>:5015: new blank line at EOF.
+
<stdin>:7054: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for bgp_errors.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #456: FILE: /tmp/f1-1859570/bgp_errors.c:456:
< WARNING: line over 80 characters
< #461: FILE: /tmp/f1-1859570/bgp_errors.c:461:
< WARNING: line over 80 characters
< #462: FILE: /tmp/f1-1859570/bgp_errors.c:462:
< WARNING: line over 80 characters
< #466: FILE: /tmp/f1-1859570/bgp_errors.c:466:
Report for bgp_linkstate_tlv.c | 96 issues
===============================================
WARNING: line over 80 characters
#36: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:36:
+	[BGP_LS_TLV_LOCAL_NODE_DESCRIPTORS] = {"Local Node Descriptors", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#37: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:37:
+	[BGP_LS_TLV_REMOTE_NODE_DESCRIPTORS] = {"Remote Node Descriptors", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#38: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:38:
+	[BGP_LS_TLV_LINK_LOCAL_REMOTE_IDENTIFIERS] = {"Link Local/Remote Identifiers", 2, 2, UNDEF_MULTPL},

WARNING: line over 80 characters
#39: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:39:
+	[BGP_LS_TLV_IPV4_INTERFACE_ADDRESS] = {"IPv4 interface address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#40: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:40:
+	[BGP_LS_TLV_IPV4_NEIGHBOR_ADDRESS] = {"IPv4 neighbor address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#41: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:41:
+	[BGP_LS_TLV_IPV6_INTERFACE_ADDRESS] = {"IPv6 interface address", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#42: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:42:
+	[BGP_LS_TLV_IPV6_NEIGHBOR_ADDRESS] = {"IPv6 neighbor address", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#44: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:44:
+	[BGP_LS_TLV_IP_REACHABILITY_INFORMATION] = {"IP Reachability Information", 2, 17, UNDEF_MULTPL},

WARNING: line over 80 characters
#45: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:45:
+	[BGP_LS_TLV_AUTONOMOUS_SYSTEM] = {"Autonomous System", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#46: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:46:
+	[BGP_LS_TLV_BGP_LS_IDENTIFIER] = {"BGP-LS Identifier", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#55: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:55:
+	[BGP_LS_TLV_BGP_CONFEDERATION_MEMBER] = {"BGP Confederation Member", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#57: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:57:
+	[BGP_LS_TLV_OPAQUE_NODE_ATTRIBUTE] = {"Opaque Node Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#59: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:59:
+	[BGP_LS_TLV_IS_IS_AREA_IDENTIFIER] = {"IS-IS Area Identifier", 1, 13, UNDEF_MULTPL},

WARNING: line over 80 characters
#60: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:60:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_LOCAL_NODE] =	{"IPv4 Router-ID of Local Node", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#61: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:61:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_LOCAL_NODE] = {"IPv6 Router-ID of Local Node", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#62: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:62:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_REMOTE_NODE] = {"IPv4 Router-ID of Remote Node", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#63: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:63:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_REMOTE_NODE] = {"IPv6 Router-ID of Remote Node", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#64: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:64:
+	[BGP_LS_TLV_S_BFD_DISCRIMINATORS] = {"S-BFD Discriminators", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#65: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:65:
+	[BGP_LS_TLV_SR_CAPABILITIES] = {"SR Capabilities", 12, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#67: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:67:
+	[BGP_LS_TLV_SR_LOCAL_BLOCK] = {"SR Local Block", 12, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#69: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:69:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION] = {"Flexible Algorithm Definition", 4, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#70: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:70:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_ANY_AFFINITY] = {"Flexible Algorithm Exclude Any Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#71: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:71:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ANY_AFFINITY] = {"Flexible Algorithm Include Any Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#72: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:72:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ALL_AFFINITY] = {"Flexible Algorithm Include All Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#73: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:73:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION_FLAGS] = {"Flexible Algorithm Definition Flags", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#74: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:74:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_PREFIX_METRIC] = {"Flexible Algorithm Prefix Metric", 8, 8, UNDEF_MULTPL},

WARNING: line over 80 characters
#75: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:75:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_SRLG] = {"Flexible Algorithm Exclude SRLG", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#76: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:76:
+	[BGP_LS_TLV_ADMINISTRATIVE_GROUP] = {"Administrative group", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#77: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:77:
+	[BGP_LS_TLV_MAXIMUM_LINK_BANDWIDTH] = {"Maximum link bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#78: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:78:
+	[BGP_LS_TLV_MAX_RESERVABLE_LINK_BANDWIDTH] = {"Max. reservable link bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#79: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:79:
+	[BGP_LS_TLV_UNRESERVED_BANDWIDTH] = {"Unreserved bandwidth", 32, 32, UNDEF_MULTPL},

WARNING: line over 80 characters
#80: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:80:
+	[BGP_LS_TLV_TE_DEFAULT_METRIC] = {"TE Default Metric", 3, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#81: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:81:
+	[BGP_LS_TLV_LINK_PROTECTION_TYPE] = {"Link Protection Type", 2, 2, UNDEF_MULTPL},

WARNING: line over 80 characters
#82: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:82:
+	[BGP_LS_TLV_MPLS_PROTOCOL_MASK] = {"MPLS Protocol Mask", 1, 1, UNDEF_MULTPL},

WARNING: line over 80 characters
#84: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:84:
+	[BGP_LS_TLV_SHARED_RISK_LINK_GROUP] = {"Shared Risk Link Group", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#85: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:85:
+	[BGP_LS_TLV_OPAQUE_LINK_ATTRIBUTE] = {"Opaque Link Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#88: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:88:
+	[BGP_LS_TLV_LAN_ADJACENCY_SID] = {"LAN Adjacency SID", 11, 14, UNDEF_MULTPL},

WARNING: line over 80 characters
#92: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:92:
+	[BGP_LS_TLV_RTM_CAPABILITY] = {"RTM Capability", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#93: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:93:
+	[BGP_LS_TLV_UNIDIRECTIONAL_LINK_DELAY] = {"Unidirectional Link Delay", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#94: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:94:
+	[BGP_LS_TLV_MIN_MAX_UNIDIRECTIONAL_LINK_DELAY] = {"Min/Max Unidirectional Link Delay", 8, 8, UNDEF_MULTPL},

WARNING: line over 80 characters
#95: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:95:
+	[BGP_LS_TLV_UNIDIRECTIONAL_DELAY_VARIATION] = {"Unidirectional Delay Variation", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#96: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:96:
+	[BGP_LS_TLV_UNIDIRECTIONAL_LINK_LOSS] = {"Unidirectional Link Loss", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#97: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:97:
+	[BGP_LS_TLV_UNIDIRECTIONAL_RESIDUAL_BANDWIDTH] = {"Unidirectional Residual Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#98: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:98:
+	[BGP_LS_TLV_UNIDIRECTIONAL_AVAILABLE_BANDWIDTH] = {"Unidirectional Available Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#99: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:99:
+	[BGP_LS_TLV_UNIDIRECTIONAL_UTILIZED_BANDWIDTH] = {"Unidirectional Utilized Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#100: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:100:
+	[BGP_LS_TLV_GRACEFUL_LINK_SHUTDOWN_TLV] = {"Graceful-Link-Shutdown TLV", 0, 0, UNDEF_MULTPL},

WARNING: line over 80 characters
#101: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:101:
+	[BGP_LS_TLV_APPLICATION_SPECIFIC_LINK_ATTRIBUTES] = {"Application-Specific Link Attributes", 11, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#104: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:104:
+	[BGP_LS_TLV_IGP_EXTENDED_ROUTE_TAG] = {"IGP Extended Route Tag", 8, MAX_SZ, 8},

WARNING: line over 80 characters
#106: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:106:
+	[BGP_LS_TLV_OSPF_FORWARDING_ADDRESS] = {"OSPF Forwarding Address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#107: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:107:
+	[BGP_LS_TLV_OPAQUE_PREFIX_ATTRIBUTE] = {"Opaque Prefix Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#111: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:111:
+	[BGP_LS_TLV_PREFIX_ATTRIBUTES_FLAGS] = {"Prefix Attributes Flags", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#112: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:112:
+	[BGP_LS_TLV_SOURCE_ROUTER_IDENTIFIER] = {"Source Router Identifier", 4, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#113: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:113:
+	[BGP_LS_TLV_L2_BUNDLE_MEMBER_ATTRIBUTES] = {"L2 Bundle Member Attributes", 4, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#114: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:114:
+	[BGP_LS_TLV_EXTENDED_ADMINISTRATIVE_GROUP] = {"Extended Administrative Group", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#115: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:115:
+	[BGP_LS_TLV_SOURCE_OSPF_ROUTER_ID] = {"Source OSPF Router-ID", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#117: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:117:
+	[BGP_LS_TLV_SRV6_SID_INFORMATION_TLV] = {"SRv6 SID Information TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#118: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:118:
+	[BGP_LS_TLV_TUNNEL_ID_TLV] = {"Tunnel ID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#119: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:119:
+	[BGP_LS_TLV_LSP_ID_TLV] = {"LSP ID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#120: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:120:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_HEAD_END_ADDRESS_TLV] = {"IPv4/6 Tunnel Head-end address TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#121: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:121:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_TAIL_END_ADDRESS_TLV] = {"IPv4/6 Tunnel Tail-end address TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#122: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:122:
+	[BGP_LS_TLV_SR_POLICY_CP_DESCRIPTOR_TLV] = {"SR Policy CP Descriptor TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#123: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:123:
+	[BGP_LS_TLV_MPLS_LOCAL_CROSS_CONNECT_TLV] = {"MPLS Local Cross Connect TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#124: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:124:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_INTERFACE_TLV] = {"MPLS Cross Connect Interface TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#125: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:125:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_FEC_TLV] = {"MPLS Cross Connect FEC TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#126: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:126:
+	[BGP_LS_TLV_SRV6_CAPABILITIES_TLV] = {"SRv6 Capabilities TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#127: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:127:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_UNSUPPORTED] = {"Flexible Algorithm Unsupported", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#128: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:128:
+	[BGP_LS_TLV_SRV6_END_X_SID_TLV] = {"SRv6 End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#129: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:129:
+	[BGP_LS_TLV_IS_IS_SRV6_LAN_END_X_SID_TLV] = {"IS-IS SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#130: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:130:
+	[BGP_LS_TLV_OSPFV3_SRV6_LAN_END_X_SID_TLV] = {"OSPFv3 SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#131: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:131:
+	[BGP_LS_TLV_IS_IS_FLOOD_REFLECTION] = {"IS-IS Flood Reflection", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#132: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:132:
+	[BGP_LS_TLV_SRV6_LOCATOR_TLV] = {"SRv6 Locator TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#133: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:133:
+	[BGP_LS_TLV_MPLS_TE_POLICY_STATE_TLV] = {"MPLS-TE Policy State TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#134: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:134:
+	[BGP_LS_TLV_SR_BSID_TLV] = {"SR BSID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#135: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:135:
+	[BGP_LS_TLV_SR_CP_STATE_TLV] = {"SR CP State TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#136: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:136:
+	[BGP_LS_TLV_SR_CP_NAME_TLV] = {"SR CP Name TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#137: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:137:
+	[BGP_LS_TLV_SR_CP_CONSTRAINTS_TLV] = {"SR CP Constraints TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#138: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:138:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_TLV] = {"SR Segment List TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#139: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:139:
+	[BGP_LS_TLV_SR_SEGMENT_SUB_TLV] = {"SR Segment sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#140: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:140:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_METRIC_SUB_TLV] = {"SR Segment List Metric sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#141: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:141:
+	[BGP_LS_TLV_SR_AFFINITY_CONSTRAINT_SUB_TLV] = {"SR Affinity Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#142: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:142:
+	[BGP_LS_TLV_SR_SRLG_CONSTRAINT_SUB_TLV] = {"SR SRLG Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#143: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:143:
+	[BGP_LS_TLV_SR_BANDWIDTH_CONSTRAINT_SUB_TLV] = {"SR Bandwidth Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#144: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:144:
+	[BGP_LS_TLV_SR_DISJOINT_GROUP_CONSTRAINT_SUB_TLV] = {"SR Disjoint Group Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#145: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:145:
+	[BGP_LS_TLV_SRV6_BSID_TLV] = {"SRv6 BSID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#146: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:146:
+	[BGP_LS_TLV_SR_POLICY_NAME_TLV] = {"SR Policy Name TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#147: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:147:
+	[BGP_LS_TLV_SRV6_ENDPOINT_FUNCTION_TLV] = {"SRv6 Endpoint Function TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#148: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:148:
+	[BGP_LS_TLV_SRV6_BGP_PEER_NODE_SID_TLV] = {"SRv6 BGP Peer Node SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#149: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.c:149:
+	[BGP_LS_TLV_SRV6_SID_STRUCTURE_TLV] = {"SRv6 SID Structure TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},
Report for bgp_linkstate_tlv.h | 4 issues
===============================================
WARNING: line over 80 characters
#39: FILE: /tmp/f1-1859570/bgp_linkstate_tlv.h:39:
+ * https://www.iana.org/assignments/bgp-ls-parameters/bgp-ls-parameters.xhtml#node-descriptor-link-descriptor-prefix-descriptor-attribute-tlv

@louis-6wind
lib: register bgp link-state afi/safi
a248b27 
Register BGP Link-State AFI/SAFI values from RFC7752.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
@louis-6wind
yang: add bgp link-state
fc3b9b0 
Add bgp link-state yang structure

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
bgpd: add bgp link-state address-family configuration context
0f4dd68 
Add the bgp link-state configuration context cli:

> router bgp 65001
>  address-family link-state link-state
>   neighbor 192.0.2.2 activate
>  exit-address-family

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
bgpd: accept bgp link-state capability
1c52856 
Accept the BGP Link-State AFI/SAFI capability when received from a peer
OPEN message.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
@louis-6wind
lib: add link-state prefixes
6ab54ff 
Add to the library the link-state type of prefixes.

Link-state prefixes contain much more data than the current prefixes and
they only make sense for BGP Link-State. Storing all the data in "struct
prefix" is not relevant because it would increase the memory usage of
all daemons. Instead a pointer to a structure that contains all the
information is used. Printing link-state prefixes can be delegated to a
hook function.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
bgpd: decode, store and display link-state prefixes
fd44361 
Add the ability to decode link-state prefixes from a non FRR router, to
store them in structures and to re-encode the prefix to other routers.

Prefixes can be displayed with "show bgp all"

> r3# show bgp all
>
> For address family: Link State
> BGP table version is 24, local router ID is 192.0.2.3, vrf id 0
> Default local pref 100, local AS 65003
> Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
>                i internal, r RIB-failure, S Stale, R Removed
> Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
> Origin codes:  i - IGP, e - EGP, ? - incomplete
> RPKI validation codes: V valid, I invalid, N Not found
>
>     Network          Next Hop            Metric LocPrf Weight Path
>  *> Link ISIS-L1 ID:0x20 Local{AS:65001 ID:0 Rtr:0000.0000.1001} Remote{AS:65001 ID:0 Rtr:0000.0000.1000} Link{IPv4:10.1.0.1 Neigh-IPv4:10.1.0.2 IPv6:2001::1 Neigh-IPv6:2001::2 MT:0,2}/132
>                                            0 65002 65001 i
>  *> Node ISIS-L1 ID:0x20 Local{AS:65001 ID:0 Rtr:0000.0000.1003.00}/48
>                                            0 65002 65001 i
>  *> IPv6-Prefix OSPFv3 ID:0x20 Local{AS:65001 ID:0 Area:0 Rtr:10.10.10.10} Prefix{OSPF-Route-Type:1 IPv6:12:12::12:12/128 MT:2}/74
>                                            0 65002 65001 i
>  *> IPv6-Prefix ISIS-L2 ID:0x20 Local{AS:65001 ID:0 Rtr:0000.0000.1003.00} Prefix{IPv6:12:12::12:12/128 MT:2}/74
>                                            0 65002 65001 i
>  *> IPv4-Prefix OSPFv2 ID:0x20 Local{AS:65001 ID:0 Area:0 Rtr:10.10.10.10:1.1.1.1} Prefix{IPv4:89.10.11.0/24}/64
>                                            0 65002 65001 i
>  *> Node OSPFv2 ID:0x20 Local{AS:65001 ID:0 Area:0 Rtr:10.10.10.10:1.1.1.1}/48
>                                            0 65002 65001 i
>  *> Node OSPFv2 ID:0x20 Local{AS:65001 ID:0 Area:0 Rtr:10.10.10.10}/48
>                                            0 65002 65001 i

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
bgpd: add linkstate debug
b4e6985 
Add the "debug bgp linkstate" command to display incoming link-states
prefixes.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
bgpd: encode bgp link-state prefixes
7c8f3a2 
Add the ability to encode link-state prefixes that are in the BGP table.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
@louis-6wind
bgpd: store and send bgp link-state attributes
6e6270b 
Add the ability to store a raw copy of the incoming BGP Link-State
attributes and to redistribute them as is to other routes.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
@louis-6wind
bgpd: do not announce link-state routes to zebra
b0d3726 
Link-state prefixes are only intended to be read for a link-state
consumer (i.e. a controler). They cannot be installed in Forwarding
Information Base (FIB).

Do not announce them to zebra.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
bgpd: add bgp default link-state command
6f78e15 
Add the "bgp default link-state" command to the "router bgp" context.

> router bgp 65000
>  bgp default link-state

When this command is set, the "link-state/link-state" AFI/SAFI is
activated on all neighbors that are directly specified within the
"router bgp" unless explicitly deactivated:

> router bgp 65000
>  bgp default link-state
>  neighbor 10.0.0.1 remote-as 65001
>  address-family link-state link-state
>   no neighbor 10.0.0.1 activate

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
bgpd: add show bgp link-state link-state commands
04c1f74 
Add the "show bgp link-state link-state" following commands:

> r3# show bgp link-state link-state ?
>  <cr>
>  all            Display the entries for all address families
>  detail-routes  Display detailed version of all routes
>  json           JavaScript Object Notation
>  neighbors      Detailed information on TCP and BGP neighbor connections
>  regexp         Display routes matching the AS path regular expression
>  summary        Summary of BGP neighbor status
>  version        Display prefixes with matching version numbers
>  wide           Increase table width for longer prefixes

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
bgpd: display link-state prefix information in json
3175921 
Display detailed information about link-state prefixes in JSON mode.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
tests: add bgp_linkstate_topo1
83bbbc1 
Use an external BGP injector tool in router r1. Check that bgpd on r2 is
able to decode BGP-LS prefixes and re-encode to the r3 instance.

Link: https://github.com/louis-6wind/bgp_injector
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
doc: move bgp references at the right place
6d41210 
move bgp references at the right place

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
doc: fix bgp-ls rfc id in link-state
a531669 
Fix bgp-ls rfc id in link-state

Fixes: bbd85e2 ("lib: Add Link State Database")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
doc: add the bgp link-state user documentation
eecc5ba 
Add the bgp link-state user documentation

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind louis-6wind force-pushed the bgp-link-state-attr branch from 2373675 to e637207 Compare April 17, 2023 16:59
@louis-6wind
bgpd: display link-state attributes
aa087c1 
Display BGP-LS attributes.

> r3# show bgp link-state link-state detail-route
> (...)
> BGP routing table entry for Link ISIS-L1 ID:0x20 Local{AS:65001 ID:0 Rtr:0000.0000.1001} Remote{AS:65001 ID:0 Rtr:0000.0000.1000} Link{IPv4:10.1.0.1 Neigh-IPv4:10.1.0.2 IPv6:2001::1 Neigh-IPv6:2001::2 MT:0,2}/132, version 1
> Paths: (1 available, best #1)
>   Advertised to non peer-group peers:
>   192.0.2.2
>   65002 65001
>     :: from 192.0.2.2 (192.0.2.2)
>       Origin IGP, valid, external, best (First path received)
>       Last update: Fri Feb  3 18:12:51 2023
>   BGP-LS attributes:
>     IPv4 Router-ID of Local Node: 1.1.1.1
>     IPv4 Router-ID of Remote Node: 10.10.10.10
>     Maximum link bandwidth: 1410.07 Mbps
>     Max. reservable link bandwidth: 1410.07 Mbps
>     Unreserved bandwidth:
>       [0]: 1410.07 Mbps  [1]: 1410.07 Mbps
>       [2]: 1410.07 Mbps  [3]: 1410.07 Mbps
>       [4]: 1410.07 Mbps  [5]: 1410.07 Mbps
>       [6]: 1410.07 Mbps  [7]: 1410.07 Mbps
>     TE Default Metric: 100
>     IGP Metric:
>     Adjacency SID:
>       Flags: 0b00110000
>       Weight: 0
>       SID: 15000
>     Unidirectional Link Delay: 8500 microseconds
>     Min/Max Unidirectional Link Delay: 8000/9000 microseconds
>     Application-Specific Link Attributes:
>       SABM Flags : 0b00010000 00000000 00000000 00000000
>       UDABM Flags: 0b00000000 00000000 00000000 00000000
>       Administrative group: 0x00000001
>       TE Default Metric: 100
>       Min/Max Unidirectional Link Delay: 8000/0 microseconds
>       Extended Administrative Group: 0x00000001
>
> Displayed  8 routes and 8 total paths

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
tests: add link-state attribute display in bgp_linkstate_topo1
1eb76ad 
Add some attributes to display in the injector and check the output.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
doc: add information to display bgp-ls attributes
ef5cf3e 
Add information to display bgp-ls attributes

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind louis-6wind force-pushed the bgp-link-state-attr branch from e637207 to ef5cf3e Compare April 17, 2023 17:14
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 17, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10931/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10931/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10931/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10931/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:
bgpd/bgp_linkstate_tlv.c:1940:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 1940 |   vty_out(vty, "%pI4\n", pnt);
bgpd/bgp_linkstate_tlv.c:1947:20: error: format %pI6 expects argument of type struct in6_addr *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 1947 |   vty_out(vty, "%pI6\n", pnt);
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_sid_display:
bgpd/bgp_linkstate_tlv.c:2101:12: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 4 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 2101 |        "%pI4\n", pnt);

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10931/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 i386 build
  • CentOS 7 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 16.04 i386 build
  • FreeBSD 12 amd64 build
  • OpenBSD 7 amd64 build
  • Ubuntu 18.04 arm8 build
  • Redhat 8 amd64 build
  • Debian 9 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Redhat 9 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 11 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10931/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10931/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10931/frr-source'
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_ipv4_6_address_display:
bgpd/bgp_linkstate_tlv.c:1940:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 1940 |   vty_out(vty, "%pI4\n", pnt);
bgpd/bgp_linkstate_tlv.c:1947:20: error: format %pI6 expects argument of type struct in6_addr *, but argument 3 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 1947 |   vty_out(vty, "%pI6\n", pnt);
bgpd/bgp_linkstate_tlv.c: In function bgp_linkstate_tlv_sid_display:
bgpd/bgp_linkstate_tlv.c:2101:12: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 4 has type uint8_t * {aka unsigned char *} [-Werror=format=]
 2101 |        "%pI4\n", pnt);

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10931/artifact/DEB11AMD64/config.status/config.status

<stdin>:5008: new blank line at EOF.
+
<stdin>:7060: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for bgp_errors.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #456: FILE: /tmp/f1-2223725/bgp_errors.c:456:
< WARNING: line over 80 characters
< #461: FILE: /tmp/f1-2223725/bgp_errors.c:461:
< WARNING: line over 80 characters
< #462: FILE: /tmp/f1-2223725/bgp_errors.c:462:
< WARNING: line over 80 characters
< #466: FILE: /tmp/f1-2223725/bgp_errors.c:466:
Report for bgp_linkstate_tlv.c | 108 issues
===============================================
WARNING: line over 80 characters
#36: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:36:
+	[BGP_LS_TLV_LOCAL_NODE_DESCRIPTORS] = {"Local Node Descriptors", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#37: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:37:
+	[BGP_LS_TLV_REMOTE_NODE_DESCRIPTORS] = {"Remote Node Descriptors", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#38: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:38:
+	[BGP_LS_TLV_LINK_LOCAL_REMOTE_IDENTIFIERS] = {"Link Local/Remote Identifiers", 2, 2, UNDEF_MULTPL},

WARNING: line over 80 characters
#39: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:39:
+	[BGP_LS_TLV_IPV4_INTERFACE_ADDRESS] = {"IPv4 interface address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#40: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:40:
+	[BGP_LS_TLV_IPV4_NEIGHBOR_ADDRESS] = {"IPv4 neighbor address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#41: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:41:
+	[BGP_LS_TLV_IPV6_INTERFACE_ADDRESS] = {"IPv6 interface address", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#42: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:42:
+	[BGP_LS_TLV_IPV6_NEIGHBOR_ADDRESS] = {"IPv6 neighbor address", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#44: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:44:
+	[BGP_LS_TLV_IP_REACHABILITY_INFORMATION] = {"IP Reachability Information", 2, 17, UNDEF_MULTPL},

WARNING: line over 80 characters
#45: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:45:
+	[BGP_LS_TLV_AUTONOMOUS_SYSTEM] = {"Autonomous System", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#46: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:46:
+	[BGP_LS_TLV_BGP_LS_IDENTIFIER] = {"BGP-LS Identifier", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#55: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:55:
+	[BGP_LS_TLV_BGP_CONFEDERATION_MEMBER] = {"BGP Confederation Member", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#57: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:57:
+	[BGP_LS_TLV_OPAQUE_NODE_ATTRIBUTE] = {"Opaque Node Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#59: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:59:
+	[BGP_LS_TLV_IS_IS_AREA_IDENTIFIER] = {"IS-IS Area Identifier", 1, 13, UNDEF_MULTPL},

WARNING: line over 80 characters
#60: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:60:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_LOCAL_NODE] =	{"IPv4 Router-ID of Local Node", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#61: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:61:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_LOCAL_NODE] = {"IPv6 Router-ID of Local Node", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#62: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:62:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_REMOTE_NODE] = {"IPv4 Router-ID of Remote Node", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#63: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:63:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_REMOTE_NODE] = {"IPv6 Router-ID of Remote Node", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#64: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:64:
+	[BGP_LS_TLV_S_BFD_DISCRIMINATORS] = {"S-BFD Discriminators", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#65: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:65:
+	[BGP_LS_TLV_SR_CAPABILITIES] = {"SR Capabilities", 12, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#67: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:67:
+	[BGP_LS_TLV_SR_LOCAL_BLOCK] = {"SR Local Block", 12, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#69: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:69:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION] = {"Flexible Algorithm Definition", 4, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#70: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:70:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_ANY_AFFINITY] = {"Flexible Algorithm Exclude Any Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#71: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:71:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ANY_AFFINITY] = {"Flexible Algorithm Include Any Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#72: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:72:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ALL_AFFINITY] = {"Flexible Algorithm Include All Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#73: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:73:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION_FLAGS] = {"Flexible Algorithm Definition Flags", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#74: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:74:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_PREFIX_METRIC] = {"Flexible Algorithm Prefix Metric", 8, 8, UNDEF_MULTPL},

WARNING: line over 80 characters
#75: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:75:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_SRLG] = {"Flexible Algorithm Exclude SRLG", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#76: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:76:
+	[BGP_LS_TLV_ADMINISTRATIVE_GROUP] = {"Administrative group", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#77: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:77:
+	[BGP_LS_TLV_MAXIMUM_LINK_BANDWIDTH] = {"Maximum link bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#78: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:78:
+	[BGP_LS_TLV_MAX_RESERVABLE_LINK_BANDWIDTH] = {"Max. reservable link bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#79: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:79:
+	[BGP_LS_TLV_UNRESERVED_BANDWIDTH] = {"Unreserved bandwidth", 32, 32, UNDEF_MULTPL},

WARNING: line over 80 characters
#80: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:80:
+	[BGP_LS_TLV_TE_DEFAULT_METRIC] = {"TE Default Metric", 3, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#81: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:81:
+	[BGP_LS_TLV_LINK_PROTECTION_TYPE] = {"Link Protection Type", 2, 2, UNDEF_MULTPL},

WARNING: line over 80 characters
#82: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:82:
+	[BGP_LS_TLV_MPLS_PROTOCOL_MASK] = {"MPLS Protocol Mask", 1, 1, UNDEF_MULTPL},

WARNING: line over 80 characters
#84: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:84:
+	[BGP_LS_TLV_SHARED_RISK_LINK_GROUP] = {"Shared Risk Link Group", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#85: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:85:
+	[BGP_LS_TLV_OPAQUE_LINK_ATTRIBUTE] = {"Opaque Link Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#88: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:88:
+	[BGP_LS_TLV_LAN_ADJACENCY_SID] = {"LAN Adjacency SID", 11, 14, UNDEF_MULTPL},

WARNING: line over 80 characters
#92: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:92:
+	[BGP_LS_TLV_RTM_CAPABILITY] = {"RTM Capability", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#93: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:93:
+	[BGP_LS_TLV_UNIDIRECTIONAL_LINK_DELAY] = {"Unidirectional Link Delay", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#94: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:94:
+	[BGP_LS_TLV_MIN_MAX_UNIDIRECTIONAL_LINK_DELAY] = {"Min/Max Unidirectional Link Delay", 8, 8, UNDEF_MULTPL},

WARNING: line over 80 characters
#95: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:95:
+	[BGP_LS_TLV_UNIDIRECTIONAL_DELAY_VARIATION] = {"Unidirectional Delay Variation", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#96: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:96:
+	[BGP_LS_TLV_UNIDIRECTIONAL_LINK_LOSS] = {"Unidirectional Link Loss", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#97: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:97:
+	[BGP_LS_TLV_UNIDIRECTIONAL_RESIDUAL_BANDWIDTH] = {"Unidirectional Residual Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#98: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:98:
+	[BGP_LS_TLV_UNIDIRECTIONAL_AVAILABLE_BANDWIDTH] = {"Unidirectional Available Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#99: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:99:
+	[BGP_LS_TLV_UNIDIRECTIONAL_UTILIZED_BANDWIDTH] = {"Unidirectional Utilized Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#100: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:100:
+	[BGP_LS_TLV_GRACEFUL_LINK_SHUTDOWN_TLV] = {"Graceful-Link-Shutdown TLV", 0, 0, UNDEF_MULTPL},

WARNING: line over 80 characters
#101: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:101:
+	[BGP_LS_TLV_APPLICATION_SPECIFIC_LINK_ATTRIBUTES] = {"Application-Specific Link Attributes", 11, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#104: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:104:
+	[BGP_LS_TLV_IGP_EXTENDED_ROUTE_TAG] = {"IGP Extended Route Tag", 8, MAX_SZ, 8},

WARNING: line over 80 characters
#106: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:106:
+	[BGP_LS_TLV_OSPF_FORWARDING_ADDRESS] = {"OSPF Forwarding Address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#107: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:107:
+	[BGP_LS_TLV_OPAQUE_PREFIX_ATTRIBUTE] = {"Opaque Prefix Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#111: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:111:
+	[BGP_LS_TLV_PREFIX_ATTRIBUTES_FLAGS] = {"Prefix Attributes Flags", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#112: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:112:
+	[BGP_LS_TLV_SOURCE_ROUTER_IDENTIFIER] = {"Source Router Identifier", 4, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#113: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:113:
+	[BGP_LS_TLV_L2_BUNDLE_MEMBER_ATTRIBUTES] = {"L2 Bundle Member Attributes", 4, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#114: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:114:
+	[BGP_LS_TLV_EXTENDED_ADMINISTRATIVE_GROUP] = {"Extended Administrative Group", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#115: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:115:
+	[BGP_LS_TLV_SOURCE_OSPF_ROUTER_ID] = {"Source OSPF Router-ID", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#117: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:117:
+	[BGP_LS_TLV_SRV6_SID_INFORMATION_TLV] = {"SRv6 SID Information TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#118: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:118:
+	[BGP_LS_TLV_TUNNEL_ID_TLV] = {"Tunnel ID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#119: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:119:
+	[BGP_LS_TLV_LSP_ID_TLV] = {"LSP ID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#120: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:120:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_HEAD_END_ADDRESS_TLV] = {"IPv4/6 Tunnel Head-end address TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#121: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:121:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_TAIL_END_ADDRESS_TLV] = {"IPv4/6 Tunnel Tail-end address TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#122: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:122:
+	[BGP_LS_TLV_SR_POLICY_CP_DESCRIPTOR_TLV] = {"SR Policy CP Descriptor TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#123: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:123:
+	[BGP_LS_TLV_MPLS_LOCAL_CROSS_CONNECT_TLV] = {"MPLS Local Cross Connect TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#124: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:124:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_INTERFACE_TLV] = {"MPLS Cross Connect Interface TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#125: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:125:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_FEC_TLV] = {"MPLS Cross Connect FEC TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#126: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:126:
+	[BGP_LS_TLV_SRV6_CAPABILITIES_TLV] = {"SRv6 Capabilities TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#127: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:127:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_UNSUPPORTED] = {"Flexible Algorithm Unsupported", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#128: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:128:
+	[BGP_LS_TLV_SRV6_END_X_SID_TLV] = {"SRv6 End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#129: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:129:
+	[BGP_LS_TLV_IS_IS_SRV6_LAN_END_X_SID_TLV] = {"IS-IS SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#130: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:130:
+	[BGP_LS_TLV_OSPFV3_SRV6_LAN_END_X_SID_TLV] = {"OSPFv3 SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#131: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:131:
+	[BGP_LS_TLV_IS_IS_FLOOD_REFLECTION] = {"IS-IS Flood Reflection", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#132: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:132:
+	[BGP_LS_TLV_SRV6_LOCATOR_TLV] = {"SRv6 Locator TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#133: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:133:
+	[BGP_LS_TLV_MPLS_TE_POLICY_STATE_TLV] = {"MPLS-TE Policy State TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#134: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:134:
+	[BGP_LS_TLV_SR_BSID_TLV] = {"SR BSID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#135: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:135:
+	[BGP_LS_TLV_SR_CP_STATE_TLV] = {"SR CP State TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#136: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:136:
+	[BGP_LS_TLV_SR_CP_NAME_TLV] = {"SR CP Name TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#137: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:137:
+	[BGP_LS_TLV_SR_CP_CONSTRAINTS_TLV] = {"SR CP Constraints TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#138: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:138:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_TLV] = {"SR Segment List TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#139: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:139:
+	[BGP_LS_TLV_SR_SEGMENT_SUB_TLV] = {"SR Segment sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#140: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:140:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_METRIC_SUB_TLV] = {"SR Segment List Metric sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#141: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:141:
+	[BGP_LS_TLV_SR_AFFINITY_CONSTRAINT_SUB_TLV] = {"SR Affinity Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#142: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:142:
+	[BGP_LS_TLV_SR_SRLG_CONSTRAINT_SUB_TLV] = {"SR SRLG Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#143: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:143:
+	[BGP_LS_TLV_SR_BANDWIDTH_CONSTRAINT_SUB_TLV] = {"SR Bandwidth Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#144: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:144:
+	[BGP_LS_TLV_SR_DISJOINT_GROUP_CONSTRAINT_SUB_TLV] = {"SR Disjoint Group Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#145: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:145:
+	[BGP_LS_TLV_SRV6_BSID_TLV] = {"SRv6 BSID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#146: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:146:
+	[BGP_LS_TLV_SR_POLICY_NAME_TLV] = {"SR Policy Name TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#147: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:147:
+	[BGP_LS_TLV_SRV6_ENDPOINT_FUNCTION_TLV] = {"SRv6 Endpoint Function TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#148: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:148:
+	[BGP_LS_TLV_SRV6_BGP_PEER_NODE_SID_TLV] = {"SRv6 BGP Peer Node SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#149: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:149:
+	[BGP_LS_TLV_SRV6_SID_STRUCTURE_TLV] = {"SRv6 SID Structure TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#625: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:625:
+		assert(!"NLRI link descriptor decode cannot be used for this TLV type!");

WARNING: line over 80 characters
#963: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:963:
+		assert(!"NLRI prefix4 descriptor decode cannot be used for this TLV type!");

WARNING: line over 80 characters
#1243: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.c:1243:
+		assert(!"NLRI prefix6 descriptor decode cannot be used for this TLV type!");
Report for bgp_linkstate_tlv.h | 4 issues
===============================================
WARNING: line over 80 characters
#39: FILE: /tmp/f1-2223725/bgp_linkstate_tlv.h:39:
+ * https://www.iana.org/assignments/bgp-ls-parameters/bgp-ls-parameters.xhtml#node-descriptor-link-descriptor-prefix-descriptor-attribute-tlv

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10932/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-10932/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10932/artifact/TOPO6U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10932/artifact/TOPO6U18I386/TopotestDetails/

Successful on other platforms/tests
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 7
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 6
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 3
  • Topotests debian 10 amd64 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 2
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 arm8 part 7
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-10932/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10932/artifact/TOPO6U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10932/artifact/TOPO6U18I386/TopotestDetails/

<stdin>:5009: new blank line at EOF.
+
<stdin>:7061: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for bgp_errors.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #456: FILE: /tmp/f1-2272651/bgp_errors.c:456:
< WARNING: line over 80 characters
< #461: FILE: /tmp/f1-2272651/bgp_errors.c:461:
< WARNING: line over 80 characters
< #462: FILE: /tmp/f1-2272651/bgp_errors.c:462:
< WARNING: line over 80 characters
< #466: FILE: /tmp/f1-2272651/bgp_errors.c:466:
Report for bgp_linkstate_tlv.c | 108 issues
===============================================
WARNING: line over 80 characters
#36: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:36:
+	[BGP_LS_TLV_LOCAL_NODE_DESCRIPTORS] = {"Local Node Descriptors", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#37: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:37:
+	[BGP_LS_TLV_REMOTE_NODE_DESCRIPTORS] = {"Remote Node Descriptors", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#38: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:38:
+	[BGP_LS_TLV_LINK_LOCAL_REMOTE_IDENTIFIERS] = {"Link Local/Remote Identifiers", 2, 2, UNDEF_MULTPL},

WARNING: line over 80 characters
#39: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:39:
+	[BGP_LS_TLV_IPV4_INTERFACE_ADDRESS] = {"IPv4 interface address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#40: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:40:
+	[BGP_LS_TLV_IPV4_NEIGHBOR_ADDRESS] = {"IPv4 neighbor address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#41: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:41:
+	[BGP_LS_TLV_IPV6_INTERFACE_ADDRESS] = {"IPv6 interface address", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#42: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:42:
+	[BGP_LS_TLV_IPV6_NEIGHBOR_ADDRESS] = {"IPv6 neighbor address", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#44: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:44:
+	[BGP_LS_TLV_IP_REACHABILITY_INFORMATION] = {"IP Reachability Information", 2, 17, UNDEF_MULTPL},

WARNING: line over 80 characters
#45: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:45:
+	[BGP_LS_TLV_AUTONOMOUS_SYSTEM] = {"Autonomous System", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#46: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:46:
+	[BGP_LS_TLV_BGP_LS_IDENTIFIER] = {"BGP-LS Identifier", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#55: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:55:
+	[BGP_LS_TLV_BGP_CONFEDERATION_MEMBER] = {"BGP Confederation Member", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#57: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:57:
+	[BGP_LS_TLV_OPAQUE_NODE_ATTRIBUTE] = {"Opaque Node Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#59: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:59:
+	[BGP_LS_TLV_IS_IS_AREA_IDENTIFIER] = {"IS-IS Area Identifier", 1, 13, UNDEF_MULTPL},

WARNING: line over 80 characters
#60: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:60:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_LOCAL_NODE] =	{"IPv4 Router-ID of Local Node", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#61: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:61:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_LOCAL_NODE] = {"IPv6 Router-ID of Local Node", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#62: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:62:
+	[BGP_LS_TLV_IPV4_ROUTER_ID_OF_REMOTE_NODE] = {"IPv4 Router-ID of Remote Node", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#63: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:63:
+	[BGP_LS_TLV_IPV6_ROUTER_ID_OF_REMOTE_NODE] = {"IPv6 Router-ID of Remote Node", 16, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#64: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:64:
+	[BGP_LS_TLV_S_BFD_DISCRIMINATORS] = {"S-BFD Discriminators", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#65: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:65:
+	[BGP_LS_TLV_SR_CAPABILITIES] = {"SR Capabilities", 12, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#67: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:67:
+	[BGP_LS_TLV_SR_LOCAL_BLOCK] = {"SR Local Block", 12, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#69: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:69:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION] = {"Flexible Algorithm Definition", 4, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#70: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:70:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_ANY_AFFINITY] = {"Flexible Algorithm Exclude Any Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#71: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:71:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ANY_AFFINITY] = {"Flexible Algorithm Include Any Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#72: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:72:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_INCLUDE_ALL_AFFINITY] = {"Flexible Algorithm Include All Affinity", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#73: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:73:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_DEFINITION_FLAGS] = {"Flexible Algorithm Definition Flags", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#74: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:74:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_PREFIX_METRIC] = {"Flexible Algorithm Prefix Metric", 8, 8, UNDEF_MULTPL},

WARNING: line over 80 characters
#75: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:75:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_EXCLUDE_SRLG] = {"Flexible Algorithm Exclude SRLG", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#76: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:76:
+	[BGP_LS_TLV_ADMINISTRATIVE_GROUP] = {"Administrative group", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#77: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:77:
+	[BGP_LS_TLV_MAXIMUM_LINK_BANDWIDTH] = {"Maximum link bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#78: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:78:
+	[BGP_LS_TLV_MAX_RESERVABLE_LINK_BANDWIDTH] = {"Max. reservable link bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#79: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:79:
+	[BGP_LS_TLV_UNRESERVED_BANDWIDTH] = {"Unreserved bandwidth", 32, 32, UNDEF_MULTPL},

WARNING: line over 80 characters
#80: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:80:
+	[BGP_LS_TLV_TE_DEFAULT_METRIC] = {"TE Default Metric", 3, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#81: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:81:
+	[BGP_LS_TLV_LINK_PROTECTION_TYPE] = {"Link Protection Type", 2, 2, UNDEF_MULTPL},

WARNING: line over 80 characters
#82: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:82:
+	[BGP_LS_TLV_MPLS_PROTOCOL_MASK] = {"MPLS Protocol Mask", 1, 1, UNDEF_MULTPL},

WARNING: line over 80 characters
#84: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:84:
+	[BGP_LS_TLV_SHARED_RISK_LINK_GROUP] = {"Shared Risk Link Group", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#85: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:85:
+	[BGP_LS_TLV_OPAQUE_LINK_ATTRIBUTE] = {"Opaque Link Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#88: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:88:
+	[BGP_LS_TLV_LAN_ADJACENCY_SID] = {"LAN Adjacency SID", 11, 14, UNDEF_MULTPL},

WARNING: line over 80 characters
#92: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:92:
+	[BGP_LS_TLV_RTM_CAPABILITY] = {"RTM Capability", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#93: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:93:
+	[BGP_LS_TLV_UNIDIRECTIONAL_LINK_DELAY] = {"Unidirectional Link Delay", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#94: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:94:
+	[BGP_LS_TLV_MIN_MAX_UNIDIRECTIONAL_LINK_DELAY] = {"Min/Max Unidirectional Link Delay", 8, 8, UNDEF_MULTPL},

WARNING: line over 80 characters
#95: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:95:
+	[BGP_LS_TLV_UNIDIRECTIONAL_DELAY_VARIATION] = {"Unidirectional Delay Variation", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#96: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:96:
+	[BGP_LS_TLV_UNIDIRECTIONAL_LINK_LOSS] = {"Unidirectional Link Loss", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#97: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:97:
+	[BGP_LS_TLV_UNIDIRECTIONAL_RESIDUAL_BANDWIDTH] = {"Unidirectional Residual Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#98: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:98:
+	[BGP_LS_TLV_UNIDIRECTIONAL_AVAILABLE_BANDWIDTH] = {"Unidirectional Available Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#99: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:99:
+	[BGP_LS_TLV_UNIDIRECTIONAL_UTILIZED_BANDWIDTH] = {"Unidirectional Utilized Bandwidth", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#100: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:100:
+	[BGP_LS_TLV_GRACEFUL_LINK_SHUTDOWN_TLV] = {"Graceful-Link-Shutdown TLV", 0, 0, UNDEF_MULTPL},

WARNING: line over 80 characters
#101: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:101:
+	[BGP_LS_TLV_APPLICATION_SPECIFIC_LINK_ATTRIBUTES] = {"Application-Specific Link Attributes", 11, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#104: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:104:
+	[BGP_LS_TLV_IGP_EXTENDED_ROUTE_TAG] = {"IGP Extended Route Tag", 8, MAX_SZ, 8},

WARNING: line over 80 characters
#106: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:106:
+	[BGP_LS_TLV_OSPF_FORWARDING_ADDRESS] = {"OSPF Forwarding Address", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#107: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:107:
+	[BGP_LS_TLV_OPAQUE_PREFIX_ATTRIBUTE] = {"Opaque Prefix Attribute", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#111: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:111:
+	[BGP_LS_TLV_PREFIX_ATTRIBUTES_FLAGS] = {"Prefix Attributes Flags", 1, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#112: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:112:
+	[BGP_LS_TLV_SOURCE_ROUTER_IDENTIFIER] = {"Source Router Identifier", 4, 16, UNDEF_MULTPL},

WARNING: line over 80 characters
#113: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:113:
+	[BGP_LS_TLV_L2_BUNDLE_MEMBER_ATTRIBUTES] = {"L2 Bundle Member Attributes", 4, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#114: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:114:
+	[BGP_LS_TLV_EXTENDED_ADMINISTRATIVE_GROUP] = {"Extended Administrative Group", 4, MAX_SZ, 4},

WARNING: line over 80 characters
#115: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:115:
+	[BGP_LS_TLV_SOURCE_OSPF_ROUTER_ID] = {"Source OSPF Router-ID", 4, 4, UNDEF_MULTPL},

WARNING: line over 80 characters
#117: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:117:
+	[BGP_LS_TLV_SRV6_SID_INFORMATION_TLV] = {"SRv6 SID Information TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#118: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:118:
+	[BGP_LS_TLV_TUNNEL_ID_TLV] = {"Tunnel ID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#119: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:119:
+	[BGP_LS_TLV_LSP_ID_TLV] = {"LSP ID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#120: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:120:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_HEAD_END_ADDRESS_TLV] = {"IPv4/6 Tunnel Head-end address TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#121: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:121:
+	[BGP_LS_TLV_IPV4_6_TUNNEL_TAIL_END_ADDRESS_TLV] = {"IPv4/6 Tunnel Tail-end address TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#122: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:122:
+	[BGP_LS_TLV_SR_POLICY_CP_DESCRIPTOR_TLV] = {"SR Policy CP Descriptor TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#123: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:123:
+	[BGP_LS_TLV_MPLS_LOCAL_CROSS_CONNECT_TLV] = {"MPLS Local Cross Connect TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#124: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:124:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_INTERFACE_TLV] = {"MPLS Cross Connect Interface TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#125: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:125:
+	[BGP_LS_TLV_MPLS_CROSS_CONNECT_FEC_TLV] = {"MPLS Cross Connect FEC TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#126: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:126:
+	[BGP_LS_TLV_SRV6_CAPABILITIES_TLV] = {"SRv6 Capabilities TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#127: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:127:
+	[BGP_LS_TLV_FLEXIBLE_ALGORITHM_UNSUPPORTED] = {"Flexible Algorithm Unsupported", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#128: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:128:
+	[BGP_LS_TLV_SRV6_END_X_SID_TLV] = {"SRv6 End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#129: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:129:
+	[BGP_LS_TLV_IS_IS_SRV6_LAN_END_X_SID_TLV] = {"IS-IS SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#130: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:130:
+	[BGP_LS_TLV_OSPFV3_SRV6_LAN_END_X_SID_TLV] = {"OSPFv3 SRv6 LAN End.X SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#131: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:131:
+	[BGP_LS_TLV_IS_IS_FLOOD_REFLECTION] = {"IS-IS Flood Reflection", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#132: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:132:
+	[BGP_LS_TLV_SRV6_LOCATOR_TLV] = {"SRv6 Locator TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#133: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:133:
+	[BGP_LS_TLV_MPLS_TE_POLICY_STATE_TLV] = {"MPLS-TE Policy State TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#134: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:134:
+	[BGP_LS_TLV_SR_BSID_TLV] = {"SR BSID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#135: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:135:
+	[BGP_LS_TLV_SR_CP_STATE_TLV] = {"SR CP State TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#136: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:136:
+	[BGP_LS_TLV_SR_CP_NAME_TLV] = {"SR CP Name TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#137: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:137:
+	[BGP_LS_TLV_SR_CP_CONSTRAINTS_TLV] = {"SR CP Constraints TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#138: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:138:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_TLV] = {"SR Segment List TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#139: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:139:
+	[BGP_LS_TLV_SR_SEGMENT_SUB_TLV] = {"SR Segment sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#140: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:140:
+	[BGP_LS_TLV_SR_SEGMENT_LIST_METRIC_SUB_TLV] = {"SR Segment List Metric sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#141: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:141:
+	[BGP_LS_TLV_SR_AFFINITY_CONSTRAINT_SUB_TLV] = {"SR Affinity Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#142: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:142:
+	[BGP_LS_TLV_SR_SRLG_CONSTRAINT_SUB_TLV] = {"SR SRLG Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#143: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:143:
+	[BGP_LS_TLV_SR_BANDWIDTH_CONSTRAINT_SUB_TLV] = {"SR Bandwidth Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#144: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:144:
+	[BGP_LS_TLV_SR_DISJOINT_GROUP_CONSTRAINT_SUB_TLV] = {"SR Disjoint Group Constraint sub-TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#145: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:145:
+	[BGP_LS_TLV_SRV6_BSID_TLV] = {"SRv6 BSID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#146: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:146:
+	[BGP_LS_TLV_SR_POLICY_NAME_TLV] = {"SR Policy Name TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#147: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:147:
+	[BGP_LS_TLV_SRV6_ENDPOINT_FUNCTION_TLV] = {"SRv6 Endpoint Function TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#148: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:148:
+	[BGP_LS_TLV_SRV6_BGP_PEER_NODE_SID_TLV] = {"SRv6 BGP Peer Node SID TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#149: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:149:
+	[BGP_LS_TLV_SRV6_SID_STRUCTURE_TLV] = {"SRv6 SID Structure TLV", UNDEF_MIN_SZ, MAX_SZ, UNDEF_MULTPL},

WARNING: line over 80 characters
#625: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:625:
+		assert(!"NLRI link descriptor decode cannot be used for this TLV type!");

WARNING: line over 80 characters
#963: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:963:
+		assert(!"NLRI prefix4 descriptor decode cannot be used for this TLV type!");

WARNING: line over 80 characters
#1243: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.c:1243:
+		assert(!"NLRI prefix6 descriptor decode cannot be used for this TLV type!");
Report for bgp_linkstate_tlv.h | 4 issues
===============================================
WARNING: line over 80 characters
#39: FILE: /tmp/f1-2272651/bgp_linkstate_tlv.h:39:
+ * https://www.iana.org/assignments/bgp-ls-parameters/bgp-ls-parameters.xhtml#node-descriptor-link-descriptor-prefix-descriptor-attribute-tlv

@riw777 riw777 self-requested a review April 18, 2023 12:50
@louis-6wind
Copy link
Contributor Author

display of attributes are now integrated to #12649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 Awaiting requested review from riw777

Assignees
No one assigned
Labels
bgp bugfix documentation libfrr master size/XXL tests Topotests, make check, etc yang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-6wind @NetDEF-CI