ospfd: Fix ospf_lsa memory leak

[Keelan10]

Free the translated LSA when LSA installation fails

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10822/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10822/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 6
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 amd64 part 5
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests debian 10 amd64 part 6
• Addresssanitizer topotests part 3
• Topotests debian 10 amd64 part 0
• Addresssanitizer topotests part 9
• Topotests debian 10 amd64 part 5
• Topotests Ubuntu 18.04 arm8 part 7
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 arm8 part 8
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 3
• Addresssanitizer topotests part 6
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 5
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 i386 part 0
• Topotests Ubuntu 18.04 amd64 part 2
• Addresssanitizer topotests part 0
• Debian 10 deb pkg check
• Topotests debian 10 amd64 part 3
• Topotests debian 10 amd64 part 8
• Topotests Ubuntu 18.04 amd64 part 6
• Ubuntu 18.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests Ubuntu 18.04 amd64 part 9
• Addresssanitizer topotests part 4
• Debian 9 deb pkg check
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 i386 part 8
• Addresssanitizer topotests part 8
• Addresssanitizer topotests part 7
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests Ubuntu 18.04 i386 part 9
• Addresssanitizer topotests part 5
• Topotests debian 10 amd64 part 1
• Static analyzer (clang)
• Topotests Ubuntu 18.04 arm8 part 0
• Ubuntu 16.04 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests debian 10 amd64 part 2

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10822/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for ospf_lsa.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #2030: FILE: /tmp/f1-1847047/ospf_lsa.c:2030:
< WARNING: line over 80 characters
< #2147: FILE: /tmp/f1-1847047/ospf_lsa.c:2147:

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10823/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

[Jafaral]

@Mergifyio backport stable/8.4 stable/8.5

[mergify]

backport stable/8.4 stable/8.5

✅ Backports have been created

• #13277 ospfd: Fix ospf_lsa memory leak (backport #13269) has been created for branch stable/8.4
• #13278 ospfd: Fix ospf_lsa memory leak (backport #13269) has been created for branch stable/8.5