-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd:add local_es_df_preference into l2vpn-evpn es json output #13250
Conversation
Added "Local ES DF preference" into bgp l2vpn evpn es json output. - show bgp l2vpn evpn es <es-id> json - show bgp l2vpn evpn es detail json Before Fix:- ``` cumulus@torm-11:mgmt:~$ sudo vtysh -c "show bgp l2vpn evpn es 03:44:38:39:ff:ff:01:00:00:01 json" { "esi":"03:44:38:39:ff:ff:01:00:00:01", "rd":"27.0.0.21:15", "type":[ "local", "remote" ], "vteps":[ { "vtep_ip":"27.0.0.22", "flags":[ "esr", "active" ], "dfPreference":32767, "dfAlgorithm":32767 }, { "vtep_ip":"27.0.0.23", "flags":[ "esr", "active" ], "dfPreference":32767, "dfAlgorithm":32767 } ], "vniCount":10, "flags":[ "up", "advertiseEVI" ], "originator_ip":"27.0.0.21", "remoteVniCount":10, "vrfCount":3, "macipPathCount":33, "macipGlobalPathCount":132, "inconsistentVniVtepCount":0, "fragments":[ { "rd":"27.0.0.21:15", "eviCount":10 } ] } cumulus@torm-11:mgmt:~$ ``` After Fix:- ``` cumulus@torm-11:mgmt:~$ cumulus@torm-11:mgmt:~$ sudo vtysh -c "show bgp l2vpn evpn es 03:44:38:39:ff:ff:01:00:00:01 json" { "esi":"03:44:38:39:ff:ff:01:00:00:01", "rd":"27.0.0.21:4", "type":[ "local", "remote" ], "vteps":[ { "vtep_ip":"27.0.0.22", "flags":[ "esr", "active" ], "dfPreference":32767, "dfAlgorithm":32767 }, { "vtep_ip":"27.0.0.23", "flags":[ "esr", "active" ], "dfPreference":32767, "dfAlgorithm":32767 } ], "vniCount":10, "flags":[ "advertiseEVI" ], "originator_ip":"27.0.0.21", "remoteVniCount":10, "vrfCount":3, "macipPathCount":33, "macipGlobalPathCount":132, "inconsistentVniVtepCount":0, "localEsDfPreference":50000, ====> Added Local ES DF preference "fragments":[ { "rd":"27.0.0.21:4", "eviCount":10 } ] } cumulus@torm-11:mgmt:~$ ``` Ticket:#3411906 Issue:3411906 Testing: UT done Signed-off-by: Sindhu Parvathi Gopinathan's <sgopinathan@nvidia.com>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10776/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We could reuse CHECK_FLAG(), but it's not blocking.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10776/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
failure in ospf, doesn't look related (?) ... rerunning to see if we can clear this |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10776/ This is a comment from an automated CI system. |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10791/test Topology Tests failed for Topotests debian 10 amd64 part 9 Successful on other platforms/tests
|
Added "Local ES DF preference" into bgp l2vpn evpn es json output.
Before Fix:-
After Fix:-
Signed-off-by: Sindhu Parvathi Gopinathan's sgopinathan@nvidia.com