Evpn crashes and other ilk #13247
Merged
Evpn crashes and other ilk #13247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's cut to the chase, we know the pointer type and it allows us to not to some gyrations. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
When a `no router bgp XXX` is issued and the bgp instance is in the process of shutting down, do not allow a l3vni change coming up from zebra to do anything. We can just safely ignore it at this point in time. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
When we have these sequence of events causing a crash in evpn_type5_test_topo1: (A) no router bgp vrf RED 100 this schedules for deletion the vrf RED instance (B) a l3vni change event from zebra this creates a bgp instance for VRF RED in some cases additionally it auto imports evpn routes into VRF RED Please note this is desired behavior to allow for the auto importation of evpn vrf routes (C) no router bgp 100 The code was allowing the deletion of the default instance and causing tests to crash. Effectively the test in bgp_vty to allow/dissallow the removal of the default instance was not correct for the case when (B) happens. Let's just not allow the command to succeed in this case as that the test was wrong. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10765/ This is a comment from an automated CI system. |
|
@Mergifyio backport stable/8.5 stable/8.4 |
✅ Backports have been created
|
This was referenced Apr 11, 2023
ton31337
added a commit
that referenced
this pull request
Apr 11, 2023
Evpn crashes and other ilk (backport #13247)
ton31337
added a commit
that referenced
this pull request
Apr 11, 2023
Evpn crashes and other ilk (backport #13247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits but evpn_type5_test_topo1 is crashing regularly this should solve the issue