Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ripd YANG operational state (ECMP routes) #13228

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Update ripd YANG operational state (ECMP routes) #13228

merged 4 commits into from
Apr 7, 2023

Conversation

choppsv1
Copy link
Contributor

@choppsv1 choppsv1 commented Apr 7, 2023

No description provided.

@choppsv1
yang: fix YANG lint
01bdc91 
Signed-off-by: Christian Hopps <chopps@labn.net>
@frrbot frrbot bot added bugfix rip tests Topotests, make check, etc yang labels Apr 7, 2023
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 7, 2023 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10700/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:297: new blank line at EOF.
+
<stdin>:316: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for rip_nb.c | 248 issues
===============================================
< ERROR: code indent should use tabs where possible
< #341: FILE: /tmp/f1-942473/rip_nb.c:341:
< WARNING: please, no spaces at the start of a line
< #341: FILE: /tmp/f1-942473/rip_nb.c:341:
< ERROR: code indent should use tabs where possible
< #342: FILE: /tmp/f1-942473/rip_nb.c:342:
< WARNING: please, no spaces at the start of a line
< #342: FILE: /tmp/f1-942473/rip_nb.c:342:
< WARNING: line over 80 characters
< #343: FILE: /tmp/f1-942473/rip_nb.c:343:
< ERROR: code indent should use tabs where possible
< #343: FILE: /tmp/f1-942473/rip_nb.c:343:
< WARNING: please, no spaces at the start of a line
< #343: FILE: /tmp/f1-942473/rip_nb.c:343:
< ERROR: code indent should use tabs where possible
< #344: FILE: /tmp/f1-942473/rip_nb.c:344:
< WARNING: please, no spaces at the start of a line
< #344: FILE: /tmp/f1-942473/rip_nb.c:344:
< ERROR: code indent should use tabs where possible
< #345: FILE: /tmp/f1-942473/rip_nb.c:345:
< WARNING: please, no spaces at the start of a line
< #345: FILE: /tmp/f1-942473/rip_nb.c:345:
< ERROR: code indent should use tabs where possible
< #346: FILE: /tmp/f1-942473/rip_nb.c:346:
< WARNING: please, no spaces at the start of a line
< #346: FILE: /tmp/f1-942473/rip_nb.c:346:
< WARNING: line over 80 characters
< #347: FILE: /tmp/f1-942473/rip_nb.c:347:
< ERROR: code indent should use tabs where possible
< #347: FILE: /tmp/f1-942473/rip_nb.c:347:
< WARNING: please, no spaces at the start of a line
< #347: FILE: /tmp/f1-942473/rip_nb.c:347:
< ERROR: code indent should use tabs where possible
< #348: FILE: /tmp/f1-942473/rip_nb.c:348:
< WARNING: please, no spaces at the start of a line
< #348: FILE: /tmp/f1-942473/rip_nb.c:348:
< WARNING: line over 80 characters
< #349: FILE: /tmp/f1-942473/rip_nb.c:349:
< ERROR: code indent should use tabs where possible
< #349: FILE: /tmp/f1-942473/rip_nb.c:349:
< WARNING: please, no spaces at the start of a line
< #349: FILE: /tmp/f1-942473/rip_nb.c:349:
< ERROR: code indent should use tabs where possible
< #350: FILE: /tmp/f1-942473/rip_nb.c:350:
< WARNING: please, no spaces at the start of a line
< #350: FILE: /tmp/f1-942473/rip_nb.c:350:
< ERROR: code indent should use tabs where possible
< #351: FILE: /tmp/f1-942473/rip_nb.c:351:
< WARNING: please, no spaces at the start of a line
< #351: FILE: /tmp/f1-942473/rip_nb.c:351:
< ERROR: code indent should use tabs where possible
< #352: FILE: /tmp/f1-942473/rip_nb.c:352:
< WARNING: please, no spaces at the start of a line
< #352: FILE: /tmp/f1-942473/rip_nb.c:352:
< WARNING: line over 80 characters
< #353: FILE: /tmp/f1-942473/rip_nb.c:353:
< ERROR: code indent should use tabs where possible
< #353: FILE: /tmp/f1-942473/rip_nb.c:353:
< WARNING: please, no spaces at the start of a line
< #353: FILE: /tmp/f1-942473/rip_nb.c:353:
< ERROR: code indent should use tabs where possible
< #354: FILE: /tmp/f1-942473/rip_nb.c:354:
< WARNING: please, no spaces at the start of a line
< #354: FILE: /tmp/f1-942473/rip_nb.c:354:
< WARNING: line over 80 characters
< #355: FILE: /tmp/f1-942473/rip_nb.c:355:
< ERROR: code indent should use tabs where possible
< #355: FILE: /tmp/f1-942473/rip_nb.c:355:
< WARNING: please, no spaces at the start of a line
< #355: FILE: /tmp/f1-942473/rip_nb.c:355:
< ERROR: code indent should use tabs where possible
< #356: FILE: /tmp/f1-942473/rip_nb.c:356:
< WARNING: please, no spaces at the start of a line
< #356: FILE: /tmp/f1-942473/rip_nb.c:356:
< ERROR: code indent should use tabs where possible
< #357: FILE: /tmp/f1-942473/rip_nb.c:357:
< WARNING: please, no spaces at the start of a line
< #357: FILE: /tmp/f1-942473/rip_nb.c:357:
< ERROR: code indent should use tabs where possible
< #358: FILE: /tmp/f1-942473/rip_nb.c:358:
< WARNING: please, no spaces at the start of a line
< #358: FILE: /tmp/f1-942473/rip_nb.c:358:
< WARNING: line over 80 characters
< #359: FILE: /tmp/f1-942473/rip_nb.c:359:
< ERROR: code indent should use tabs where possible
< #359: FILE: /tmp/f1-942473/rip_nb.c:359:
< WARNING: please, no spaces at the start of a line
< #359: FILE: /tmp/f1-942473/rip_nb.c:359:
< ERROR: code indent should use tabs where possible
< #360: FILE: /tmp/f1-942473/rip_nb.c:360:
< WARNING: please, no spaces at the start of a line
< #360: FILE: /tmp/f1-942473/rip_nb.c:360:
< WARNING: line over 80 characters
< #361: FILE: /tmp/f1-942473/rip_nb.c:361:
< ERROR: code indent should use tabs where possible
< #361: FILE: /tmp/f1-942473/rip_nb.c:361:
< WARNING: please, no spaces at the start of a line
< #361: FILE: /tmp/f1-942473/rip_nb.c:361:
< ERROR: code indent should use tabs where possible
< #362: FILE: /tmp/f1-942473/rip_nb.c:362:
< WARNING: please, no spaces at the start of a line
< #362: FILE: /tmp/f1-942473/rip_nb.c:362:
< ERROR: code indent should use tabs where possible
< #363: FILE: /tmp/f1-942473/rip_nb.c:363:
< WARNING: please, no spaces at the start of a line
< #363: FILE: /tmp/f1-942473/rip_nb.c:363:
< ERROR: code indent should use tabs where possible
< #364: FILE: /tmp/f1-942473/rip_nb.c:364:
< WARNING: please, no spaces at the start of a line
< #364: FILE: /tmp/f1-942473/rip_nb.c:364:
< WARNING: line over 80 characters
< #365: FILE: /tmp/f1-942473/rip_nb.c:365:
< ERROR: code indent should use tabs where possible
< #365: FILE: /tmp/f1-942473/rip_nb.c:365:
< WARNING: please, no spaces at the start of a line
< #365: FILE: /tmp/f1-942473/rip_nb.c:365:
< ERROR: code indent should use tabs where possible
< #366: FILE: /tmp/f1-942473/rip_nb.c:366:
< WARNING: please, no spaces at the start of a line
< #366: FILE: /tmp/f1-942473/rip_nb.c:366:
< WARNING: line over 80 characters
< #367: FILE: /tmp/f1-942473/rip_nb.c:367:
< ERROR: code indent should use tabs where possible
< #367: FILE: /tmp/f1-942473/rip_nb.c:367:
< WARNING: please, no spaces at the start of a line
< #367: FILE: /tmp/f1-942473/rip_nb.c:367:
< ERROR: code indent should use tabs where possible
< #368: FILE: /tmp/f1-942473/rip_nb.c:368:
< WARNING: please, no spaces at the start of a line
< #368: FILE: /tmp/f1-942473/rip_nb.c:368:
< ERROR: code indent should use tabs where possible
< #369: FILE: /tmp/f1-942473/rip_nb.c:369:
< WARNING: please, no spaces at the start of a line
< #369: FILE: /tmp/f1-942473/rip_nb.c:369:
< ERROR: code indent should use tabs where possible
< #370: FILE: /tmp/f1-942473/rip_nb.c:370:
< WARNING: please, no spaces at the start of a line
< #370: FILE: /tmp/f1-942473/rip_nb.c:370:
< WARNING: line over 80 characters
< #371: FILE: /tmp/f1-942473/rip_nb.c:371:
< ERROR: code indent should use tabs where possible
< #371: FILE: /tmp/f1-942473/rip_nb.c:371:
< WARNING: please, no spaces at the start of a line
< #371: FILE: /tmp/f1-942473/rip_nb.c:371:
< ERROR: code indent should use tabs where possible
< #372: FILE: /tmp/f1-942473/rip_nb.c:372:
< WARNING: please, no spaces at the start of a line
< #372: FILE: /tmp/f1-942473/rip_nb.c:372:
< WARNING: line over 80 characters
< #373: FILE: /tmp/f1-942473/rip_nb.c:373:
< ERROR: code indent should use tabs where possible
< #373: FILE: /tmp/f1-942473/rip_nb.c:373:
< WARNING: please, no spaces at the start of a line
< #373: FILE: /tmp/f1-942473/rip_nb.c:373:
< ERROR: code indent should use tabs where possible
< #374: FILE: /tmp/f1-942473/rip_nb.c:374:
< WARNING: please, no spaces at the start of a line
< #374: FILE: /tmp/f1-942473/rip_nb.c:374:
< ERROR: code indent should use tabs where possible
< #375: FILE: /tmp/f1-942473/rip_nb.c:375:
< WARNING: please, no spaces at the start of a line
< #375: FILE: /tmp/f1-942473/rip_nb.c:375:
< ERROR: code indent should use tabs where possible
< #376: FILE: /tmp/f1-942473/rip_nb.c:376:
< WARNING: please, no spaces at the start of a line
< #376: FILE: /tmp/f1-942473/rip_nb.c:376:
< WARNING: line over 80 characters
< #377: FILE: /tmp/f1-942473/rip_nb.c:377:
< ERROR: code indent should use tabs where possible
< #377: FILE: /tmp/f1-942473/rip_nb.c:377:
< WARNING: please, no spaces at the start of a line
< #377: FILE: /tmp/f1-942473/rip_nb.c:377:
< ERROR: code indent should use tabs where possible
< #378: FILE: /tmp/f1-942473/rip_nb.c:378:
< WARNING: please, no spaces at the start of a line
< #378: FILE: /tmp/f1-942473/rip_nb.c:378:
< WARNING: line over 80 characters
< #379: FILE: /tmp/f1-942473/rip_nb.c:379:
< ERROR: code indent should use tabs where possible
< #379: FILE: /tmp/f1-942473/rip_nb.c:379:
< WARNING: please, no spaces at the start of a line
< #379: FILE: /tmp/f1-942473/rip_nb.c:379:
< ERROR: code indent should use tabs where possible
< #380: FILE: /tmp/f1-942473/rip_nb.c:380:
< WARNING: please, no spaces at the start of a line
< #380: FILE: /tmp/f1-942473/rip_nb.c:380:
< ERROR: code indent should use tabs where possible
< #381: FILE: /tmp/f1-942473/rip_nb.c:381:
< WARNING: please, no spaces at the start of a line
< #381: FILE: /tmp/f1-942473/rip_nb.c:381:
< ERROR: code indent should use tabs where possible
< #382: FILE: /tmp/f1-942473/rip_nb.c:382:
< WARNING: please, no spaces at the start of a line
< #382: FILE: /tmp/f1-942473/rip_nb.c:382:
< WARNING: line over 80 characters
< #383: FILE: /tmp/f1-942473/rip_nb.c:383:
< ERROR: code indent should use tabs where possible
< #383: FILE: /tmp/f1-942473/rip_nb.c:383:
< WARNING: please, no spaces at the start of a line
< #383: FILE: /tmp/f1-942473/rip_nb.c:383:
< ERROR: code indent should use tabs where possible
< #384: FILE: /tmp/f1-942473/rip_nb.c:384:
< WARNING: please, no spaces at the start of a line
< #384: FILE: /tmp/f1-942473/rip_nb.c:384:
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-942473/rip_nb.c:385:
< ERROR: code indent should use tabs where possible
< #385: FILE: /tmp/f1-942473/rip_nb.c:385:
< WARNING: please, no spaces at the start of a line
< #385: FILE: /tmp/f1-942473/rip_nb.c:385:
< ERROR: code indent should use tabs where possible
< #386: FILE: /tmp/f1-942473/rip_nb.c:386:
< WARNING: please, no spaces at the start of a line
< #386: FILE: /tmp/f1-942473/rip_nb.c:386:
< ERROR: code indent should use tabs where possible
< #387: FILE: /tmp/f1-942473/rip_nb.c:387:
< WARNING: please, no spaces at the start of a line
< #387: FILE: /tmp/f1-942473/rip_nb.c:387:
< ERROR: code indent should use tabs where possible
< #388: FILE: /tmp/f1-942473/rip_nb.c:388:
< WARNING: please, no spaces at the start of a line
< #388: FILE: /tmp/f1-942473/rip_nb.c:388:
< WARNING: line over 80 characters
< #389: FILE: /tmp/f1-942473/rip_nb.c:389:
< ERROR: code indent should use tabs where possible
< #389: FILE: /tmp/f1-942473/rip_nb.c:389:
< WARNING: please, no spaces at the start of a line
< #389: FILE: /tmp/f1-942473/rip_nb.c:389:
< ERROR: code indent should use tabs where possible
< #390: FILE: /tmp/f1-942473/rip_nb.c:390:
< WARNING: please, no spaces at the start of a line
< #390: FILE: /tmp/f1-942473/rip_nb.c:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-942473/rip_nb.c:391:
< ERROR: code indent should use tabs where possible
< #391: FILE: /tmp/f1-942473/rip_nb.c:391:
< WARNING: please, no spaces at the start of a line
< #391: FILE: /tmp/f1-942473/rip_nb.c:391:
< ERROR: code indent should use tabs where possible
< #392: FILE: /tmp/f1-942473/rip_nb.c:392:
< WARNING: please, no spaces at the start of a line
< #392: FILE: /tmp/f1-942473/rip_nb.c:392:
< ERROR: code indent should use tabs where possible
< #393: FILE: /tmp/f1-942473/rip_nb.c:393:
< WARNING: please, no spaces at the start of a line
< #393: FILE: /tmp/f1-942473/rip_nb.c:393:
< WARNING: line over 80 characters
< #395: FILE: /tmp/f1-942473/rip_nb.c:395:
Report for rip_nb_state.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #346: FILE: /tmp/f1-942473/rip_nb_state.c:346:

ton31337
ton31337 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't merge though.

@ton31337 ton31337 mentioned this pull request Apr 7, 2023
Closed
choppsv1 and others added 3 commits April 7, 2023 04:20
@choppsv1
ripd: yang: extend nexthops functionality in YANG model - skeleton
0b7f0e3 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
ripd: implement new YANG operational state
7fd2ffb 
Signed-off-by: Christian Hopps <chopps@labn.net>
@ton31337 @choppsv1
tests: Check if RIP allow-ecmp command works correctly
83c78d5 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1 choppsv1 force-pushed the chopps/json-via-yang branch from c19cba9 to 83c78d5 Compare April 7, 2023 08:22
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10709/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:325: new blank line at EOF.
+
<stdin>:344: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for rip_nb.c | 20 issues
===============================================
< ERROR: code indent should use tabs where possible
< #341: FILE: /tmp/f1-4140654/rip_nb.c:341:
< WARNING: please, no spaces at the start of a line
< #341: FILE: /tmp/f1-4140654/rip_nb.c:341:
< ERROR: code indent should use tabs where possible
< #342: FILE: /tmp/f1-4140654/rip_nb.c:342:
< WARNING: please, no spaces at the start of a line
< #342: FILE: /tmp/f1-4140654/rip_nb.c:342:
< WARNING: line over 80 characters
< #343: FILE: /tmp/f1-4140654/rip_nb.c:343:
< ERROR: code indent should use tabs where possible
< #343: FILE: /tmp/f1-4140654/rip_nb.c:343:
< WARNING: please, no spaces at the start of a line
< #343: FILE: /tmp/f1-4140654/rip_nb.c:343:
< ERROR: code indent should use tabs where possible
< #344: FILE: /tmp/f1-4140654/rip_nb.c:344:
< WARNING: please, no spaces at the start of a line
< #344: FILE: /tmp/f1-4140654/rip_nb.c:344:
< ERROR: code indent should use tabs where possible
< #345: FILE: /tmp/f1-4140654/rip_nb.c:345:
< WARNING: please, no spaces at the start of a line
< #345: FILE: /tmp/f1-4140654/rip_nb.c:345:
< ERROR: code indent should use tabs where possible
< #346: FILE: /tmp/f1-4140654/rip_nb.c:346:
< WARNING: please, no spaces at the start of a line
< #346: FILE: /tmp/f1-4140654/rip_nb.c:346:
< WARNING: line over 80 characters
< #347: FILE: /tmp/f1-4140654/rip_nb.c:347:
< ERROR: code indent should use tabs where possible
< #347: FILE: /tmp/f1-4140654/rip_nb.c:347:
< WARNING: please, no spaces at the start of a line
< #347: FILE: /tmp/f1-4140654/rip_nb.c:347:
< ERROR: code indent should use tabs where possible
< #348: FILE: /tmp/f1-4140654/rip_nb.c:348:
< WARNING: please, no spaces at the start of a line
< #348: FILE: /tmp/f1-4140654/rip_nb.c:348:
< WARNING: line over 80 characters
< #349: FILE: /tmp/f1-4140654/rip_nb.c:349:
< ERROR: code indent should use tabs where possible
< #349: FILE: /tmp/f1-4140654/rip_nb.c:349:
< WARNING: please, no spaces at the start of a line
< #349: FILE: /tmp/f1-4140654/rip_nb.c:349:
< ERROR: code indent should use tabs where possible
< #350: FILE: /tmp/f1-4140654/rip_nb.c:350:
< WARNING: please, no spaces at the start of a line
< #350: FILE: /tmp/f1-4140654/rip_nb.c:350:
< ERROR: code indent should use tabs where possible
< #351: FILE: /tmp/f1-4140654/rip_nb.c:351:
< WARNING: please, no spaces at the start of a line
< #351: FILE: /tmp/f1-4140654/rip_nb.c:351:
< ERROR: code indent should use tabs where possible
< #352: FILE: /tmp/f1-4140654/rip_nb.c:352:
< WARNING: please, no spaces at the start of a line
< #352: FILE: /tmp/f1-4140654/rip_nb.c:352:
< WARNING: line over 80 characters
< #353: FILE: /tmp/f1-4140654/rip_nb.c:353:
< ERROR: code indent should use tabs where possible
< #353: FILE: /tmp/f1-4140654/rip_nb.c:353:
< WARNING: please, no spaces at the start of a line
< #353: FILE: /tmp/f1-4140654/rip_nb.c:353:
< ERROR: code indent should use tabs where possible
< #354: FILE: /tmp/f1-4140654/rip_nb.c:354:
< WARNING: please, no spaces at the start of a line
< #354: FILE: /tmp/f1-4140654/rip_nb.c:354:
< WARNING: line over 80 characters
< #355: FILE: /tmp/f1-4140654/rip_nb.c:355:
< ERROR: code indent should use tabs where possible
< #355: FILE: /tmp/f1-4140654/rip_nb.c:355:
< WARNING: please, no spaces at the start of a line
< #355: FILE: /tmp/f1-4140654/rip_nb.c:355:
< ERROR: code indent should use tabs where possible
< #356: FILE: /tmp/f1-4140654/rip_nb.c:356:
< WARNING: please, no spaces at the start of a line
< #356: FILE: /tmp/f1-4140654/rip_nb.c:356:
< ERROR: code indent should use tabs where possible
< #357: FILE: /tmp/f1-4140654/rip_nb.c:357:
< WARNING: please, no spaces at the start of a line
< #357: FILE: /tmp/f1-4140654/rip_nb.c:357:
< ERROR: code indent should use tabs where possible
< #358: FILE: /tmp/f1-4140654/rip_nb.c:358:
< WARNING: please, no spaces at the start of a line
< #358: FILE: /tmp/f1-4140654/rip_nb.c:358:
< WARNING: line over 80 characters
< #359: FILE: /tmp/f1-4140654/rip_nb.c:359:
< ERROR: code indent should use tabs where possible
< #359: FILE: /tmp/f1-4140654/rip_nb.c:359:
< WARNING: please, no spaces at the start of a line
< #359: FILE: /tmp/f1-4140654/rip_nb.c:359:
< ERROR: code indent should use tabs where possible
< #360: FILE: /tmp/f1-4140654/rip_nb.c:360:
< WARNING: please, no spaces at the start of a line
< #360: FILE: /tmp/f1-4140654/rip_nb.c:360:
< WARNING: line over 80 characters
< #361: FILE: /tmp/f1-4140654/rip_nb.c:361:
< ERROR: code indent should use tabs where possible
< #361: FILE: /tmp/f1-4140654/rip_nb.c:361:
< WARNING: please, no spaces at the start of a line
< #361: FILE: /tmp/f1-4140654/rip_nb.c:361:
< ERROR: code indent should use tabs where possible
< #362: FILE: /tmp/f1-4140654/rip_nb.c:362:
< WARNING: please, no spaces at the start of a line
< #362: FILE: /tmp/f1-4140654/rip_nb.c:362:
< ERROR: code indent should use tabs where possible
< #363: FILE: /tmp/f1-4140654/rip_nb.c:363:
< WARNING: please, no spaces at the start of a line
< #363: FILE: /tmp/f1-4140654/rip_nb.c:363:
< ERROR: code indent should use tabs where possible
< #364: FILE: /tmp/f1-4140654/rip_nb.c:364:
< WARNING: please, no spaces at the start of a line
< #364: FILE: /tmp/f1-4140654/rip_nb.c:364:
< WARNING: line over 80 characters
< #365: FILE: /tmp/f1-4140654/rip_nb.c:365:
< ERROR: code indent should use tabs where possible
< #365: FILE: /tmp/f1-4140654/rip_nb.c:365:
< WARNING: please, no spaces at the start of a line
< #365: FILE: /tmp/f1-4140654/rip_nb.c:365:
< ERROR: code indent should use tabs where possible
< #366: FILE: /tmp/f1-4140654/rip_nb.c:366:
< WARNING: please, no spaces at the start of a line
< #366: FILE: /tmp/f1-4140654/rip_nb.c:366:
< WARNING: line over 80 characters
< #367: FILE: /tmp/f1-4140654/rip_nb.c:367:
< ERROR: code indent should use tabs where possible
< #367: FILE: /tmp/f1-4140654/rip_nb.c:367:
< WARNING: please, no spaces at the start of a line
< #367: FILE: /tmp/f1-4140654/rip_nb.c:367:
< ERROR: code indent should use tabs where possible
< #368: FILE: /tmp/f1-4140654/rip_nb.c:368:
< WARNING: please, no spaces at the start of a line
< #368: FILE: /tmp/f1-4140654/rip_nb.c:368:
< ERROR: code indent should use tabs where possible
< #369: FILE: /tmp/f1-4140654/rip_nb.c:369:
< WARNING: please, no spaces at the start of a line
< #369: FILE: /tmp/f1-4140654/rip_nb.c:369:
< ERROR: code indent should use tabs where possible
< #370: FILE: /tmp/f1-4140654/rip_nb.c:370:
< WARNING: please, no spaces at the start of a line
< #370: FILE: /tmp/f1-4140654/rip_nb.c:370:
< WARNING: line over 80 characters
< #371: FILE: /tmp/f1-4140654/rip_nb.c:371:
< ERROR: code indent should use tabs where possible
< #371: FILE: /tmp/f1-4140654/rip_nb.c:371:
< WARNING: please, no spaces at the start of a line
< #371: FILE: /tmp/f1-4140654/rip_nb.c:371:
< ERROR: code indent should use tabs where possible
< #372: FILE: /tmp/f1-4140654/rip_nb.c:372:
< WARNING: please, no spaces at the start of a line
< #372: FILE: /tmp/f1-4140654/rip_nb.c:372:
< WARNING: line over 80 characters
< #373: FILE: /tmp/f1-4140654/rip_nb.c:373:
< ERROR: code indent should use tabs where possible
< #373: FILE: /tmp/f1-4140654/rip_nb.c:373:
< WARNING: please, no spaces at the start of a line
< #373: FILE: /tmp/f1-4140654/rip_nb.c:373:
< ERROR: code indent should use tabs where possible
< #374: FILE: /tmp/f1-4140654/rip_nb.c:374:
< WARNING: please, no spaces at the start of a line
< #374: FILE: /tmp/f1-4140654/rip_nb.c:374:
< ERROR: code indent should use tabs where possible
< #375: FILE: /tmp/f1-4140654/rip_nb.c:375:
< WARNING: please, no spaces at the start of a line
< #375: FILE: /tmp/f1-4140654/rip_nb.c:375:
< ERROR: code indent should use tabs where possible
< #376: FILE: /tmp/f1-4140654/rip_nb.c:376:
< WARNING: please, no spaces at the start of a line
< #376: FILE: /tmp/f1-4140654/rip_nb.c:376:
< WARNING: line over 80 characters
< #377: FILE: /tmp/f1-4140654/rip_nb.c:377:
< ERROR: code indent should use tabs where possible
< #377: FILE: /tmp/f1-4140654/rip_nb.c:377:
< WARNING: please, no spaces at the start of a line
< #377: FILE: /tmp/f1-4140654/rip_nb.c:377:
< ERROR: code indent should use tabs where possible
< #378: FILE: /tmp/f1-4140654/rip_nb.c:378:
< WARNING: please, no spaces at the start of a line
< #378: FILE: /tmp/f1-4140654/rip_nb.c:378:
< WARNING: line over 80 characters
< #379: FILE: /tmp/f1-4140654/rip_nb.c:379:
< ERROR: code indent should use tabs where possible
< #379: FILE: /tmp/f1-4140654/rip_nb.c:379:
< WARNING: please, no spaces at the start of a line
< #379: FILE: /tmp/f1-4140654/rip_nb.c:379:
< ERROR: code indent should use tabs where possible
< #380: FILE: /tmp/f1-4140654/rip_nb.c:380:
< WARNING: please, no spaces at the start of a line
< #380: FILE: /tmp/f1-4140654/rip_nb.c:380:
< ERROR: code indent should use tabs where possible
< #381: FILE: /tmp/f1-4140654/rip_nb.c:381:
< WARNING: please, no spaces at the start of a line
< #381: FILE: /tmp/f1-4140654/rip_nb.c:381:
< ERROR: code indent should use tabs where possible
< #382: FILE: /tmp/f1-4140654/rip_nb.c:382:
< WARNING: please, no spaces at the start of a line
< #382: FILE: /tmp/f1-4140654/rip_nb.c:382:
< WARNING: line over 80 characters
< #383: FILE: /tmp/f1-4140654/rip_nb.c:383:
< ERROR: code indent should use tabs where possible
< #383: FILE: /tmp/f1-4140654/rip_nb.c:383:
< WARNING: please, no spaces at the start of a line
< #383: FILE: /tmp/f1-4140654/rip_nb.c:383:
< ERROR: code indent should use tabs where possible
< #384: FILE: /tmp/f1-4140654/rip_nb.c:384:
< WARNING: please, no spaces at the start of a line
< #384: FILE: /tmp/f1-4140654/rip_nb.c:384:
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-4140654/rip_nb.c:385:
< ERROR: code indent should use tabs where possible
< #385: FILE: /tmp/f1-4140654/rip_nb.c:385:
< WARNING: please, no spaces at the start of a line
< #385: FILE: /tmp/f1-4140654/rip_nb.c:385:
< ERROR: code indent should use tabs where possible
< #386: FILE: /tmp/f1-4140654/rip_nb.c:386:
< WARNING: please, no spaces at the start of a line
< #386: FILE: /tmp/f1-4140654/rip_nb.c:386:
< ERROR: code indent should use tabs where possible
< #387: FILE: /tmp/f1-4140654/rip_nb.c:387:
< WARNING: please, no spaces at the start of a line
< #387: FILE: /tmp/f1-4140654/rip_nb.c:387:
< ERROR: code indent should use tabs where possible
< #388: FILE: /tmp/f1-4140654/rip_nb.c:388:
< WARNING: please, no spaces at the start of a line
< #388: FILE: /tmp/f1-4140654/rip_nb.c:388:
< WARNING: line over 80 characters
< #389: FILE: /tmp/f1-4140654/rip_nb.c:389:
< ERROR: code indent should use tabs where possible
< #389: FILE: /tmp/f1-4140654/rip_nb.c:389:
< WARNING: please, no spaces at the start of a line
< #389: FILE: /tmp/f1-4140654/rip_nb.c:389:
< ERROR: code indent should use tabs where possible
< #390: FILE: /tmp/f1-4140654/rip_nb.c:390:
< WARNING: please, no spaces at the start of a line
< #390: FILE: /tmp/f1-4140654/rip_nb.c:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-4140654/rip_nb.c:391:
< ERROR: code indent should use tabs where possible
< #391: FILE: /tmp/f1-4140654/rip_nb.c:391:
< WARNING: please, no spaces at the start of a line
< #391: FILE: /tmp/f1-4140654/rip_nb.c:391:
< ERROR: code indent should use tabs where possible
< #392: FILE: /tmp/f1-4140654/rip_nb.c:392:
< WARNING: please, no spaces at the start of a line
< #392: FILE: /tmp/f1-4140654/rip_nb.c:392:
< ERROR: code indent should use tabs where possible
< #393: FILE: /tmp/f1-4140654/rip_nb.c:393:
< WARNING: please, no spaces at the start of a line
< #393: FILE: /tmp/f1-4140654/rip_nb.c:393:
< ERROR: code indent should use tabs where possible
< #394: FILE: /tmp/f1-4140654/rip_nb.c:394:
< WARNING: please, no spaces at the start of a line
< #394: FILE: /tmp/f1-4140654/rip_nb.c:394:
< WARNING: line over 80 characters
< #395: FILE: /tmp/f1-4140654/rip_nb.c:395:
< ERROR: code indent should use tabs where possible
< #395: FILE: /tmp/f1-4140654/rip_nb.c:395:
< WARNING: please, no spaces at the start of a line
< #395: FILE: /tmp/f1-4140654/rip_nb.c:395:
< ERROR: code indent should use tabs where possible
< #396: FILE: /tmp/f1-4140654/rip_nb.c:396:
< WARNING: please, no spaces at the start of a line
< #396: FILE: /tmp/f1-4140654/rip_nb.c:396:
< WARNING: line over 80 characters
< #397: FILE: /tmp/f1-4140654/rip_nb.c:397:
< ERROR: code indent should use tabs where possible
< #397: FILE: /tmp/f1-4140654/rip_nb.c:397:
< WARNING: please, no spaces at the start of a line
< #397: FILE: /tmp/f1-4140654/rip_nb.c:397:
< ERROR: code indent should use tabs where possible
< #398: FILE: /tmp/f1-4140654/rip_nb.c:398:
< WARNING: please, no spaces at the start of a line
< #398: FILE: /tmp/f1-4140654/rip_nb.c:398:
< ERROR: code indent should use tabs where possible
< #399: FILE: /tmp/f1-4140654/rip_nb.c:399:
< WARNING: please, no spaces at the start of a line
< #399: FILE: /tmp/f1-4140654/rip_nb.c:399:
< WARNING: line over 80 characters
< #401: FILE: /tmp/f1-4140654/rip_nb.c:401:
Report for rip_nb_state.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #365: FILE: /tmp/f1-4140654/rip_nb_state.c:365:

@idryzhov idryzhov merged commit 083369e into FRRouting:master Apr 7, 2023
@choppsv1 choppsv1 deleted the chopps/json-via-yang branch April 9, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idryzhov idryzhov idryzhov approved these changes

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
bugfix master rip size/XL tests Topotests, make check, etc yang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@choppsv1 @NetDEF-CI @idryzhov @ton31337