Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ospfd: support configuration of socket buffer sizes #13227

Merged
merged 1 commit into from
Apr 11, 2023
Merged

ospfd: support configuration of socket buffer sizes #13227

merged 1 commit into from
Apr 11, 2023

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented Apr 6, 2023

Add configurable socket send and receive buffer sizes, configured at the instance level. The default buffer sizes are ... pretty big, especially for sending.

@frrbot frrbot bot added the ospf label Apr 6, 2023
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 6, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI011BUILD/ErrorLog/log_make.txt)

 message "Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter"
 ^
ospfd/ospf_vty.c:13066:13: error: variable 'recvsz' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
ospfd/ospf_vty.c:13072:28: note: uninitialized use occurs here
ospfd/ospf_vty.c:13066:9: note: remove the 'if' if its condition is always true
ospfd/ospf_vty.c:13055:17: note: initialize the variable 'recvsz' to silence this warning
ospfd/ospf_vty.c:13066:13: error: variable 'sendsz' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
ospfd/ospf_vty.c:13072:36: note: uninitialized use occurs here
ospfd/ospf_vty.c:13066:9: note: remove the 'if' if its condition is always true
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/REDHAT8/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10465: ospfd/ospf_vty.o] Error 1
pimd/pim6_mld.c:349:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/REDHAT8/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/DEB10BUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10466: ospfd/ospf_vty.o] Error 1
pimd/pim6_mld.c:349:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

 4435 |   CPP_NOTICE(
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |  ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
13055 |  uint32_t recvsz, sendsz;
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |  ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI101BUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI101BUILD/config.status/config.status

Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

 4435 |                 CPP_NOTICE(
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:9: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |         ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:26: note: sendsz was declared here
13055 |         uint32_t recvsz, sendsz;
ospfd/ospf_vty.c:13072:9: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |         ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:18: note: recvsz was declared here

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI009BUILD/ErrorLog/log_make.txt)

 4435 |   CPP_NOTICE(
./ospfd/ospf_vty_clippy.c: In function 'ospf_socket_bufsizes':
ospfd/ospf_vty.c:13072:2: error: 'sendsz' may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |  ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:19: note: 'sendsz' was declared here
13055 |  uint32_t recvsz, sendsz;
ospfd/ospf_vty.c:13072:2: error: 'recvsz' may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |  ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:11: note: 'recvsz' was declared here
Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI021BUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1804AMD64/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/RH9BUILD/ErrorLog/log_make.txt)

 4435 |                 CPP_NOTICE(
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:9: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |         ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:26: note: sendsz was declared here
13055 |         uint32_t recvsz, sendsz;
ospfd/ospf_vty.c:13072:9: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |         ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:18: note: recvsz was declared here

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/CI014BUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function 'ospf_socket_bufsizes':
ospfd/ospf_vty.c:13072:2: error: 'sendsz' may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: 'sendsz' was declared here
ospfd/ospf_vty.c:13072:2: error: 'recvsz' may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: 'recvsz' was declared here
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10465: ospfd/ospf_vty.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.10694/frr-source'
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18I386BUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U18ARM8BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/U1604I386/ErrorLog/log_make.txt)

ospfd/ospf_vty.c:4435:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here
cc1: all warnings being treated as errors
Makefile:9784: recipe for target 'ospfd/ospf_vty.o' failed
make[1]: *** [ospfd/ospf_vty.o] Error 1
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/DEB11AMD64/ErrorLog/log_make.txt)

 4435 |   CPP_NOTICE(
./ospfd/ospf_vty_clippy.c: In function ospf_socket_bufsizes:
ospfd/ospf_vty.c:13072:2: error: sendsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |  ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:19: note: sendsz was declared here
13055 |  uint32_t recvsz, sendsz;
ospfd/ospf_vty.c:13072:2: error: recvsz may be used uninitialized in this function [-Werror=maybe-uninitialized]
13072 |  ospf_update_bufsize(ospf, recvsz, sendsz);
ospfd/ospf_vty.c:13055:11: note: recvsz was declared here

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10694/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • CentOS 7 amd64 build

ospfd: support configuration of socket buffer sizes
6e6e102 
Add configurable socket send and receive buffer sizes,
configured at the instance level.

Signed-off-by: Mark Stapp <mjs@labn.net>
@mjstapp mjstapp force-pushed the ospf_sock_bufsizes branch from 4775eaf to 6e6e102 Compare April 6, 2023 18:16
@mjstapp
Copy link
Contributor Author

mjstapp commented Apr 6, 2023

interesting - I don't think that SA problem is real, but ... pushed a change to see if it clears.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10695/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

rgirada
rgirada approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@rgirada rgirada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

riw777
riw777 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit e80c797 into FRRouting:master Apr 11, 2023
@mjstapp mjstapp deleted the ospf_sock_bufsizes branch April 24, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

@rgirada rgirada rgirada approved these changes

Assignees
No one assigned
Labels
master ospf size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjstapp @NetDEF-CI @riw777 @rgirada