bgpd: bmp fix peer-up ports byte order #13198
Conversation
added htons to ports in the peer-up message to fix byte order Signed-off-by: Maxence Younsi <mx.yns@outlook.fr>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-10598/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7 Successful on other platforms/tests
|
|
@Mergifyio backport stable/8.5 stable/8.4 |
✅ Backports have been created
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10598/ This is a comment from an automated CI system. |
bgpd: bmp fix peer-up ports byte order (backport #13198)
bgpd: bmp fix peer-up ports byte order (backport #13198)
according to the wireshark dissector the ports in the bmp peer-up messages are in the wrong byte order.
for example, dissected port 179 of bgp is read as 0xb300 (base10 = 45824) instead of 0x00b3 (base10 = 179)
this PR adds a htons call to the port values put in the bmp message packet for the peer-up message in ordre to fix this byte order problem