ripd: Fix malformed route-map #13192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the process of the `route-map` configuration for `per-vrf-rip` is wrong. There are two problems: 1. `ctx->name` for `if_rmap_ctx` is not initialized in `if_rmap_ctx_create()`. 2. The global `if_rmap_ctx_list` is wrongly used for `per-vrf-rip`. So, two changes for it: 1. Correctly initializes `ctx->name`. 2. Use specific `if_rmap_ctx` for `per-vrf-rip`, not global one. Note, this related implementation for `route-map` is only for `ripd`. Before: ``` anlan(config)# route rip vrf vrf1 anlan(config-router)# route-map aa in lan anlan(config-router)# do show run ! router rip route-map aa in lan exit ! ``` After: ``` anlan(config)# route rip vrf vrf1 anlan(config-router)# route-map aa in lan anlan(config-router)# do show run ! router rip vrf vrf1 route-map aa in lan exit ! ``` Signed-off-by: anlan_cs <vic.lan@pica8.com>
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10570/ This is a comment from an automated CI system. |
|
@Mergifyio backport stable/8.5 |
✅ Backports have been created
|
ton31337
added a commit
that referenced
this pull request
Apr 5, 2023
ripd: Fix malformed route-map (backport #13192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the process of the
route-mapconfiguration forper-vrf-ripis wrong.There are two problems:
ctx->nameforif_rmap_ctxis not initialized inif_rmap_ctx_create().if_rmap_ctx_listis wrongly used forper-vrf-rip.So, two changes for it:
ctx->name.if_rmap_ctxforper-vrf-rip, not global one.Note, this related implementation for
route-mapis only forripd.Before:
After: