pimd: Option to get IGMP groups and sources for a particular interface #13183

Pdoijode · 2023-03-31T23:13:16Z

Added interface name, group address and detail option to existing "show ip igmp groups" so that user can retrieve all the groups or a particular group for an interface. Detail option shows the source information for the group. With that, the show command looks like:

"show ip igmp [vrf NAME$vrf_name] groups [INTERFACE$ifname [GROUP$grp_str]] [detail$detail] [json$json]"

Changed pim_cmd_lookup_vrf() to return empty JSON if VRF is not present
Changed "detail" option to print non pretty JSON
Added interface name and group address to existing "show ip igmp sources" so that user can retrieve all the sources for all the groups or, all the sorces for a particular group for an interface. With that, the show command looks like:

"show ip igmp [vrf NAME$vrf_name] sourcess [INTERFACE$ifname [GROUP$grp_str]] [json$json]"

Test Outputs:

l1# show ip igmp vrf default groups detail
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Source          V Uptime  
l1-i1-eth1       225.1.1.2       ---- 00:00:11 *               2 04:33:25
l1-i1-eth1       225.1.1.1       ---- 00:00:09 *               2 04:33:25
l1-i1-eth1       225.1.1.3       ---- 00:00:13 *               2 04:33:25
l1-i1-eth1       225.1.1.5       ---- 00:00:10 *               2 04:33:25
l1-i1-eth1       225.1.1.4       ---- 00:00:09 *               2 04:33:25
l
1# show ip igmp vrf default groups l1-i1-eth1
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Srcs V Uptime  
l1-i1-eth1       225.1.1.2       ---- 00:00:11    1 2 04:33:58
l1-i1-eth1       225.1.1.1       ---- 00:00:11    1 2 04:33:58
l1-i1-eth1       225.1.1.3       ---- 00:00:13    1 2 04:33:58
l1-i1-eth1       225.1.1.5       ---- 00:00:10    1 2 04:33:58
l1-i1-eth1       225.1.1.4       ---- 00:00:13    1 2 04:33:58

l1# show ip igmp vrf default groups l1-i1-eth1 detail 
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Source          V Uptime  
l1-i1-eth1       225.1.1.2       ---- 00:00:12 *               2 04:34:15
l1-i1-eth1       225.1.1.1       ---- 00:00:13 *               2 04:34:15
l1-i1-eth1       225.1.1.3       ---- 00:00:13 *               2 04:34:15
l1-i1-eth1       225.1.1.5       ---- 00:00:10 *               2 04:34:15
l1-i1-eth1       225.1.1.4       ---- 00:00:13 *               2 04:34:15

l1# show ip igmp vrf default groups l1-i1-eth1 225.1.1.5
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Srcs V Uptime  
l1-i1-eth1       225.1.1.5       ---- 00:00:13    1 2 04:34:52

l1# show ip igmp vrf default groups l1-i1-eth1 225.1.1.5 detail 
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Source          V Uptime  
l1-i1-eth1       225.1.1.5       ---- 00:00:10 *               2 04:34:54

l1# show ip igmp vrf all groups detail
VRF: default
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Source          V Uptime  
l1-i1-eth1       225.1.1.2       ---- 00:00:13 *               2 04:35:27
l1-i1-eth1       225.1.1.1       ---- 00:00:12 *               2 04:35:27
l1-i1-eth1       225.1.1.3       ---- 00:00:13 *               2 04:35:27
l1-i1-eth1       225.1.1.5       ---- 00:00:13 *               2 04:35:27
l1-i1-eth1       225.1.1.4       ---- 00:00:12 *               2 04:35:27

l1# show ip igmp vrf default groups l1-i1-eth1 json 
{
  "totalGroups":5,
  "watermarkLimit":0,
  "l1-i1-eth1":{
    "name":"l1-i1-eth1",
    "state":"up",
    "address":"10.0.8.2",
    "index":18,
    "flagMulticast":true,
    "flagBroadcast":true,
    "lanDelayEnabled":true,
    "groups":[
      {
        "group":"225.1.1.2",
        "timer":"00:00:12",
        "sourcesCount":1,
        "version":2,
        "uptime":"04:35:45"
      },
      {
        "group":"225.1.1.1",
        "timer":"00:00:10",
        "sourcesCount":1,
        "version":2,
        "uptime":"04:35:45"
      },
      {
        "group":"225.1.1.3",
        "timer":"00:00:09",
        "sourcesCount":1,
        "version":2,
        "uptime":"04:35:45"
      },
      {
        "group":"225.1.1.5",
        "timer":"00:00:13",
        "sourcesCount":1,
        "version":2,
        "uptime":"04:35:45"
      },
      {
        "group":"225.1.1.4",
        "timer":"00:00:13",
        "sourcesCount":1,
        "version":2,
        "uptime":"04:35:45"
      }
    ]
  }
}

l1# show ip igmp vrf default groups l1-i1-eth1 225.1.1.5 json 
{
  "totalGroups":5,
  "watermarkLimit":0,
  "l1-i1-eth1":{
    "name":"l1-i1-eth1",
    "state":"up",
    "address":"10.0.8.2",
    "index":18,
    "flagMulticast":true,
    "flagBroadcast":true,
    "lanDelayEnabled":true,
    "groups":[
      {
        "group":"225.1.1.5",
        "timer":"00:00:13",
        "sourcesCount":1,
        "version":2,
        "uptime":"04:36:07"
      }
    ]
  }
}

l1# show ip igmp vrf default groups l1-i1-eth1 225.1.1.5 detail json 
{"totalGroups":5,"watermarkLimit":0,"l1-i1-eth1":{"name":"l1-i1-eth1","state":"up","address":"10.0.8.2","index":18,"flagMulticast":true,"flagBroadcast":true,"lanDelayEnabled":true,"groups":[{"group":"225.1.1.5","timer":"00:00:11","sourcesCount":1,"version":2,"uptime":"04:36:18","sources":[{"source":"*","timer":"00:11","forwarded":true,"uptime":"04:36:18"}]}]}}

l1# show ip igmp sources l1-i1-eth1 json 
{
  "l1-i1-eth1":{
    "name":"l1-i1-eth1",
    "225.1.1.2":{
      "group":"225.1.1.2",
      "sources":[
        {
          "source":"*",
          "timer":"00:12",
          "forwarded":true,
          "uptime":"04:37:35"
        }
      ]
    },
    "225.1.1.1":{
      "group":"225.1.1.1",
      "sources":[
        {
          "source":"*",
          "timer":"00:08",
          "forwarded":true,
          "uptime":"04:37:35"
        }
      ]
    },
    "225.1.1.3":{
      "group":"225.1.1.3",
      "sources":[
        {
          "source":"*",
          "timer":"00:12",
          "forwarded":true,
          "uptime":"04:37:35"
        }
      ]
    },
    "225.1.1.5":{
      "group":"225.1.1.5",
      "sources":[
        {
          "source":"*",
          "timer":"00:12",
          "forwarded":true,
          "uptime":"04:37:35"
        }
      ]
    },
    "225.1.1.4":{
      "group":"225.1.1.4",
      "sources":[
        {
          "source":"*",
          "timer":"00:12",
          "forwarded":true,
          "uptime":"04:37:35"
        }
      ]
    }
  }
}

l1# show ip igmp sources l1-i1-eth1 225.1.1.4 json 
{
  "l1-i1-eth1":{
    "name":"l1-i1-eth1",
    "225.1.1.4":{
      "group":"225.1.1.4",
      "sources":[
        {
          "source":"*",
          "timer":"00:13",
          "forwarded":true,
          "uptime":"04:37:47"
        }
      ]
    }
  }
}

l1# show ip igmp sources l1-i1-eth1 
Interface        Group           Source          Timer Fwd Uptime  
l1-i1-eth1       225.1.1.2       *               00:12   Y 04:37:55
l1-i1-eth1       225.1.1.1       *               00:13   Y 04:37:55
l1-i1-eth1       225.1.1.3       *               00:12   Y 04:37:55
l1-i1-eth1       225.1.1.5       *               00:11   Y 04:37:55
l1-i1-eth1       225.1.1.4       *               00:11   Y 04:37:55

l1# show ip igmp sources l1-i1-eth1 225.1.1.4 
Interface        Group           Source          Timer Fwd Uptime  
l1-i1-eth1       225.1.1.4       *               00:10   Y 04:37:58

l1# show ip igmp vrf red groups 
Specified VRF: red does not exist

l1# show ip igmp vrf red groups json 
{
}

l1# show ip igmp vrf red sources 
Specified VRF: red does not exist

l1# show ip igmp vrf red sources json 
{
}

l1# show ip igmp vrf all groups 
VRF: default
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Srcs V Uptime  
l1-i1-eth1       225.1.1.2       ---- 00:00:13    1 2 04:39:11
l1-i1-eth1       225.1.1.1       ---- 00:00:13    1 2 04:39:11
l1-i1-eth1       225.1.1.3       ---- 00:00:10    1 2 04:39:11
l1-i1-eth1       225.1.1.5       ---- 00:00:09    1 2 04:39:11
l1-i1-eth1       225.1.1.4       ---- 00:00:13    1 2 04:39:11

l1# show ip igmp vrf all groups 225.1.1.1 
VRF: default
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Srcs V Uptime  
l1-i1-eth1       225.1.1.1       ---- 00:00:10    1 2 04:39:49

l1# show ip igmp vrf all groups 225.1.1.1 detail 
VRF: default
Total IGMP groups: 5
Watermark warn limit(Not Set): 0
Interface        Group           Mode Timer    Source          V Uptime  
l1-i1-eth1       225.1.1.1       ---- 00:00:07 *               2 04:39:52

l1# show ip igmp vrf all groups 225.1.1.1 json 
{  "default": {
  "totalGroups":5,
  "watermarkLimit":0,
  "l1-i1-eth1":{
    "name":"l1-i1-eth1",
    "state":"up",
    "address":"10.0.8.2",
    "index":18,
    "flagMulticast":true,
    "flagBroadcast":true,
    "lanDelayEnabled":true,
    "groups":[
      {
        "group":"225.1.1.1",
        "timer":"00:00:10",
        "sourcesCount":1,
        "version":2,
        "uptime":"04:39:57"
      }
    ]
  }
}
}

l1# show ip igmp vrf all groups 225.1.1.1 detail json 
{  "default": {
  "totalGroups":5,
  "watermarkLimit":0,
  "l1-i1-eth1":{
    "name":"l1-i1-eth1",
    "state":"up",
    "address":"10.0.8.2",
    "index":18,
    "flagMulticast":true,
    "flagBroadcast":true,
    "lanDelayEnabled":true,
    "groups":[
      {
        "group":"225.1.1.1",
        "timer":"00:00:11",
        "sourcesCount":1,
        "version":2,
        "uptime":"04:40:04",
        "sources":[
          {
            "source":"*",
            "timer":"00:11",
            "forwarded":true,
            "uptime":"04:40:04"
          }
        ]
      }
    ]
  }
}
}
l1#

NetDEF-CI · 2023-04-01T06:19:20Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10553/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

<stdin>:10: trailing whitespace.
   
warning: 1 line adds whitespace errors.
Report for pim_cmd.c | 8 issues
===============================================
< WARNING: unnecessary whitespace before a quoted newline
< #1009: FILE: /tmp/f1-529954/pim_cmd.c:1009:
< WARNING: unnecessary whitespace before a quoted newline
< #1080: FILE: /tmp/f1-529954/pim_cmd.c:1080:
< WARNING: unnecessary whitespace before a quoted newline
< #1083: FILE: /tmp/f1-529954/pim_cmd.c:1083:
< WARNING: unnecessary whitespace before a quoted newline
< #1343: FILE: /tmp/f1-529954/pim_cmd.c:1343:

Jafaral · 2023-04-02T20:08:07Z

@Pdoijode can you please fix these :

<stdin>:10: trailing whitespace.
   
warning: 1 line adds whitespace errors.
Report for pim_cmd.c | 8 issues
===============================================
< WARNING: unnecessary whitespace before a quoted newline
< #1009: FILE: /tmp/f1-529954/pim_cmd.c:1009:
< WARNING: unnecessary whitespace before a quoted newline
< #1080: FILE: /tmp/f1-529954/pim_cmd.c:1080:
< WARNING: unnecessary whitespace before a quoted newline
< #1083: FILE: /tmp/f1-529954/pim_cmd.c:1083:
< WARNING: unnecessary whitespace before a quoted newline
< #1343: FILE: /tmp/f1-529954/pim_cmd.c:1343:

NetDEF-CI · 2023-04-03T20:32:52Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log found

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/artifact/TOPO9U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/artifact/TOPO9U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 4
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 3
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 6
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 3
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 8

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log found

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/artifact/TOPO9U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10602/artifact/TOPO9U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 9: No useful log found

<stdin>:10: trailing whitespace.
   
warning: 1 line adds whitespace errors.
Report for pim_cmd.c | 8 issues
===============================================
< WARNING: unnecessary whitespace before a quoted newline
< #1009: FILE: /tmp/f1-1646953/pim_cmd.c:1009:
< WARNING: unnecessary whitespace before a quoted newline
< #1080: FILE: /tmp/f1-1646953/pim_cmd.c:1080:
< WARNING: unnecessary whitespace before a quoted newline
< #1083: FILE: /tmp/f1-1646953/pim_cmd.c:1083:
< WARNING: unnecessary whitespace before a quoted newline
< #1343: FILE: /tmp/f1-1646953/pim_cmd.c:1343:

NetDEF-CI · 2023-04-04T00:38:27Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10607/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

<stdin>:10: trailing whitespace.
   
warning: 1 line adds whitespace errors.
Report for pim_cmd.c | 8 issues
===============================================
< WARNING: unnecessary whitespace before a quoted newline
< #1009: FILE: /tmp/f1-3139345/pim_cmd.c:1009:
< WARNING: unnecessary whitespace before a quoted newline
< #1080: FILE: /tmp/f1-3139345/pim_cmd.c:1080:
< WARNING: unnecessary whitespace before a quoted newline
< #1083: FILE: /tmp/f1-3139345/pim_cmd.c:1083:
< WARNING: unnecessary whitespace before a quoted newline
< #1343: FILE: /tmp/f1-3139345/pim_cmd.c:1343:

NetDEF-CI · 2023-04-04T03:58:47Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10608/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Jafaral · 2023-04-04T18:41:18Z

@Pdoijode in addition to a topotest, since this add JSON output, it also needs to come with a yang schema that matches the output of the json command.

@pushpasis , any further comments ?

chiragshah6 · 2023-04-05T02:24:25Z

@Pdoijode in addition to a topotest, since this add JSON output, it also needs to come with a yang schema that matches the output of the json command.

@pushpasis , any further comments ?

@Jafaral this is enhancing existing igmp json command to fetch per interface base json data. We will plan to have complete igmp group operational yang om in distance future. For now our goal is to get json queries to have all attributes and specific attribute base (all interfaces and specific interface) so when yang om is defined they are consistent.

Jafaral · 2023-04-05T16:40:34Z

@chiragshah6 that works. Let us just make sure this is covered by a new or existing topotest and I will merge.

NetDEF-CI · 2023-04-08T02:08:58Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10726/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Pdoijode · 2023-04-10T17:49:17Z

Added topotest.

NetDEF-CI · 2023-04-10T20:39:37Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10763/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-10763/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10763/artifact/TOPO8U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10763/artifact/TOPO8U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-10763/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10763/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10763/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10763/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests debian 10 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-10763/test

Topology Tests failed for Topotests debian 10 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10763/artifact/TOPO8DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10763/artifact/TOPO8DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Ubuntu 20.04 deb pkg check
Debian 9 deb pkg check
Debian 10 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 7
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 7
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5

NetDEF-CI · 2023-04-11T00:27:02Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10770/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Jafaral · 2023-04-11T15:54:57Z

@Pdoijode , some style issues in the new topotest, otherwise good to go.

1. Added interface name, group address and detail option to existing "show ip igmp groups" so that user can retrieve all the groups or a particular group for an interface. Detail option shows the source information for the group. With that, the show command looks like: "show ip igmp [vrf NAME$vrf_name] groups [INTERFACE$ifname [GROUP$grp_str]] [detail$detail] [json$json]" 2. Changed pim_cmd_lookup_vrf() to return empty JSON if VRF is not present 3. Changed "detail" option to print non pretty JSON 4. Added interface name and group address to existing "show ip igmp sources" so that user can retrieve all the sources for all the groups or, all the sorces for a particular group for an interface. With that, the show command looks like: "show ip igmp [vrf NAME$vrf_name] sourcess [INTERFACE$ifname [GROUP$grp_str]] [json$json]" Signed-off-by: Pooja Jagadeesh Doijode <pdoijode@nvidia.com>

Pdoijode · 2023-04-11T18:10:36Z

Fixed style errors in topotest.

NetDEF-CI · 2023-04-11T21:30:51Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10801/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2023-04-11T22:05:08Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10803/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10803/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10803/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10803/artifact/TOPO9DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 3
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check

Pdoijode · 2023-04-11T22:27:09Z

Unrelated failure in test_ospf_asbr_summary_topo1. Re-running CI.

Pdoijode · 2023-04-11T22:27:27Z

ci:rerun

NetDEF-CI · 2023-04-12T01:12:11Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10814/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

frrbot bot added the pim label Mar 31, 2023

github-actions bot added master size/XL labels Mar 31, 2023

Pdoijode force-pushed the pdoijode/pim-json-changes branch from 7162ee1 to bce41f2 Compare April 3, 2023 17:35

Pdoijode force-pushed the pdoijode/pim-json-changes branch from bce41f2 to 6b68d27 Compare April 3, 2023 21:55

Pdoijode force-pushed the pdoijode/pim-json-changes branch from 6b68d27 to 9808698 Compare April 4, 2023 00:55

Pdoijode force-pushed the pdoijode/pim-json-changes branch from e35274f to 4c64cb3 Compare April 10, 2023 17:47

Pdoijode force-pushed the pdoijode/pim-json-changes branch from 4c64cb3 to 7c7c47a Compare April 10, 2023 21:36

Pdoijode force-pushed the pdoijode/pim-json-changes branch from 7c7c47a to 6199c25 Compare April 11, 2023 17:12

Pdoijode force-pushed the pdoijode/pim-json-changes branch from 6199c25 to 5519cab Compare April 11, 2023 18:09

Jafaral merged commit 7a29a05 into FRRouting:master Apr 12, 2023

pimd: Option to get IGMP groups and sources for a particular interface #13183

pimd: Option to get IGMP groups and sources for a particular interface #13183

Conversation

Pdoijode commented Mar 31, 2023

NetDEF-CI commented Apr 1, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Jafaral commented Apr 2, 2023

NetDEF-CI commented Apr 3, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 4, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Apr 4, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

Jafaral commented Apr 4, 2023

chiragshah6 commented Apr 5, 2023

Jafaral commented Apr 5, 2023

NetDEF-CI commented Apr 8, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

Pdoijode commented Apr 10, 2023

NetDEF-CI commented Apr 10, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Apr 11, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

Jafaral commented Apr 11, 2023

Pdoijode commented Apr 11, 2023

NetDEF-CI commented Apr 11, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Apr 11, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Pdoijode commented Apr 11, 2023

Pdoijode commented Apr 11, 2023

NetDEF-CI commented Apr 12, 2023

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Apr 1, 2023 •

edited

Loading

NetDEF-CI commented Apr 3, 2023 •

edited

Loading

NetDEF-CI commented Apr 4, 2023 •

edited

Loading

NetDEF-CI commented Apr 4, 2023 •

edited

Loading

NetDEF-CI commented Apr 8, 2023 •

edited

Loading

NetDEF-CI commented Apr 10, 2023 •

edited

Loading

NetDEF-CI commented Apr 11, 2023 •

edited

Loading

NetDEF-CI commented Apr 11, 2023 •

edited

Loading

NetDEF-CI commented Apr 11, 2023 •

edited

Loading