isisd: Add support for log-pdu-drops #13163
Conversation
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-10495/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Topotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10495/artifact/TOPO6DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10495/artifact/TOPO6DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 6: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-10495/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Topotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10495/artifact/TOPO6DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10495/artifact/TOPO6DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 6: No useful log found |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10494/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10494/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10494/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10494/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log found |
|
ci:rerun |
isabelladeleon12
force-pushed
the
isis_log_drops
branch
from
8fbe57c to
9aa2123
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10528/artifact/TOPO6DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10528/artifact/TOPO6DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 6: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10528/test Topology Tests failed for Topotests debian 10 amd64 part 9 Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10528/artifact/TOPO6DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10528/artifact/TOPO6DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 6: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10528/test Topology Tests failed for Topotests debian 10 amd64 part 9 |
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-10529/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Topotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10529/artifact/TOPO6DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10529/artifact/TOPO6DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 6: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10537/artifact/TP1U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-10537/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1 Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-10537/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7 Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-10537/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10551/test Topology Tests failed for Topotests debian 10 amd64 part 9 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-10600/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-10605/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1 Successful on other platforms/tests
|
|
failure in bfd rather than is-is ... doesn't seem related ... rerunning |
New config functionality: r1# conf r1(config)# router isis 1 r1(config-router)# log- log-adjacency-changes Log changes in adjacency state log-pdu-drops Log any dropped PDUs r1(config-router)# log-pdu-drops r1(config-router)# end Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
If log-pdu-drops is configured, create an INFO log that displays the PDU type and drop counts when a PDU drop is detected. Example logs: 2023/03/30 23:54:59.749 ISIS: [VAS9N-1JNNR] PDU drop detected of type: P2P IIH. 1 Total Drops; 0 L1 IIH drops; 0 L2 IIH drops; 1 P2P IIH drops; 0 L1 LSP drops; 0 L2 LSP drops; 0 FS LSP drops; 0 L1 CSNP drops; 0 L2 CSNP drops; 0 L1 PSNP drops; 0 L2 PSNP drops. 2023/03/30 23:54:59.848 ISIS: [VAS9N-1JNNR] PDU drop detected of type: P2P IIH. 2 Total Drops; 0 L1 IIH drops; 0 L2 IIH drops; 2 P2P IIH drops; 0 L1 LSP drops; 0 L2 LSP drops; 0 FS LSP drops; 0 L1 CSNP drops; 0 L2 CSNP drops; 0 L1 PSNP drops; 0 L2 PSNP drops. Code changes: Add a new PDU counter function that increments the drop counter and runs the logging functionality if log-pdu-drops is configured. Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
isabelladeleon12
force-pushed
the
isis_log_drops
branch
from
9aa2123 to
86e468e
Compare
Update isisd docs with log-pdu-drops config. Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
isabelladeleon12
force-pushed
the
isis_log_drops
branch
from
86e468e to
bb6ef34
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10635/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10635/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10647/ This is a comment from an automated CI system. |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10646/artifact/TOPO6U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10646/artifact/TOPO6U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10646/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10646/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundSuccessful on other platforms/tests
|
Add a new isisd config "log-pdu-drops". If log-pdu-drops is configured, create an INFO log that displays the PDU type and drop counts when a PDU drop is detected.
New config functionality:
If log-pdu-drops is configured, create an INFO log that displays the PDU type and drop counts when a PDU drop occurs.
If log-pdu-drops is not configured, do not create a log when a PDU drop occurs.