Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Use a struct prefix *p instead of a struct prefix in functions #13162

Merged
merged 1 commit into from
Apr 7, 2023
Merged

*: Use a struct prefix *p instead of a struct prefix in functions #13162

merged 1 commit into from
Apr 7, 2023

Conversation

donaldsharp
Copy link
Member

When passing a prefix into a function let's pass by address instead of pass by value. Let's save our stack space.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Mar 30, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found
Successful on other platforms/tests
  • Debian 9 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 arm7 build
  • Debian 10 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 16.04 arm7 build
  • Debian 11 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 i386 build
  • OpenBSD 7 amd64 build
  • CentOS 7 amd64 build
  • Redhat 8 amd64 build

@donaldsharp
Copy link
Member Author

ci:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 3, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/TP4U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-10491/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-10491/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10491/artifact/TOPO7U18I386/TopotestDetails/

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 2
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 1

riw777
riw777 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Apr 4, 2023

ci failure is in cease notification ... doesn't seem related ... rerunning
ci:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 4, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:52: error: incompatible type for argument 2 of ls_find_subnet
 1080 |                 subnet = ls_find_subnet(args->ted, *prefix);
In file included from isisd/isis_te.c:31:
./lib/link_state.h:712:62: note: expected const struct prefix * but argument is of type struct prefix
make[1]: *** [Makefile:10466: isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:52: error: incompatible type for argument 2 of ls_find_subnet

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/RH9BUILD/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
make[1]: *** [Makefile:10466: isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst:: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI101BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c: In function 'lsp_to_subnet_cb':
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of 'ls_find_subnet'
 1080 |   subnet = ls_find_subnet(args->ted, *prefix);
In file included from isisd/isis_te.c:31:
./lib/link_state.h:712:27: note: expected 'const struct prefix *' but argument is of type 'const struct prefix'
gmake[1]: *** [Makefile:10468: isisd/isis_te.o] Error 1
isisd/isis_te.c: In function 'lsp_to_subnet_cb':
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of 'ls_find_subnet'
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst:: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst:: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
 1080 |   subnet = ls_find_subnet(args->ted, *prefix);
In file included from isisd/isis_te.c:31:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
make[1]: *** [Makefile:10466: isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U2004AMD64BUILD/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c:1080:38: error: passing 'const struct prefix' to parameter of incompatible type 'const struct prefix *'; remove *
./lib/link_state.h:712:27: note: passing argument to parameter 'prefix' here
1 error generated.
gmake[1]: *** [Makefile:10468: isisd/isis_te.o] Error 1
isisd/isis_te.c:1080:38: error: passing 'const struct prefix' to parameter of incompatible type 'const struct prefix *'; remove *
./lib/link_state.h:712:27: note: passing argument to parameter 'prefix' here
1 error generated.
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst:: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI005BUILD/ErrorLog/log_make.txt)

pimd/pim_cmd_common.c:4880:2: warning: missing braces around initializer [-Wmissing-braces]
pimd/pim_cmd_common.c:4880:2: warning: (near initialization for sg.grp) [-Wmissing-braces]
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       mgmtd/mgmt.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.10634/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.10634/frr-source/doc/user/nexthop_groups.rst
/home/ci/cibuild.10634/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.10634/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.10634/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.10634/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.10634/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
make[1]: *** [Makefile:10465: isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/REDHAT8/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst:: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:52: error: incompatible type for argument 2 of ls_find_subnet
 1080 |                 subnet = ls_find_subnet(args->ted, *prefix);
In file included from isisd/isis_te.c:31:
./lib/link_state.h:712:62: note: expected const struct prefix * but argument is of type struct prefix
make[1]: *** [Makefile:10469: isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:52: error: incompatible type for argument 2 of ls_find_subnet

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c: In function 'lsp_to_subnet_cb':
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of 'ls_find_subnet'
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected 'const struct prefix *' but argument is of type 'const struct prefix'
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
gmake[1]: *** [Makefile:10465: isisd/isis_te.o] Error 1
isisd/isis_te.c: In function 'lsp_to_subnet_cb':
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of 'ls_find_subnet'
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.10634/frr-source'
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
 1080 |   subnet = ls_find_subnet(args->ted, *prefix);
In file included from isisd/isis_te.c:31:
./lib/link_state.h:712:27: note: expected const struct prefix * but argument is of type const struct prefix
make[1]: *** [Makefile:10469: isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/DEB11AMD64/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10634/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
isisd/isis_te.c: In function lsp_to_subnet_cb:
isisd/isis_te.c:1080:38: error: incompatible type for argument 2 of ls_find_subnet
In file included from isisd/isis_te.c:31:0:
./lib/link_state.h:711:26: note: expected const struct prefix * but argument is of type const struct prefix
 extern struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
Makefile:9784: recipe for target 'isisd/isis_te.o' failed
make[1]: *** [isisd/isis_te.o] Error 1
isisd/isis_te.c: In function lsp_to_subnet_cb:

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10634/artifact/U18ARM8BUILD/config.status/config.status

@donaldsharp
*: Use a struct prefix *p instead of a struct prefix in functions
b589466 
When passing a prefix into a function let's pass by address instead
of pass by value.  Let's save our stack space.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@donaldsharp donaldsharp force-pushed the pass_by_value_no_no_no branch from 54817d7 to b589466 Compare April 6, 2023 22:00
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10699/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

ton31337
ton31337 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ton31337 ton31337 merged commit 0633fb7 into FRRouting:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
master size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donaldsharp @NetDEF-CI @riw777 @ton31337