ospfd: write socket per interface #13159
Conversation
|
I see no need for a knob. I have no problem with making ospf have a fd per interface as a default |
|
interesting - that is a comment that I didn't anticipate! let's see if there are other opinions out there ...
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-10485/test Topology Tests failed for Topotests debian 10 amd64 part 7 Successful on other platforms/tests
|
|
I agree with @donaldsharp. This is a welcomed change, I see no reason to complicate it with extra configs, less is more! |
|
CI failure in isis? try a rerun... |
|
CI:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10527/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10527/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundSuccessful on other platforms/tests
|
|
bgp failure, not running says the log? trying again... |
|
CI:rerun |
|
@frrbot rereview |
|
Doh - left off a signed-off line, fixed |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10539/ This is a comment from an automated CI system. |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10541/ This is a comment from an automated CI system. |
I agree with this ... and if you pull the command, we don't need a topo test here, since existing tests should catch any problems |
|
Changed so that this is enabled by default, and reversed the sense of the cli so that the change can be disabled if necessary. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-10651/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10681/ This is a comment from an automated CI system. |
mjstapp
force-pushed
the
ospf_sockets
branch
2 times, most recently
from
0f71e34 to
7ff87b9
Compare
|
caught a cli logic oops, pushed a fix... |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10692/ This is a comment from an automated CI system. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10693/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10693/test Topology Tests failed for Topotests debian 10 amd64 part 9 Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10722/test Topology Tests failed for Topotests debian 10 amd64 part 9 Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-10722/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7 Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-10722/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Successful on other platforms/tests
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Add support for a write socket per interface, enabled by default at the ospf instance level. An ospf instance-level config allows this to be disabled, reverting to the older behavior where a single per-instance socket is used for sending and receiving packets. Signed-off-by: Mark Stapp <mjs@labn.net>
Add a doc entry for the per-interface write socket config. Signed-off-by: Mark Stapp <mjs@labn.net>
|
Rebased and resolved conflicts |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10794/ This is a comment from an automated CI system. |
Modify ospfd to use a write socket per interface, instead of the current socket-per-instance. When multiple interfaces with different characteristics share a single socket (and its buffers), it's possible for slow or poor-performing destinations to block packets destined for other, better-performing destinations. With a socket per interface, fewer neighbors share fate.
This is enabled by default, on a per-instance basis. A new cli is available to revert to the original, socket - per - instance behavior if necessary.
I haven't added a specific test, since ... it's enabled all the time.