bgpd: trim long neighbor description with no whitespace #13139
Conversation
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10438/ This is a comment from an automated CI system. |
There was a problem hiding this comment.
Thanks for the patch, LGTM, but can you fix the commit message and include all the details inside the commit and add a Signed-off tag. More information in our guidelines: https://github.com/FRRouting/frr/blob/master/doc/developer/workflow.rst#submitting-patches-and-enhancements
|
@Mergifyio backport stable/8.5 |
✅ Backports have been created
|
Fix for missing neighbor description in "show bgp summary [wide]" when its length exceeds 20[64] chars and it doesn't contain withespaces. Existing behavior remains if description contains whitespaces before size limit. Signed-off-by: rbarroetavena <rbarroetavena@gmail.com>
|
@ton31337 Hope it's ok now. Thanks! |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10486/artifact/TOPO6DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10486/artifact/TOPO6DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 6: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10486/ This is a comment from an automated CI system. |
bgpd: trim long neighbor description with no whitespace (backport #13139)
We use neighbor descriptions with len > 20 and usually no whitespaces.
But since 64541ff,
sh ip bgp summaryshows nothing becauselast_space== 0.It'd be helpful trimming configured neighbor description instead of showing blank if its len > 20 and contains no whitespaces. Same stands if description len goes above 64 using wide mode.
Thanks for the help