Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pim6d: mroutes not created after disabling and enabling PIMv6. #13097

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

AbhishekNR
Copy link
Contributor

After doing "no ipv6 pim" and "ipv6 pim" on receiver interface in LHR, mroutes were not created.

When we enable pim after disabling it, we refresh the membership on interface. First we clear the membership on the interface, then we add it back. For PIMv6 we were only clearing it, membership was not added back. So mroutes were not created.

Now added code to fetch all the local membership information into PIM.

Fixes: #12005, #12820

After doing "no ipv6 pim" and "ipv6 pim" on receiver interface in LHR,
mroutes were not created.

When we enable pim after disabling it, we refresh the membership on pim interface.
First we clear the membership on the interface, then we add it back.
For PIMv6 we were only clearing it, membership was not added back. So mroutes were not created.

Now added code to fetch all the local membership information into PIM.

Fixes: FRRouting#12005, FRRouting#12820

Signed-off-by: Abhishek N R <abnr@vmware.com>
@mobash-rasool mobash-rasool changed the title pim6d: Fixing mroutes not created after disabling and enabling PIMv6. pim6d: mroutes not created after disabling and enabling PIMv6. Mar 24, 2023
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10357/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@AbhishekNR AbhishekNR marked this pull request as ready for review March 24, 2023 08:27
Copy link
Contributor

@mobash-rasool mobash-rasool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donaldsharp donaldsharp merged commit 635d65e into FRRouting:master Apr 13, 2023
@donaldsharp
Copy link
Member

@Mergifyio backport stable/8.5

@mergify
Copy link

mergify bot commented Apr 13, 2023

backport stable/8.5

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIMv6: After removing and adding PIMv6 config on receiver interface , mroutes not created
5 participants