-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: add cli command to control explicit-null label usage #13090
Conversation
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10345/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a topotest and documentation changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: does zebra install this (for forwarding) as you expect?
edbbcab
to
2a2a9e9
Compare
added |
yep. please see test. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-10358/test Topology Tests failed for Topotests debian 10 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TOPO4U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TP4U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-10358/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-10358/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TOPO4U18I386/TopotestLogs/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-10358/test Topology Tests failed for Topotests debian 10 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TOPO4U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TP4U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-10358/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-10358/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10358/artifact/TOPO4U18I386/TopotestLogs/log_topotests.txt
|
2a2a9e9
to
d5b04f4
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TOPO4U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-10361/test Topology Tests failed for Topotests debian 10 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-10361/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TOPO4U18I386/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TP4U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-10361/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TOPO4U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-10361/test Topology Tests failed for Topotests debian 10 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-10361/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TOPO4U18I386/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TP4U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-10361/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10361/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt
|
d5b04f4
to
39e672b
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-10373/test Topology Tests failed for Topotests debian 10 amd64 part 8 Addresssanitizer topotests part 7: Incomplete(check logs for details)Successful on other platforms/tests
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 amd64 part 5: Incomplete(check logs for details)Addresssanitizer topotests part 3: Incomplete(check logs for details)Successful on other platforms/tests
|
39e672b
to
e2c430c
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 4: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-10385/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Successful on other platforms/tests
|
ci:rerun |
doc/user/bgp.rst
Outdated
*bgpd* supports labeled information, as per :rfc:`3107`. By default, locally | ||
advertised prefixes use the `implicit-null` label to encode in the outgoing | ||
NLRI. The following command uses the `explicit-null` label value for all | ||
the BGP instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instances?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
doc/user/bgp.rst
Outdated
|
||
*bgpd* supports labeled information, as per :rfc:`3107`. By default, locally | ||
advertised prefixes use the `implicit-null` label to encode in the outgoing | ||
NLRI. The following command uses the `explicit-null` label value for all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we need this definition under the bgp labeled-unicast explicit-null
command, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved By default ... for all..
under the command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some doc changes, and LGTM despite that.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 amd64 part 2: Incomplete(check logs for details)Successful on other platforms/tests
|
e2c430c
to
229a35e
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 amd64 part 1: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10403/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
|
229a35e
to
30fdb07
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 amd64 part 1: Incomplete(check logs for details)Addresssanitizer topotests part 5: Incomplete(check logs for details)Successful on other platforms/tests
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-10411/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Topotests Ubuntu 18.04 arm8 part 0: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 6: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 6: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 8: Incomplete(check logs for details)Addresssanitizer topotests part 4: Incomplete(check logs for details)Addresssanitizer topotests part 5: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 2: Incomplete(check logs for details)Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10411/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
|
@frrbot rereview |
@pguibert6WIND could you fix CI additional warnings before merging? |
30fdb07
to
7af14cb
Compare
done |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10601/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
|
@pguibert6WIND CI warnings still exist (at least 100% for trailing comments tag). |
7af14cb
to
788960c
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 18.04 arm8 build: Failed (click for details)Make failed for Ubuntu 18.04 arm8 build:
Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz> Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
Ubuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U2004AMD64BUILD/config.log/config.log.gzMake failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Failed (click for details)Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U1804PPC64LEBUILD/config.status/config.statusMake failed for Ubuntu 18.04 ppc64le build:
Ubuntu 22.04 amd64 build: Failed (click for details)Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U22AMD64BUILD/config.log/config.log.gzMake failed for Ubuntu 22.04 amd64 build:
Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U22AMD64BUILD/config.status/config.status Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/DEB10BUILD/config.status/config.statusMake failed for Debian 10 amd64 build:
Debian 10 amd64 build: Unknown Log <config.log.gz> Ubuntu 18.04 arm7 build: Failed (click for details)Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U18ARM7BUILD/config.log/config.log.gzMake failed for Ubuntu 18.04 arm7 build:
Redhat 9 amd64 build: Failed (click for details)Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/RH9BUILD/config.status/config.statusMake failed for Redhat 9 amd64 build:
Redhat 9 amd64 build: Unknown Log <config.log.gz> Ubuntu 16.04 arm7 build: Failed (click for details)Make failed for Ubuntu 16.04 arm7 build:
Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz> Ubuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/CI009BUILD/config.status/config.statusMake failed for FreeBSD 11 amd64 build:
Debian 11 amd64 build: Failed (click for details)Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/DEB11AMD64/config.log/config.log.gzMake failed for Debian 11 amd64 build:
Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/DEB11AMD64/config.status/config.status FreeBSD 12 amd64 build: Failed (click for details)FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/FBSD12AMD64/config.status/config.statusMake failed for FreeBSD 12 amd64 build:
Ubuntu 16.04 arm8 build: Failed (click for details)Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U16ARM8BUILD/config.log/config.log.gzMake failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
Redhat 8 amd64 build: Failed (click for details)Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/REDHAT8/config.status/config.statusMake failed for Redhat 8 amd64 build:
Redhat 8 amd64 build: Unknown Log <config.log.gz> Ubuntu 18.04 i386 build: Failed (click for details)Make failed for Ubuntu 18.04 i386 build:
Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10780/artifact/U18I386BUILD/config.status/config.status Successful on other platforms/tests
|
In BGP labeled unicast address-family, it is not possible to send explicit-null label values with redistributed or network declared prefixes. A new CLI command is introduced: > [no] bgp labeled-unicast explicit-null When used, the explicit-null value for IPv4 ('0' value) or IPv6 ('2' value) will be used. It is necessary to reconfigure the networks or the redistribution in order to inherit this new behaviour. Add the documentation. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
The test ensures that the incoming prefixes are received with the appropriate label value, and that connectivity is ensured between prefixes. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
788960c
to
eee086e
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18I386-10793/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5 Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10793/ This is a comment from an automated CI system. |
In BGP labeled unicast address-family, it is not possible to send explicit-null label values with redistributed or network declared prefixes.
A new CLI command is introduced:
When used, the explicit-null value for IPv4 ('0' value) or IPv6 ('2' value) will be used.
It is necessary to reconfigure the networks or the redistribution in order to inherit this new behaviour.