Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Allow overriding default distance if set to 0 #13054

Closed
wants to merge 1 commit into from
Closed

bgpd: Allow overriding default distance if set to 0 #13054

wants to merge 1 commit into from

Conversation

ton31337
Copy link
Member

No description provided.

@frrbot frrbot bot added the bgp label Mar 20, 2023
@donaldsharp
Copy link
Member

I'm not a fan of allowing routing protocols to set values to 0.

@ton31337
bgpd: Allow overriding default distance if set to 0
c778382 
`set distance` with route-maps allow setting it to zero. Relax zebra to
use distance as 0 as well.

Or imagine a case when you have a static kernel route with distance 0, but
you need to override it from BGP with 0 distance as well.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@ton31337 ton31337 force-pushed the fix/bgp_distance_0 branch from 6acf5c8 to c778382 Compare March 20, 2023 14:03
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Mar 20, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO4U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 4: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO4U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TP1U1804AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TP1U1804AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 1: No useful log found
Topotests debian 10 amd64 part 2: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2DEB10AMD64-10260/test

Topology Tests failed for Topotests debian 10 amd64 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO2DEB10AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO6U18AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO3U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests debian 10 amd64 part 1: Failed (click for details) Topotests debian 10 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO1DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO1DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 1: No useful log found
Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-10260/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO3DEB10AMD64/TopotestDetails/

Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-10260/test

Topology Tests failed for Topotests debian 10 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2U18ARM8-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO2U18ARM8/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 arm8 part 2: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO2U18ARM8/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO6U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO6U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO1U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO1U18I386/TopotestDetails/

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-10260/test

Topology Tests failed for Topotests debian 10 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO6DEB10AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 2: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2U18I386-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO2U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 2: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO2U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 3: Failed (click for details) Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP2U1804AMD64-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TP2U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO4U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10260/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TP3U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-10260/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10260/artifact/TP3U1804AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 1
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 8
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 6
  • Addresssanitizer topotests part 5
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 5
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 7
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 8
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 8
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 0

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10263/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@riw777 riw777 self-requested a review March 21, 2023 14:22
riw777
riw777 reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks okay ... I don't know about the wisdom of implementing this, though ... we probably need to discuss a bit?

@eqvinox
Copy link
Contributor

eqvinox commented Mar 21, 2023

Community meeting consensus is that we're not super happy with this; it would be significantly better to get whatever else (DHCP?) to install routes into the kernel with a higher metric, and we look at the metric (@donaldsharp suggested high byte) and get the distance from there

@ton31337 ton31337 closed this Mar 21, 2023
@ton31337 ton31337 deleted the fix/bgp_distance_0 branch March 21, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 left review comments

Assignees
No one assigned
Labels
bgp master size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ton31337 @donaldsharp @NetDEF-CI @eqvinox @riw777