Vtysh fork #13004
Vtysh fork #13004
Conversation
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10173/ This is a comment from an automated CI system. |
|
My original comment about putting this in the init script was from the perspective that this is primarily an issue at startup. I've since come to the conclusion that it very much is also a problem during operation, and as such my comments from the other issue are moot. (Need to give this another look-over for a ✔️) |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10372/artifact/TOPO6U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-10372/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Successful on other platforms/tests
|
When using -b flag to apply config to all running daemons, fork a copy of vtysh for each daemon we need to configure instead of doing them one at a time. This is about N times faster when you have N daemons. Signed-off-by: Quentin Young <qlyoung@nvidia.com> mergeme
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
To handle multi-instance daemons (ospf, e.g.), each forked vtysh handles all of the instances of a daemon type. Signed-off-by: Mark Stapp <mstapp@nvidia.com>
It was being used for -b only; we should be able to use it for -f as well. This also merges the codepaths for -b and -f since they have no real functional difference. Signed-off-by: Quentin Young <qlyoung@nvidia.com>
vtysh -f forks. Gather the return codes and report the first failed return code. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 6: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 0: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 1: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 6: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 6: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 8: Incomplete(check logs for details)Addresssanitizer topotests part 4: Incomplete(check logs for details)Addresssanitizer topotests part 5: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 3: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 2: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 5: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10413/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10413/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Incomplete(check logs for details)Addresssanitizer topotests part 9: Incomplete(check logs for details)Addresssanitizer topotests part 3: Incomplete(check logs for details)Successful on other platforms/tests
|
|
ci:rerun ci is messed up again |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-10435/test Topology Tests failed for Topotests debian 10 amd64 part 8 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10444/ This is a comment from an automated CI system. |
This is PR #9621 . except it's been updated to fix the topotests as well as the merge conflicts. I just did not want to figure out how to force push to a branch I don't own.
I don't really see any unresolved discussions, and this has been running internally for well over a year now as well as this brings down config file read in significantly. Can we get this in?