Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isisd: Flex-Algo for SR-MPLS #12944

Closed
wants to merge 41 commits into from
Closed

isisd: Flex-Algo for SR-MPLS #12944

wants to merge 41 commits into from

Conversation

louis-6wind
Copy link
Contributor

Identical to #11667 but without modifications to the link-state library for the moment

@louis-6wind louis-6wind requested a review from odd22 March 3, 2023 11:10
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Mar 3, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10024/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-10024/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10024/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-10024/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10024/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10024/artifact/TOPO7U18I386/TopotestDetails/

Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-10024/test

Topology Tests failed for Topotests debian 10 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10024/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-10024/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10024/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10024/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 5
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 8
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests debian 10 amd64 part 2
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 1
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Ubuntu 18.04 deb pkg check
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 5
  • Ubuntu 16.04 deb pkg check
  • Topotests debian 10 amd64 part 8
  • Addresssanitizer topotests part 0
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 9
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 3

@louis-6wind louis-6wind marked this pull request as draft March 3, 2023 15:51
@riw777 riw777 self-requested a review March 7, 2023 14:32
slankdev and others added 17 commits March 13, 2023 16:39
@slankdev @louis-6wind
isisd: update struct isis_spftree with algorithm id
c3b9fdb 
The spftree has a new property called algorithm
which is id used to identify the algorithm that
separates it in the same IGP network. This is
used in Flex-Algo. In other cases than Flex-Algo,
the algorithm id is always zero.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: update struct sr_prefix_cfg with algorithm id
6182917 
The information in prefix-sid has a new property
called algorithm id.  This is used to identify
the algorithm that separates it in the same IGP
network. This is used in Flex-Algo.In all other
cases, the algorithm id is basically 0.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: update struct isis_sr_psid_info with algorithm id
f3fa04c 
The information in prefix-sid has a new property
called algorithm id.  This is used to identify
the algorithm that separates it in the same IGP
network. This is used in Flex-Algo.In all other
cases, the algorithm id is basically 0.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
lib,isisd: refactor igp-agnostic sr misc functions
3ce85f4 
SR Algorithms are independent of specific IGPs
such as IS-IS. This commit adds lib/sr to
aggregate IGP agnostic functions and constants.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: update SR_ALGORITHM_COUNT to 256
8876bae 
Before this commit, SR_ALGORITHM_COUNT was set to 2,
and each was hardcoded with router capability tlv.
When Flex-Algo is supported, SR-Algorithm may be
variably supported up to 256.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: update isis_tlvs_add_*_reach() with multi algorithm
c15354f 
isis_tlvs_add_extended_ip_reach adds IS-IS Extended
IP reachability to the LSP. In this case, if the
pcfg argument is not NULL, you can add IGP
Prefix-SID as its sub tlv.

Before this commit, only one Prefix-SID can be added.
After this commit, the argument is not a single
pointer but an array of pointers, and multiple
Prefix-SIDs can be added.

This feature is necessary because Flex-Algo
requires multiple Prefix-SIDs for each Algorithm.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: refactor IP reachability lsp build
9623577 
Refactor IP reachability lsp build to comply with checkpatch:

> WARNING: Too many leading tabs - consider code refactoring

No code logic change.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: update struct isis_sr_psid_info with nh context
fa719b0 
Prefix-SID nexthops and backup nexthops are stored respectively in
isis_route_info->nexthops and isis_route_info->backup->nexthops.

With Flex-Algo, there are multiple Prefix-SIDs for a single prefix in
different algorithms. Each of these Prefix-SIDs performs SPF calculation
with a separate contract and sets a nexthops, so it is necessary to
store a different set nexthops for each Prefix-SID.

Add a nexthops and backup nethops list into the Prefix-SID
isis_sr_psid_info struct and use these lists instead of the  when needed

After this commit, the nexthops for each Prefix-SID is not
taken from route_info, but the nexthop set inside the
Prefix-SID is taken. This works for backup nexthops as well.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: update struct isis_route_info has multiple sr info by algorithm
0087a02 
Before this commit, there was only one sr psid info
included in route_info.

In fact, in RFC8667, Algorithm ID, which is a property of
Prefix-SID, has 8 bits of information. That is, each Prefix
can hold up to 256 Prefix-SIDs. This commit implements it.
The previously implemented single Prefix-SID will be
continued as Algorithm 0.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: refactor enum tail comma
8aba38a 
Many of the enum definitions defined in isis_tlvs.h
are often extended at the end. The c/c++ allows
commas at the end of a list. This commit simplifies
the patching of later extensions.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: add TLV_SIZE_MISMATCH for tlvs length mismatch
64cb3cf 
Basically in frrouting source code principle,
the log string should not be a complicated abstraction
or streamlined for grep.

But for log format for the "TLV size does not match ..."
can be unified, which makes development easier.

> $ grep "TLV size does not match expected size for" isisd/isis_tlvs.c
>    "TLV size does not match expected size for Administrative Group!\n");
>    "TLV size does not match expected size for Local IPv6 address!\n");
>    ...(snip)...
>    "TLV size does not match expected size for Adjacency SID!\n");
>          "TLV size does not match expected size for Adjacency SID!\n");
>          "TLV size does not match expected size for Adjacency SID!\n");
>    "TLV size does not match expected size for LAN-Adjacency SID!\n");
>          "TLV size does not match expected size for LAN-Adjacency SID!\n");
>          "TLV size does not match expected size for LAN-Adjacency SID!\n");
>
> $ grep "TLV size does not match expected size for" isisd/isis_tlvs.c | wc -l
> 25

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd,yang: add algorithm-prefix-sid configuration tree
7cf7ef7 
Add the ability to configure a Segment-Routing prefix SID for a given
algorithm. For example:

> segment-routing prefix 10.10.10.10/32 algorithm 128 index 100

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: add cli to configure algorithm-prefix-sid
b1f7a17 
Add the ability to configure a Segment-Routing prefix SID for a given
algorithm. For example:

> segment-routing prefix 10.10.10.10/32 algorithm 128 index 100

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
lib: add library for igp flexible-algorithm
e31cd4d 
Add a library to deal with Flexible Algorithm that will be common to
IS-IS and OSPF. The functions enables to deal with:

- Affinity-maps
- Extended Admin Group (RFC7308)
- Flex-Algo structures that contains the flex-algo configurations

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
lib,vtysh,isisd,yang: algo cli/yang/callbacks
0f3be1e 
Define the IS-IS flex-algo structure in yang, the CLI configuration
commands and the skeletons of frontend and backend functions that are
called by the CLI code.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
lib: add a frr_each_const macro
7811d3f 
Add a frr_each_const macro equivalent to loop on const lists.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: add isis flex-algo base interface
8201ee3 
Adds basic functionality to Flex-Algo for IS-IS wrapping lib/flex_algo.
The configuration interface will be added in the next commit.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
slankdev and others added 24 commits March 13, 2023 16:40
@slankdev @louis-6wind
isisd: add isis flex-algo configuration backend
9b9c40a 
Add the backend functions for the flex-algo configuration.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: add isis flex-algo configuration frontend
93a0153 
Add the frontend functions for the flex-algo configuration.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: add ASLA support
99c1fe0 
Add the support of ASLA with the following TLV:

- Extended IS Reachability (already defined TLV 22)
        - Application-Specific Link Attributes (Sub-TLV 16)
          (to enable the Flex-Algo flag on a link)
                - Admin-group (Sub-Sub-TLV 3)
                - Extended Admin-group (Sub-Sub-TLV 14)

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: add isis flex-algo lsp advertisement
1f7d967 
Deal with the packing and unpacking of following Flex-Algo
Sub-Sub-TLVs:

- Router Capability (already defined TLV 242)
	- List of the Flex-Algo Definitions (Sub-TLV 26)
		- Exclude admin group (Sub-Sub-TLV 1)
                - Include-any admin group (Sub-Sub-TLV 2)
                - Include-all admin group (Sub-Sub-TLV 3)
                - Flags (for prefix-metric) (Sub-Sub-TLV 4)

This commit splits data into multiple router capability TLVs if needed
because a TLV cannot contains more than 255 bytes.

Note that the list of SR Algorithm (Sub-TLV 19) within Router Capability
(TLV 242) is already set in a previous commit.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: calculate flex-algo constraint spf
d01d2c7 
Take into account the flex-algo affinity constraints to compute the SPF
tree.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
isisd: merge algorithm tables
efdfb49 
Create a temporary "merge" route table that contains the routing
information from all algorithms and install the merge route table
into the FIB.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@eklabn @louis-6wind
isisd: fix merging flex-algo route nodes
932375f 
As isis_route_verify_merge() builds a new route table, each (src,dst)
new node in the table is created by merging data from the same (src,dst)
pair present in all route tables.  However, as it iterates over those
route nodes and copies SR data into the newly created node, it repeatedly
overwrites the isis_route_info pointer.  This, in turn, pollutes the
isis_route_info structures in all of the other tables with partially
updated SR data.

After a route is deleted, this leaves pointers to freed memory in one
of the route trees.

Fixes: 26b0598 ("isisd: fix isis_route_merge_verify logic")
Signed-off-by: Eric Kinzie <ekinzie@labn.net>
@louis-6wind
isisd: add support of (ti-)lfa to flex-algo
d0e2976 
Add support of (ti-)lfa to flex-algo

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: add affinity-map configuration hooks
46ced91 
Add affinity-map hooks to check the utilization of affinity-map in
flex-algo contexts before its deletion and to update local TLVs when the
affinity-map bit-position is updated.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: fix typo in indef fabricd comment
67137c1 
fix typo in indef fabricd comment

Fixes: 20bd27e ("isisd, yang: add configuration model and callback stubs")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: clarify ifdef fabricd
8852296 
clarify ifdef fabricd

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@eklabn @louis-6wind
lib: convert termtable to json
4a21891 
Add a function that returns a JSON-C structure containing a representation
of a termtable.  This is intended to be a quick way to implement JSON
output to CLI commands.

Signed-off-by: Eric Kinzie <ekinzie@labn.net>
@louis-6wind
isisd: show non-zero algos in "show isis route prefix-sid" (1/2)
3e00d8f 
Change the indentation to facilitate the reading of next commit.
No change on code.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@eklabn @louis-6wind
isisd: show non-zero algos in "show isis route prefix-sid" (2/2)
db74baf 
Show Prefix-SIDs and labels for all available Flex-Algos.

Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@eklabn @louis-6wind
isisd: add option to display isis routes as json
99cfba0 
Append an optional parameter to "show isis route [prefix-sid]" that
formats the output as a JSON array.

Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: add flex-algo info to spf extreme debug
2676775 
Add flex-algo information ID to the SPF extreme debug mode.

Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: add an algorithm argument to show isis topology
1db035e 
Add an optional algorithm argument to "show isis topology" command.

Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: add an algorithm argument to show isis route
1e0c6a4 
Add an optional algorithm argument to "show isis route" command.

Signed-off-by: Eric Kinzie <ekinzie@labn.net>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: add algorithm argument to show isis segment-routing node
17f9331 
Add algorithm argument to show isis segment-routing node

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
isisd: add "show isis flex-algo" command
153cb70 
Add the show isis flex-algo command to display the elected Flex-Algo
definitions and states (enabled/disabled).

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
tests: add isis_sr_flex_algo_topo1 for flex-algo
f73c447 
Add a topotest to check some Flex-Algo configuration changes.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@slankdev @louis-6wind
tests: add isis_sr_flex_algo_topo2 for flex-algo
7b53f2c 
Add a topotest with 9 flex-algo routers to check each router's MPLS
table.

Signed-off-by: Hiroki Shirokura <hiroki.shirokura@linecorp.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
doc: fix debugging-isis reference
7a3ce9d 
Debugging-isis tag was moved.

Move it to right place.

Fixes: 9389175 ("doc: add documentation for IS-IS Segment Routing")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
doc: add isisd flex-algo documentation
65b3484 
Add the isisd flex-algo documentation

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind louis-6wind force-pushed the flexalgo-mpls-noliblinkstate branch from b6b3023 to 65b3484 Compare March 13, 2023 15:40
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10133/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:8964: new blank line at EOF.
+
<stdin>:9616: new blank line at EOF.
+
<stdin>:10268: new blank line at EOF.
+
<stdin>:10909: new blank line at EOF.
+
<stdin>:11497: new blank line at EOF.
+
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
Report for isis_cli.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2109: FILE: /tmp/f1-3430991/isis_cli.c:2109:
Report for isis_nb.c | 90 issues
===============================================
< WARNING: line over 80 characters
< #109: FILE: /tmp/f1-3430991/isis_nb.c:109:
< WARNING: line over 80 characters
< #127: FILE: /tmp/f1-3430991/isis_nb.c:127:
< WARNING: line over 80 characters
< #701: FILE: /tmp/f1-3430991/isis_nb.c:701:
< WARNING: line over 80 characters
< #702: FILE: /tmp/f1-3430991/isis_nb.c:702:
< WARNING: line over 80 characters
< #703: FILE: /tmp/f1-3430991/isis_nb.c:703:
< WARNING: line over 80 characters
< #704: FILE: /tmp/f1-3430991/isis_nb.c:704:
< WARNING: line over 80 characters
< #709: FILE: /tmp/f1-3430991/isis_nb.c:709:
< WARNING: line over 80 characters
< #711: FILE: /tmp/f1-3430991/isis_nb.c:711:
< WARNING: line over 80 characters
< #715: FILE: /tmp/f1-3430991/isis_nb.c:715:
< WARNING: line over 80 characters
< #717: FILE: /tmp/f1-3430991/isis_nb.c:717:
< WARNING: line over 80 characters
< #721: FILE: /tmp/f1-3430991/isis_nb.c:721:
< WARNING: line over 80 characters
< #723: FILE: /tmp/f1-3430991/isis_nb.c:723:
< WARNING: line over 80 characters
< #727: FILE: /tmp/f1-3430991/isis_nb.c:727:
< WARNING: line over 80 characters
< #729: FILE: /tmp/f1-3430991/isis_nb.c:729:
< WARNING: line over 80 characters
< #733: FILE: /tmp/f1-3430991/isis_nb.c:733:
< WARNING: line over 80 characters
< #742: FILE: /tmp/f1-3430991/isis_nb.c:742:
< WARNING: line over 80 characters
< #744: FILE: /tmp/f1-3430991/isis_nb.c:744:
< WARNING: line over 80 characters
< #745: FILE: /tmp/f1-3430991/isis_nb.c:745:
< WARNING: line over 80 characters
< #749: FILE: /tmp/f1-3430991/isis_nb.c:749:
< WARNING: line over 80 characters
< #751: FILE: /tmp/f1-3430991/isis_nb.c:751:
< WARNING: line over 80 characters
< #752: FILE: /tmp/f1-3430991/isis_nb.c:752:
< WARNING: line over 80 characters
< #756: FILE: /tmp/f1-3430991/isis_nb.c:756:
< WARNING: line over 80 characters
< #758: FILE: /tmp/f1-3430991/isis_nb.c:758:
< WARNING: line over 80 characters
< #759: FILE: /tmp/f1-3430991/isis_nb.c:759:
< WARNING: line over 80 characters
< #763: FILE: /tmp/f1-3430991/isis_nb.c:763:
< WARNING: line over 80 characters
< #765: FILE: /tmp/f1-3430991/isis_nb.c:765:
< WARNING: line over 80 characters
< #766: FILE: /tmp/f1-3430991/isis_nb.c:766:
< WARNING: line over 80 characters
< #770: FILE: /tmp/f1-3430991/isis_nb.c:770:
< WARNING: line over 80 characters
< #772: FILE: /tmp/f1-3430991/isis_nb.c:772:
< WARNING: line over 80 characters
< #773: FILE: /tmp/f1-3430991/isis_nb.c:773:
< WARNING: line over 80 characters
< #777: FILE: /tmp/f1-3430991/isis_nb.c:777:
< WARNING: line over 80 characters
< #779: FILE: /tmp/f1-3430991/isis_nb.c:779:
< WARNING: line over 80 characters
< #783: FILE: /tmp/f1-3430991/isis_nb.c:783:
< WARNING: line over 80 characters
< #785: FILE: /tmp/f1-3430991/isis_nb.c:785:
< WARNING: line over 80 characters
< #786: FILE: /tmp/f1-3430991/isis_nb.c:786:
< WARNING: line over 80 characters
< #790: FILE: /tmp/f1-3430991/isis_nb.c:790:
< WARNING: line over 80 characters
< #792: FILE: /tmp/f1-3430991/isis_nb.c:792:
< WARNING: line over 80 characters
< #793: FILE: /tmp/f1-3430991/isis_nb.c:793:
< WARNING: line over 80 characters
< #797: FILE: /tmp/f1-3430991/isis_nb.c:797:
< WARNING: line over 80 characters
< #799: FILE: /tmp/f1-3430991/isis_nb.c:799:
< WARNING: line over 80 characters
< #800: FILE: /tmp/f1-3430991/isis_nb.c:800:
< WARNING: line over 80 characters
< #804: FILE: /tmp/f1-3430991/isis_nb.c:804:
< WARNING: line over 80 characters
< #806: FILE: /tmp/f1-3430991/isis_nb.c:806:
< WARNING: line over 80 characters
< #807: FILE: /tmp/f1-3430991/isis_nb.c:807:
< WARNING: line over 80 characters
< #819: FILE: /tmp/f1-3430991/isis_nb.c:819:
Report for isis_nb_config.c | 14 issues
===============================================
< WARNING: line over 80 characters
< #2679: FILE: /tmp/f1-3430991/isis_nb_config.c:2679:
< WARNING: line over 80 characters
< #2697: FILE: /tmp/f1-3430991/isis_nb_config.c:2697:
< WARNING: line over 80 characters
< #2715: FILE: /tmp/f1-3430991/isis_nb_config.c:2715:
< WARNING: line over 80 characters
< #2991: FILE: /tmp/f1-3430991/isis_nb_config.c:2991:
< WARNING: line over 80 characters
< #3008: FILE: /tmp/f1-3430991/isis_nb_config.c:3008:
< WARNING: line over 80 characters
< #3025: FILE: /tmp/f1-3430991/isis_nb_config.c:3025:
< WARNING: line over 80 characters
< #4200: FILE: /tmp/f1-3430991/isis_nb_config.c:4200:
Report for isis_route.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #859: FILE: /tmp/f1-3430991/isis_route.c:859:
Report for isis_spf.c | 8 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2686: FILE: /tmp/f1-3430991/isis_spf.c:2686:
< WARNING: line over 80 characters
< #2688: FILE: /tmp/f1-3430991/isis_spf.c:2688:
< WARNING: line over 80 characters
< #2693: FILE: /tmp/f1-3430991/isis_spf.c:2693:
< WARNING: line over 80 characters
< #2763: FILE: /tmp/f1-3430991/isis_spf.c:2763:
Report for isis_tlvs.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #499: FILE: /tmp/f1-3430991/isis_tlvs.c:499:

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odd22 odd22 Awaiting requested review from odd22

@riw777 riw777 Awaiting requested review from riw777

Assignees
No one assigned
Labels
bugfix conflicts documentation isis libfrr master size/XXL tests Topotests, make check, etc vtysh yang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@louis-6wind @NetDEF-CI @slankdev @eklabn