zebra: Fix other table inactive when ip import-table is on

[imzyxwvu]

In rib_link, if is_zebra_import_table_enabled returns true, rib_queue_add will not called, resulting in other table route node never processed. This actually should not be dependent on whether the route is imported.

In rib_delnode, if is_zebra_import_table_enabled returns true, it will use rib_unlink instead of enqueuing the route node for process. There is no reason that imported route nodes should not be reprocessed. Long ago, the behaviour was dependent on whether the route_entry comes from a table other than main.

[donaldsharp]

can you give me a series of ip routeadd|delete that show the problem you are fixing? I am not sure I follow the ocmmit message

[imzyxwvu]

Hi @donaldsharp ,

Here is the problem I originally encountered:

The config with ip import-table 10 set:

devbox-debian# show running-config 
Building configuration...

Current configuration:
!
frr version 9.0-dev
frr defaults traditional
hostname devbox-debian
ip import-table 10
!
end

If I do ip route replace table 10 1.2.3.4/32 dev ens33 to add a route to table 10, here is the show ip route table 10 output:

devbox-debian# show ip route table 10
Codes: K - kernel route, C - connected, S - static, R - RIP,
       B - BGP, E - EIGRP, T - Table, v - VNC, V - VNC-Direct,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure

VRF default table 10:
K   1.2.3.4/32 [0/0] is directly connected, ens33 inactive, 00:00:05

As you could see, ens33 nexthop is inactive. It is not inactive if I do not set ip import-table 10.

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9715/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-9715/test

Topology Tests failed for Topotests debian 10 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9715/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-9715/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9715/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9715/artifact/TOPO9U18I386/TopotestDetails/

Successful on other platforms/tests

• Topotests Ubuntu 18.04 arm8 part 3
• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 amd64 part 2
• Addresssanitizer topotests part 4
• Topotests debian 10 amd64 part 3
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 8
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 arm8 part 9
• Topotests Ubuntu 18.04 amd64 part 3
• Static analyzer (clang)
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 arm8 part 7
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests debian 10 amd64 part 2
• Addresssanitizer topotests part 9
• Ubuntu 16.04 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 arm8 part 5
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 amd64 part 9
• Addresssanitizer topotests part 7
• Ubuntu 20.04 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 5
• Debian 10 deb pkg check
• Fedora 29 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 0
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 i386 part 5
• Topotests Ubuntu 18.04 amd64 part 4
• CentOS 7 rpm pkg check
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests debian 10 amd64 part 5
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests debian 10 amd64 part 7
• Debian 9 deb pkg check
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 8
• Ubuntu 18.04 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 6
• Topotests Ubuntu 18.04 i386 part 2
• Addresssanitizer topotests part 6
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 arm8 part 1

[donaldsharp]

ci:rerun

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9741/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

[donaldsharp]

@Mergifyio backport stable/8.4 dev/8.5

[mergify]

backport stable/8.4 dev/8.5

✅ Backports have been created

• #12858 zebra: Fix other table inactive when ip import-table is on (backport #12818) has been created for branch stable/8.4
• #12859 zebra: Fix other table inactive when ip import-table is on (backport #12818) has been created for branch dev/8.5