tests: Enhance error msgs for static route automation. #12816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9712/ This is a comment from an automated CI system. |
ton31337
requested changes
Feb 15, 2023
tests/topotests/static_routing_with_ebgp/test_static_routes_topo1_ebgp.py
Outdated
Show resolved
Hide resolved
| @@ -448,7 +448,7 @@ def test_static_route_2nh_p0_tc_1_ebgp(request): | |||
| ) | |||
| assert ( | |||
| result is not True | |||
| ), "Testcase {} : Failed \nError: Route is" " still present in RIB".format( | |||
| ), "Testcase {} : Failed \nExpected: Routes should not present in RIB \nError: Route is" " still present in RIB".format( | |||
There was a problem hiding this comment.
Same as above Route is " " .. looks weird.
tests/topotests/static_routing_with_ebgp/test_static_routes_topo1_ebgp.py
Outdated
Show resolved
Hide resolved
| @@ -516,7 +516,7 @@ def test_static_route_2nh_p0_tc_1_ebgp(request): | |||
| ) | |||
| assert ( | |||
| result is not True | |||
| ), "Testcase {} : Failed \nError: Route is" " still present in RIB".format( | |||
| ), "Testcase {} : Failed \nExpected: Routes should not present in RIB \nError: Route is" " still present in RIB".format( | |||
tests/topotests/static_routing_with_ebgp/test_static_routes_topo1_ebgp.py
Outdated
Show resolved
Hide resolved
| @@ -583,7 +583,7 @@ def test_static_route_2nh_p0_tc_1_ebgp(request): | |||
| ) | |||
| assert ( | |||
| result is not True | |||
| ), "Testcase {} : Failed \nError: Route is" " still present in RIB".format( | |||
| ), "Testcase {} : Failed \nExpected: Routes should not present in RIB \nError: Route is" " still present in RIB".format( | |||
tests/topotests/static_routing_with_ebgp/test_static_routes_topo1_ebgp.py
Outdated
Show resolved
Hide resolved
| @@ -778,7 +778,7 @@ def test_static_route_2nh_admin_dist_p0_tc_2_ebgp(request): | |||
| ) | |||
| assert ( | |||
| result is not True | |||
| ), "Testcase {} : Failed \nError: Routes is" "missing in RIB".format(tc_name) | |||
| ), "Testcase {} : Failed \nExpected: Routes should not present in RIB \nError: Routes is" "missing in RIB".format(tc_name) | |||
riw777
reviewed
Feb 21, 2023
tests/topotests/static_routing_with_ebgp/test_static_routes_topo1_ebgp.py
Outdated
Show resolved
Hide resolved
tests: Enhance error messages for static route automation.
Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
gpnaveen
force-pushed
the
stc_rte_err_msg
branch
from
a65f6e0 to
1155a66
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 3: Failed (click for details)Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10072/artifact/TOPO3U18I386/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-10072/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3 Successful on other platforms/tests
|
|
ci: rerun, un related test failed. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10125/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nguggarigoud nguggarigoud@vmware.com