Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pim6d: Modify "show ipv6 mld join json" o/p #12776

Merged
merged 1 commit into from
Feb 10, 2023
Merged

pim6d: Modify "show ipv6 mld join json" o/p #12776

merged 1 commit into from
Feb 10, 2023

Conversation

patrasar
Copy link
Contributor

@patrasar patrasar commented Feb 9, 2023 •
edited
Loading

Currently "show ipv6 mld join json" o/p is
{
"default":{
"ens192":{
"ff02:2":{
"::":{
"state":"JOIN",
"created":"00:01:50.595",
"lastSeen":"00:00:38.403",
}
}
}
}
}

Here, I modified the o/p as below for better understanding. {
{
"default":{
"vrf":"default",
"ens192":{
"ff02::2":{
"*":{
"state":"JOIN",
"created":"00:00:42.766",
"lastSeen":"00:00:05.266"
}
}
}
}
}

Issue: #12755

Signed-off-by: Sarita Patra saritap@vmware.com

@patrasar patrasar marked this pull request as ready for review February 9, 2023 06:48
mobash-rasool
mobash-rasool requested changes Feb 9, 2023
View reviewed changes
@github-actions github-actions bot added size/XS and removed size/S labels Feb 9, 2023
@patrasar patrasar marked this pull request as draft February 9, 2023 07:23
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 9, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9595/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-9595/test

Topology Tests failed for Topotests debian 10 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9595/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 2
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-9595/test

Topology Tests failed for Topotests debian 10 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9595/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt

Report for pim6_mld.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2803: FILE: /tmp/f1-2266814/pim6_mld.c:2803:

@patrasar
pim6d: Modify "show ipv6 mld join json" o/p
58971e1 
Currently "show ipv6 mld join json" o/p is
frr# show ipv6 mld joins json
{
  "default":{
    "ens192":{
      "ff02:2":{
        "::":{
          "state":"JOIN",
          "created":"00:01:50.595",
          "lastSeen":"00:00:38.403",
        }
      }
    }
  }
}

Here, I modified the o/p as below for better understanding.
frr# show ipv6 mld joins json
{
  "default":{
    "vrf":"default",
    "ens192":{
      "ff02::2":{
        "*":{
          "state":"JOIN",
          "created":"00:00:42.766",
          "lastSeen":"00:00:05.266"
        }
      }
    }
  }
}

Issue: FRRouting#12755

Signed-off-by: Sarita Patra <saritap@vmware.com>
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 9, 2023 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9596/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for pim6_mld.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2800: FILE: /tmp/f1-2630832/pim6_mld.c:2800:

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9597/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@mobash-rasool mobash-rasool marked this pull request as ready for review February 9, 2023 12:22
@donaldsharp
Copy link
Member

@Mergifyio backport dev/8.5

@mergify
Copy link

mergify bot commented Feb 10, 2023 •
edited
Loading

backport dev/8.5

✅ Backports have been created

@donaldsharp donaldsharp merged commit 7809df2 into FRRouting:master Feb 10, 2023
@mergify mergify bot mentioned this pull request Feb 10, 2023
Merged
Jafaral added a commit that referenced this pull request Feb 10, 2023
@Jafaral
Merge pull request #12788 from FRRouting/mergify/bp/dev/8.5/pr-12776
a5ee9bf 
pim6d: Modify "show ipv6 mld join json" o/p (backport #12776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mobash-rasool mobash-rasool mobash-rasool approved these changes

Assignees
No one assigned
Labels
backport master pimv6 size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrasar @NetDEF-CI @donaldsharp @mobash-rasool