bgpd: bgp_update and bgp_withdraw never return failures

[donaldsharp]

These two functions always return 0. As such any and all tests against this make no sense. Remove the return 0 to a void and follow the chain, logically, to remove all the dead code.

Signed-off-by: Donald Sharp sharpd@nvidia.com

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9457/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_route.c | 4 issues
===============================================
< WARNING: void function return statements are not generally useful
< #4901: FILE: /tmp/f1-2922519/bgp_route.c:4901:
< WARNING: void function return statements are not generally useful
< #4995: FILE: /tmp/f1-2922519/bgp_route.c:4995:

[ton31337]

LGTM