Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isisd/Lib: Add new printfrr format facility for Intermediate System ID #12698

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

odd22
Copy link
Member

@odd22 odd22 commented Jan 26, 2023

In addition to ISISd, others daemons need to pretty print the IS-IS System ID and ISO Network Address. This PR adds a new format facility to printfrr for Intermediate System ID.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 26, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/REDHAT8/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM8BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI101BUILD/config.status/config.status

Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:755: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_received':
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:24: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'}
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_gen':
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:24: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'}
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/cspf.lo] Error 1
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/command_match.lo] Error 1

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB11AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_received':
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected 'const char *' but argument is of type 'const uint8_t * {aka const unsigned char *}'
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_gen':
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Successful on other platforms/tests
  • OpenBSD 7 amd64 build
  • CentOS 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/REDHAT8/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM8BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI101BUILD/config.status/config.status

Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:755: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_received':
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:24: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'}
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_gen':
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:24: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'}
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9411/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9411/frr-source'
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/cspf.lo] Error 1
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/command_match.lo] Error 1

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/DEB11AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.9411/frr-source'
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_received':
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected 'const char *' but argument is of type 'const uint8_t * {aka const unsigned char *}'
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_gen':
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9411/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.9411/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_received:
isisd/isis_nb_notifications.c:421:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_lsp_gen:
isisd/isis_nb_notifications.c:451:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
Report for isis_adjacency.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #309: FILE: /tmp/f1-2232809/isis_adjacency.c:309:
Report for isis_circuit.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #712: FILE: /tmp/f1-2232809/isis_circuit.c:712:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#460: FILE: /tmp/f1-2232809/isis_misc.c:460:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f2-2232809/isis_misc.c:511:
35c39
< #487: FILE: /tmp/f1-2232809/isis_misc.c:487:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #879: FILE: /tmp/f1-2232809/isis_pdu.c:879:
Report for isis_snmp.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2550: FILE: /tmp/f1-2232809/isis_snmp.c:2550:
Report for isis_tlvs.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1717: FILE: /tmp/f1-2232809/isis_tlvs.c:1717:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1951: FILE: /tmp/f1-2232809/link_state.c:1951:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 27, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI101BUILD/config.status/config.status

Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/RH9BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1604I386/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/cspf.lo] Error 1
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/command_match.lo] Error 1

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/usr/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_error':
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:24: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'}
isisd/isis_nb_notifications.c: In function 'isis_notif_seqno_skipped':
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/usr/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_error':
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected 'const char *' but argument is of type 'const uint8_t * {aka const unsigned char *}'
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function 'isis_notif_seqno_skipped':
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/REDHAT8/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/REDHAT8/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U22AMD64BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/F29BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Successful on other platforms/tests
  • CentOS 7 amd64 build
  • OpenBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI101BUILD/config.status/config.status

Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/RH9BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1604I386/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/cspf.lo] Error 1
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/command_match.lo] Error 1

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/usr/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_error':
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:24: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'}
isisd/isis_nb_notifications.c: In function 'isis_notif_seqno_skipped':
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/usr/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function 'isis_notif_lsp_error':
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected 'const char *' but argument is of type 'const uint8_t * {aka const unsigned char *}'
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function 'isis_notif_seqno_skipped':
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of 'yang_data_new_string' differ in signedness [-Werror=pointer-sign]
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/REDHAT8/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/REDHAT8/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.9420/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:111:59: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:48: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U22AMD64BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/F29BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9420/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9420/frr-source'
/home/ci/cibuild.9420/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9420/frr-source/doc/user/nexthop_groups.rst
isisd/isis_nb_notifications.c: In function isis_notif_lsp_error:
isisd/isis_nb_notifications.c:539:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
In file included from ./lib/yang.h:30:0,
./lib/yang_wrappers.h:110:26: note: expected const char * but argument is of type const uint8_t * {aka const unsigned char *}
 extern struct yang_data *yang_data_new_string(const char *xpath,
isisd/isis_nb_notifications.c: In function isis_notif_seqno_skipped:
isisd/isis_nb_notifications.c:568:41: error: pointer targets in passing argument 2 of yang_data_new_string differ in signedness [-Werror=pointer-sign]
Report for isis_adjacency.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #309: FILE: /tmp/f1-880704/isis_adjacency.c:309:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#459: FILE: /tmp/f1-880704/isis_misc.c:459:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f2-880704/isis_misc.c:511:
35c39
< #486: FILE: /tmp/f1-880704/isis_misc.c:486:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #879: FILE: /tmp/f1-880704/isis_pdu.c:879:
Report for isis_snmp.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2550: FILE: /tmp/f1-880704/isis_snmp.c:2550:
Report for isis_tlvs.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1717: FILE: /tmp/f1-880704/isis_tlvs.c:1717:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1951: FILE: /tmp/f1-880704/link_state.c:1951:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 27, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9421/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9421/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9421/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9421/frr-source'
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/cspf.lo] Error 1
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/command_match.lo] Error 1

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9421/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 arm7 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 16.04 i386 build
  • Redhat 9 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 i386 build
  • Redhat 8 amd64 build
  • OpenBSD 7 amd64 build
  • Ubuntu 22.04 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Fedora 29 amd64 build
  • Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9421/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9421/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9421/frr-source'
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298: error: ignoring #pragma FRR printffr_ext [-Werror=unknown-pragmas]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/cspf.lo] Error 1
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10267: lib/command_match.lo] Error 1

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9421/artifact/DEB11AMD64/config.status/config.status

Report for isis_adjacency.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #309: FILE: /tmp/f1-995517/isis_adjacency.c:309:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#459: FILE: /tmp/f1-995517/isis_misc.c:459:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f2-995517/isis_misc.c:511:
35c39
< #486: FILE: /tmp/f1-995517/isis_misc.c:486:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #879: FILE: /tmp/f1-995517/isis_pdu.c:879:
Report for isis_snmp.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2550: FILE: /tmp/f1-995517/isis_snmp.c:2550:
Report for isis_tlvs.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1717: FILE: /tmp/f1-995517/isis_tlvs.c:1717:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1951: FILE: /tmp/f1-995517/link_state.c:1951:

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, but JSON output should use also %pIS (json_object_string_addf()).

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 27, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9423/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9423/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9423/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9423/frr-source'
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298:43: error: #pragma FRR printfrr_ext: unexpected identifier.  Note the only supported qualifier is const
make[1]: *** [Makefile:10267: lib/command_match.lo] Error 1
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298:43: error: #pragma FRR printfrr_ext: unexpected identifier.  Note the only supported qualifier is const
make[1]: *** [Makefile:10267: lib/cspf.lo] Error 1
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298:43: error: #pragma FRR printfrr_ext: unexpected identifier.  Note the only supported qualifier is const

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9423/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 18.04 arm7 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 16.04 amd64 build
  • Redhat 9 amd64 build
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 22.04 amd64 build
  • Fedora 29 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 20.04 amd64 build
  • Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9423/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9423/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9423/frr-source'
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298:43: error: #pragma FRR printfrr_ext: unexpected identifier.  Note the only supported qualifier is const
make[1]: *** [Makefile:10267: lib/command_match.lo] Error 1
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298:43: error: #pragma FRR printfrr_ext: unexpected identifier.  Note the only supported qualifier is const
make[1]: *** [Makefile:10267: lib/cspf.lo] Error 1
In file included from ./lib/zlog.h:34,
./lib/printfrr.h:298:43: error: #pragma FRR printfrr_ext: unexpected identifier.  Note the only supported qualifier is const

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9423/artifact/DEB11AMD64/config.status/config.status

Report for isis_adjacency.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #309: FILE: /tmp/f1-1215146/isis_adjacency.c:309:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#459: FILE: /tmp/f1-1215146/isis_misc.c:459:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f2-1215146/isis_misc.c:511:
35c39
< #486: FILE: /tmp/f1-1215146/isis_misc.c:486:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #879: FILE: /tmp/f1-1215146/isis_pdu.c:879:
Report for isis_snmp.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2550: FILE: /tmp/f1-1215146/isis_snmp.c:2550:
Report for isis_tlvs.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1717: FILE: /tmp/f1-1215146/isis_tlvs.c:1717:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1951: FILE: /tmp/f1-1215146/link_state.c:1951:

@odd22
Copy link
Member Author

odd22 commented Jan 27, 2023

I update the patch following your review. As suggested by David, I search for equivalent JSON function in yang to avoid using an intermediate buffer with snprintfrr() function, but I don't find any. I could just add a new wrapper in yang_wrappers.c file. Do you think it will be useful ?

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 27, 2023

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9442/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for isis_adjacency.c | 4 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #309: FILE: /tmp/f1-3699877/isis_adjacency.c:309:
< ERROR: code indent should use tabs where possible
< #610: FILE: /tmp/f1-3699877/isis_adjacency.c:610:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#459: FILE: /tmp/f1-3699877/isis_misc.c:459:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f2-3699877/isis_misc.c:511:
35c39
< #486: FILE: /tmp/f1-3699877/isis_misc.c:486:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #879: FILE: /tmp/f1-3699877/isis_pdu.c:879:
Report for isis_snmp.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2550: FILE: /tmp/f1-3699877/isis_snmp.c:2550:
Report for isis_tlvs.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1717: FILE: /tmp/f1-3699877/isis_tlvs.c:1717:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1951: FILE: /tmp/f1-3699877/link_state.c:1951:

CLANG Static Analyzer Summary

  • Github Pull Request 12698, comparing to Git base SHA 2d59283
  • Base image data for Git 2d59283 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-9442/artifact/shared/static_analysis/index.html

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple more missing JSON conversions, and a new SA warning.

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good ... waiting on the comments by @ton31337, and it looks like the lint needs to be fixed

@odd22
Copy link
Member Author

odd22 commented Jan 31, 2023

Just correct json call according to Tony. Regarding the new SA warning, I don't really see the problem (except that the memory is not freed). But, I change the strdup call by a static buffer allocation in the isis_adj_name() function. Just let me know if it is OK for you and if I need to modify isisd_misc.c file to replace strdup() by a static buffer allocation too.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 31, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10247: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10621: isisd/libfabric_a-isisd.o] Error 1

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/REDHAT8/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10247: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10621: isisd/libfabric_a-isisd.o] Error 1
OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror,-Wunused-variable]
1 error generated.
gmake[1]: *** [Makefile:10250: isisd/isisd.o] Error 1
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror,-Wunused-variable]
1 error generated.
gmake[1]: *** [Makefile:10624: isisd/libfabric_a-isisd.o] Error 1
/home/ci/cibuild.9476/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10248: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10622: isisd/libfabric_a-isisd.o] Error 1

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10248: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U2004AMD64BUILD/config.status/config.status

Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:14: error: unused variable buf [-Werror=unused-variable]
 2359 |         char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10248: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:14: error: unused variable buf [-Werror=unused-variable]
 2359 |         char buf[SYS_ID_SIZE];

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function 'common_isis_summary_json':
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10250: isisd/isisd.o] Error 1
isisd/isisd.c: In function 'common_isis_summary_json':
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:14: error: unused variable buf [-Werror=unused-variable]
 2359 |         char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10251: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:14: error: unused variable buf [-Werror=unused-variable]
 2359 |         char buf[SYS_ID_SIZE];

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function 'common_isis_summary_json':
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror=unused-variable]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10247: isisd/isisd.o] Error 1
isisd/isisd.c: In function 'common_isis_summary_json':
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror=unused-variable]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10621: isisd/libfabric_a-isisd.o] Error 1
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM8BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10251: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • CentOS 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10247: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10621: isisd/libfabric_a-isisd.o] Error 1

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/REDHAT8/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10247: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10621: isisd/libfabric_a-isisd.o] Error 1
OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror,-Wunused-variable]
1 error generated.
gmake[1]: *** [Makefile:10250: isisd/isisd.o] Error 1
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror,-Wunused-variable]
1 error generated.
gmake[1]: *** [Makefile:10624: isisd/libfabric_a-isisd.o] Error 1
/home/ci/cibuild.9476/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10248: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10622: isisd/libfabric_a-isisd.o] Error 1

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10248: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U2004AMD64BUILD/config.status/config.status

Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:14: error: unused variable buf [-Werror=unused-variable]
 2359 |         char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10248: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:14: error: unused variable buf [-Werror=unused-variable]
 2359 |         char buf[SYS_ID_SIZE];

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function 'common_isis_summary_json':
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10250: isisd/isisd.o] Error 1
isisd/isisd.c: In function 'common_isis_summary_json':
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:14: error: unused variable buf [-Werror=unused-variable]
 2359 |         char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10251: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:14: error: unused variable buf [-Werror=unused-variable]
 2359 |         char buf[SYS_ID_SIZE];

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function 'common_isis_summary_json':
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror=unused-variable]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10247: isisd/isisd.o] Error 1
isisd/isisd.c: In function 'common_isis_summary_json':
isisd/isisd.c:2359:7: error: unused variable 'buf' [-Werror=unused-variable]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10621: isisd/libfabric_a-isisd.o] Error 1
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9476/frr-source/doc/user/nexthop_groups.rst
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U18ARM8BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.9476/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:9580: recipe for target 'isisd/isisd.o' failed
make[1]: *** [isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
cc1: all warnings being treated as errors
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9476/frr-source'
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10251: isisd/isisd.o] Error 1
isisd/isisd.c: In function common_isis_summary_json:
isisd/isisd.c:2359:7: error: unused variable buf [-Werror=unused-variable]
 2359 |  char buf[SYS_ID_SIZE];

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9476/artifact/DEB11AMD64/config.status/config.status

Report for isis_adjacency.c | 4 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #309: FILE: /tmp/f1-3124806/isis_adjacency.c:309:
< ERROR: code indent should use tabs where possible
< #610: FILE: /tmp/f1-3124806/isis_adjacency.c:610:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#459: FILE: /tmp/f1-3124806/isis_misc.c:459:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f2-3124806/isis_misc.c:511:
35c39
< #486: FILE: /tmp/f1-3124806/isis_misc.c:486:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #879: FILE: /tmp/f1-3124806/isis_pdu.c:879:
Report for isis_snmp.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2550: FILE: /tmp/f1-3124806/isis_snmp.c:2550:
Report for isis_tlvs.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1717: FILE: /tmp/f1-3124806/isis_tlvs.c:1717:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1951: FILE: /tmp/f1-3124806/link_state.c:1951:

Copy link
Contributor

@choppsv1 choppsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about area addresses? Those can be any number of bytes.

FWIW typically PNODE-IDs are as you say here:

AAAA.BBBB.CCCC.DD

But area addresses place the byte at the front. e.g.,

AA.BBBB.CCCC

@odd22
Copy link
Member Author

odd22 commented Jan 31, 2023

What about area addresses? Those can be any number of bytes.

FWIW typically PNODE-IDs are as you say here:

AAAA.BBBB.CCCC.DD

But area addresses place the byte at the front. e.g.,

AA.BBBB.CCCC

This case is not handle by this patch. As mention in the documentation it handles ISO system ID (%pIS), with Pseudo-ID (%pISl) and with Fragment ID (%pISll). For this kind of address, we need another format facility.

@choppsv1
Copy link
Contributor

Is there an advantage to using l and ll over specific format identifiers for each object type e.g.,., %pIS system ID %pPN pseudonode ID and %pLS LSP ID?

FWIW, It was the fact of reusing the same format ID (%pIS) for 3 different types that made me ask about area address.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 31, 2023

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9482/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for isis_adjacency.c | 4 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #309: FILE: /tmp/f1-215613/isis_adjacency.c:309:
< ERROR: code indent should use tabs where possible
< #610: FILE: /tmp/f1-215613/isis_adjacency.c:610:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#459: FILE: /tmp/f1-215613/isis_misc.c:459:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f2-215613/isis_misc.c:511:
35c39
< #486: FILE: /tmp/f1-215613/isis_misc.c:486:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #879: FILE: /tmp/f1-215613/isis_pdu.c:879:
Report for isis_snmp.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2550: FILE: /tmp/f1-215613/isis_snmp.c:2550:
Report for isis_tlvs.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1717: FILE: /tmp/f1-215613/isis_tlvs.c:1717:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1951: FILE: /tmp/f1-215613/link_state.c:1951:

@odd22
Copy link
Member Author

odd22 commented Feb 1, 2023

Is there an advantage to using l and ll over specific format identifiers for each object type e.g.,., %pIS system ID %pPN pseudonode ID and %pLS LSP ID?

FWIW, It was the fact of reusing the same format ID (%pIS) for 3 different types that made me ask about area address.

If you look to the patch, you'll find that I'm re-using old code i.e. isis_format_id() function for the new format facility. This function takes in argument the len of the pretty print to determine if it should print the SysID, alone, with the Pseudo ID or with the Fragment ID. Thus, I follow the same way and add the l and ll option to %pIS. But, I agree that we could split it and create %pPN and %pLS instead. Just let me know what is it preferable

@louis-6wind
Copy link
Contributor

louis-6wind commented Feb 2, 2023

What about area addresses? Those can be any number of bytes.
FWIW typically PNODE-IDs are as you say here:
AAAA.BBBB.CCCC.DD
But area addresses place the byte at the front. e.g.,
AA.BBBB.CCCC

This case is not handle by this patch. As mention in the documentation it handles ISO system ID (%pIS), with Pseudo-ID (%pISl) and with Fragment ID (%pISll). For this kind of address, we need another format facility.

Area address will be useful for https://www.rfc-editor.org/rfc/rfc7752.html#section-3.3.1.2

Currently, isonet_print() is used to display Area ID. However, Area-IDs have a length 2 to 13 bytes. Not sure there is a benefit to add something like : %pAR2, %pAR3 to %pAR13

@odd22 odd22 force-pushed the isisd branch 2 times, most recently from 46d019d to 828673e Compare February 23, 2023 14:46
@odd22
Copy link
Member Author

odd22 commented Feb 23, 2023

Sorry for the delay on this — here's my take…

No problem.

We have 2 distinct problems here. First is to have better printing/output functionality for IS-IS IDs of all types. Second is that we're using uint8_t * for most of them.

Agree

These 2 are distinct problems and we should tackle them separately.

So for this PR I would suggest to take on the first part only. Remove struct iso_address but keep it stashed away for another PR. Only do all the %pIS %pSY etc in this PR.

For the choice of %pXX specifiers — the primary purpose of using separate ones is to allow the frr-format to do type checks based on #pragma FRR printfrr_ext. That only works if the formats use different C types. So right now it does not provide a benefit. BUT — using different ones now will make it easier in the future to fix the second problem. So when we have a struct iso_system_id struct iso_pseudo_id struct iso_fragment_id they will match the different specifiers.

Also I think we should in fact use 3 different types for these IDs when we go about fixing part 2 of the problem here. Which is the deciding factor for using 3 "fully different" printf specifiers.

I update my PR accordingly to use the 3 %pXX proposed by Christian (in fact, I can not use the %pPS for Pseudo System ID as there is already a %PSG4 which conflict with it). This address the first part of the problem. I also address the second part within the same PR as, for me, it is not so decorrelated and @louis-6wind need both for its BGP-LS PR. But, as suggested, the second part of the problem is also addressed with a separate %pXX pattern. And as you mention, it will now easy to change the uint8_t * parameter type by a dedicated structure is needed.

I hope this new version will satisfy everybody

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 23, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9862/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9862/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9862/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9862/frr-source'
lib/link_state.c: In function ls_node_id_to_text:
lib/link_state.c:1969:28: error: unrecognized printf extension suffix [-Werror=format=]
 1969 |   snprintfrr(str, size, "%pIS", lnid.id.iso.sys_id);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10316: lib/link_state.lo] Error 1
/home/ci/cibuild.9862/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.9862/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.9862/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9862/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • Fedora 29 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 11 amd64 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 16.04 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 arm8 build

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 23, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9863/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9863/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9863/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9863/frr-source'
lib/link_state.c: In function ls_node_id_to_text:
lib/link_state.c:1969:28: error: unrecognized printf extension suffix [-Werror=format=]
 1969 |   snprintfrr(str, size, "%pIS", lnid.id.iso.sys_id);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10316: lib/link_state.lo] Error 1
/home/ci/cibuild.9863/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.9863/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.9863/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9863/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm7 build
  • FreeBSD 11 amd64 build
  • Ubuntu 22.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 20.04 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 arm7 build
  • Fedora 29 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 arm8 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9863/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9863/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9863/frr-source'
lib/link_state.c: In function ls_node_id_to_text:
lib/link_state.c:1969:28: error: unrecognized printf extension suffix [-Werror=format=]
 1969 |   snprintfrr(str, size, "%pIS", lnid.id.iso.sys_id);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10316: lib/link_state.lo] Error 1
/home/ci/cibuild.9863/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.9863/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.9863/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9863/artifact/DEB11AMD64/config.status/config.status

<stdin>:2061: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for isis_adjacency.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #296: FILE: /tmp/f1-1375853/isis_adjacency.c:296:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#410: FILE: /tmp/f1-1375853/isis_misc.c:410:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#498: FILE: /tmp/f2-1375853/isis_misc.c:498:
30c39
< #437: FILE: /tmp/f1-1375853/isis_misc.c:437:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #866: FILE: /tmp/f1-1375853/isis_pdu.c:866:
Report for isis_snmp.c | 2 issues
===============================================
< ERROR: do not initialise statics to 0
< #2493: FILE: /tmp/f1-1375853/isis_snmp.c:2493:
Report for isis_tlvs.c | 4 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1597: FILE: /tmp/f1-1375853/isis_tlvs.c:1597:
< WARNING: braces {} are not necessary for any arm of this statement
< #1768: FILE: /tmp/f1-1375853/isis_tlvs.c:1768:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1968: FILE: /tmp/f1-1375853/link_state.c:1968:

@odd22 odd22 force-pushed the isisd branch 2 times, most recently from 9111e99 to 8cee4d8 Compare February 23, 2023 15:36
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 23, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9865/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9865/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9865/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9865/frr-source'
lib/link_state.c: In function ls_node_id_to_text:
lib/link_state.c:1969:28: error: unrecognized printf extension suffix [-Werror=format=]
 1969 |   snprintfrr(str, size, "%pSY", lnid.id.iso.sys_id);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10316: lib/link_state.lo] Error 1
/home/ci/cibuild.9865/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.9865/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.9865/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9865/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Redhat 8 amd64 build
  • Redhat 9 amd64 build
  • OpenBSD 7 amd64 build
  • Debian 10 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 12 amd64 build
  • Fedora 29 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9866/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9866/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9866/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9866/frr-source'
lib/link_state.c: In function ls_node_id_to_text:
lib/link_state.c:1969:28: error: unrecognized printf extension suffix [-Werror=format=]
 1969 |   snprintfrr(str, size, "%pSY", lnid.id.iso.sys_id);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10316: lib/link_state.lo] Error 1
/home/ci/cibuild.9866/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.9866/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.9866/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9866/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Redhat 9 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 16.04 arm7 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • OpenBSD 7 amd64 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build
  • Redhat 8 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 12 amd64 build
  • Fedora 29 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9866/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9866/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9866/frr-source'
lib/link_state.c: In function ls_node_id_to_text:
lib/link_state.c:1969:28: error: unrecognized printf extension suffix [-Werror=format=]
 1969 |   snprintfrr(str, size, "%pSY", lnid.id.iso.sys_id);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10316: lib/link_state.lo] Error 1
/home/ci/cibuild.9866/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.9866/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.9866/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9866/artifact/DEB11AMD64/config.status/config.status

<stdin>:2061: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for isis_adjacency.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #296: FILE: /tmp/f1-1583836/isis_adjacency.c:296:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#410: FILE: /tmp/f1-1583836/isis_misc.c:410:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#498: FILE: /tmp/f2-1583836/isis_misc.c:498:
30c39
< #437: FILE: /tmp/f1-1583836/isis_misc.c:437:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #866: FILE: /tmp/f1-1583836/isis_pdu.c:866:
Report for isis_snmp.c | 2 issues
===============================================
< ERROR: do not initialise statics to 0
< #2493: FILE: /tmp/f1-1583836/isis_snmp.c:2493:
Report for isis_tlvs.c | 4 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1597: FILE: /tmp/f1-1583836/isis_tlvs.c:1597:
< WARNING: braces {} are not necessary for any arm of this statement
< #1768: FILE: /tmp/f1-1583836/isis_tlvs.c:1768:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1968: FILE: /tmp/f1-1583836/link_state.c:1968:

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9889/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9889/artifact/TOPO1U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 1: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 9
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 amd64 part 1
  • Addresssanitizer topotests part 6
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 0
  • Ubuntu 20.04 deb pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 5
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 9
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 4
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 3
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 9
  • Fedora 29 rpm pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9889/artifact/TOPO1U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 1: No useful log found
<stdin>:2061: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for isis_adjacency.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #296: FILE: /tmp/f1-76752/isis_adjacency.c:296:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#410: FILE: /tmp/f1-76752/isis_misc.c:410:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#498: FILE: /tmp/f2-76752/isis_misc.c:498:
30c39
< #437: FILE: /tmp/f1-76752/isis_misc.c:437:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #866: FILE: /tmp/f1-76752/isis_pdu.c:866:
Report for isis_snmp.c | 2 issues
===============================================
< ERROR: do not initialise statics to 0
< #2493: FILE: /tmp/f1-76752/isis_snmp.c:2493:
Report for isis_tlvs.c | 4 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1597: FILE: /tmp/f1-76752/isis_tlvs.c:1597:
< WARNING: braces {} are not necessary for any arm of this statement
< #1768: FILE: /tmp/f1-76752/isis_tlvs.c:1768:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1969: FILE: /tmp/f1-76752/link_state.c:1969:

@odd22
Copy link
Member Author

odd22 commented Feb 24, 2023

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9899/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-9899/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9899/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9899/artifact/TOPO9U18I386/TopotestDetails/

Successful on other platforms/tests
  • Addresssanitizer topotests part 6
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 0
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Ubuntu 18.04 deb pkg check
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 5
  • Topotests debian 10 amd64 part 4
  • Topotests debian 10 amd64 part 9
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 4
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-9899/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9899/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9899/artifact/TOPO9U18I386/TopotestDetails/

<stdin>:2061: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for isis_adjacency.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #296: FILE: /tmp/f1-1865730/isis_adjacency.c:296:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#410: FILE: /tmp/f1-1865730/isis_misc.c:410:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#498: FILE: /tmp/f2-1865730/isis_misc.c:498:
30c39
< #437: FILE: /tmp/f1-1865730/isis_misc.c:437:
Report for isis_pdu.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #866: FILE: /tmp/f1-1865730/isis_pdu.c:866:
Report for isis_snmp.c | 2 issues
===============================================
< ERROR: do not initialise statics to 0
< #2493: FILE: /tmp/f1-1865730/isis_snmp.c:2493:
Report for isis_tlvs.c | 4 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1597: FILE: /tmp/f1-1865730/isis_tlvs.c:1597:
< WARNING: braces {} are not necessary for any arm of this statement
< #1768: FILE: /tmp/f1-1865730/isis_tlvs.c:1768:
Report for link_state.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #1969: FILE: /tmp/f1-1865730/link_state.c:1969:

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9934/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
<stdin>:2092: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for isis_snmp.c | 2 issues
===============================================
< ERROR: do not initialise statics to 0
< #2493: FILE: /tmp/f1-1965608/isis_snmp.c:2493:

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ... waiting for others to clear their comments

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

odd22 added 2 commits March 21, 2023 15:19
Like for IP addresses, this patch add a new format for printfrr collection to
print ISO System ID and Network address a.k.a IS-IS system ID & Network.
This new format is added to the library instead of isisd because other daemons
and tools need to print ISO System ID & Network Address.

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
This path replaces isisd_format_id, sysid_print, snpa_print, rawlspid_print and
isonet_print functions by the new printfrr ISO System ID & Network Address
format facilities. It also updates the isisd code to the new iso_address
structure defined in lib/iso.h

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
@odd22
Copy link
Member Author

odd22 commented Mar 21, 2023

Just resolve the merge conflict

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10311/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-10311/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10311/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 6
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 5
  • Static analyzer (clang)
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-10311/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10311/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt

<stdin>:2092: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for isis_snmp.c | 2 issues
===============================================
< ERROR: do not initialise statics to 0
< #2496: FILE: /tmp/f1-3665169/isis_snmp.c:2496:

@choppsv1
Copy link
Contributor

choppsv1 commented Apr 1, 2023

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10562/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
<stdin>:2092: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for isis_snmp.c | 2 issues
===============================================
< ERROR: do not initialise statics to 0
< #2496: FILE: /tmp/f1-655690/isis_snmp.c:2496:

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ... is this ready to merge?

@odd22
Copy link
Member Author

odd22 commented Apr 4, 2023

looks good ... is this ready to merge?

@riw777 It is ready on my side

@riw777 riw777 merged commit f26a87c into FRRouting:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants