-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: evpn route detail json display non prett #12684
Conversation
For BGP evpn route table detail json to use non pretty form of display. Problem: In scaled evpn route table detail json dump occupies high resources (CPU + memory) of the system. In high scale evpn route dump using pretty form hogs CPU for a while which can trigger watchfrr to kill bgpd. Solution: Avoid pretty JSON print for detail version dump Signed-off-by: Chirag Shah <chirag@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this is just a temporary fix. Scale != scale, and it can be 3x the next day 😄
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18AMD64-9370/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5 Successful on other platforms/tests
|
Ack. but there is no need to have pretty format print for detail route output. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9370/ This is a comment from an automated CI system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
For BGP evpn route table detail JSON to use non pretty form of display.
Problem:
In scaled EVPN route table detail JSON dump occupies high resources (CPU + memory) of the system.
In high scale EVPN route dump using pretty form
hogs CPU for a while which can trigger watchfrr
to kill bgpd.
Solution:
Avoid pretty JSON print for detail version dump
Signed-off-by: Chirag Shah chirag@nvidia.com