Some various stuff #12522

donaldsharp · 2022-12-14T18:11:38Z

See individual commits, memory leaks to code cleanup to making topotests run faster

NetDEF-CI · 2022-12-14T19:41:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/FBSD12AMD64/frr.xref.xz/frr.xref.xz FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/FBSD12AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 12 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/FBSD12AMD64/ErrorLog/log_pytests.txt

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U16ARM8BUILD/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Ubuntu 16.04 arm8 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U16ARM8BUILD/ErrorLog/log_pytests.txt

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI014BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI014BUILD/ErrorLog/log_pytests.txt

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI005BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI005BUILD/ErrorLog/log_pytests.txt

Ubuntu 18.04 i386 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 18.04 i386 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18I386BUILD/ErrorLog/log_pytests.txt
Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18I386BUILD/config.log/config.log.gz
Ubuntu 18.04 i386 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM7BUILD/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Ubuntu 18.04 arm7 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM7BUILD/ErrorLog/log_pytests.txt

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz

DejaGNU Unittests (make check) failed for Ubuntu 18.04 arm8 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM8BUILD/ErrorLog/log_pytests.txt
Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM8BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1604I386/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 i386 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1604I386/ErrorLog/log_pytests.txt

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB11AMD64/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Debian 11 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB11AMD64/ErrorLog/log_pytests.txt
Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB11AMD64/config.status/config.status
Debian 11 amd64 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/REDHAT8/config.status/config.status

DejaGNU Unittests (make check) failed for Redhat 8 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/REDHAT8/ErrorLog/log_pytests.txt
Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/REDHAT8/config.log/config.log.gz
Redhat 8 amd64 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/REDHAT8/frr.xref.xz/frr.xref.xz

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/F29BUILD/frr.xref.xz/frr.xref.xz Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/F29BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Fedora 29 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/F29BUILD/ErrorLog/log_pytests.txt

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI011BUILD/frr.xref.xz/frr.xref.xz OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI011BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for OpenBSD 7 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI011BUILD/ErrorLog/log_pytests.txt

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB10BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 10 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB10BUILD/ErrorLog/log_pytests.txt
Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI021BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 9 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI021BUILD/ErrorLog/log_pytests.txt

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/RH9BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Redhat 9 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/RH9BUILD/ErrorLog/log_pytests.txt
Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/RH9BUILD/config.log/config.log.gz
Redhat 9 amd64 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/RH9BUILD/frr.xref.xz/frr.xref.xz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U2004AMD64BUILD/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Ubuntu 20.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U2004AMD64BUILD/ErrorLog/log_pytests.txt
Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz

DejaGNU Unittests (make check) failed for Ubuntu 16.04 arm7 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI101BUILD/ErrorLog/log_pytests.txt
Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804PPC64LEBUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 ppc64le build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804PPC64LEBUILD/ErrorLog/log_pytests.txt

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804AMD64/ErrorLog/log_pytests.txt

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U22AMD64BUILD/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Ubuntu 22.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U22AMD64BUILD/ErrorLog/log_pytests.txt
Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI009BUILD/frr.xref.xz/frr.xref.xz FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI009BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 11 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI009BUILD/ErrorLog/log_pytests.txt

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/FBSD12AMD64/frr.xref.xz/frr.xref.xz FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/FBSD12AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 12 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/FBSD12AMD64/ErrorLog/log_pytests.txt

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U16ARM8BUILD/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Ubuntu 16.04 arm8 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U16ARM8BUILD/ErrorLog/log_pytests.txt

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI014BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI014BUILD/ErrorLog/log_pytests.txt

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI005BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI005BUILD/ErrorLog/log_pytests.txt

Ubuntu 18.04 i386 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 18.04 i386 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18I386BUILD/ErrorLog/log_pytests.txt
Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18I386BUILD/config.log/config.log.gz
Ubuntu 18.04 i386 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM7BUILD/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Ubuntu 18.04 arm7 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM7BUILD/ErrorLog/log_pytests.txt

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz

DejaGNU Unittests (make check) failed for Ubuntu 18.04 arm8 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM8BUILD/ErrorLog/log_pytests.txt
Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U18ARM8BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1604I386/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 i386 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1604I386/ErrorLog/log_pytests.txt

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB11AMD64/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Debian 11 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB11AMD64/ErrorLog/log_pytests.txt
Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB11AMD64/config.status/config.status
Debian 11 amd64 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/REDHAT8/config.status/config.status

DejaGNU Unittests (make check) failed for Redhat 8 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/REDHAT8/ErrorLog/log_pytests.txt
Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/REDHAT8/config.log/config.log.gz
Redhat 8 amd64 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/REDHAT8/frr.xref.xz/frr.xref.xz

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/F29BUILD/frr.xref.xz/frr.xref.xz Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/F29BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Fedora 29 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/F29BUILD/ErrorLog/log_pytests.txt

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI011BUILD/frr.xref.xz/frr.xref.xz OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI011BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for OpenBSD 7 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI011BUILD/ErrorLog/log_pytests.txt

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB10BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 10 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB10BUILD/ErrorLog/log_pytests.txt
Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI021BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 9 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI021BUILD/ErrorLog/log_pytests.txt

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/RH9BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Redhat 9 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/RH9BUILD/ErrorLog/log_pytests.txt
Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/RH9BUILD/config.log/config.log.gz
Redhat 9 amd64 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/RH9BUILD/frr.xref.xz/frr.xref.xz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U2004AMD64BUILD/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Ubuntu 20.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U2004AMD64BUILD/ErrorLog/log_pytests.txt
Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz

DejaGNU Unittests (make check) failed for Ubuntu 16.04 arm7 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI101BUILD/ErrorLog/log_pytests.txt
Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804PPC64LEBUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 ppc64le build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804PPC64LEBUILD/ErrorLog/log_pytests.txt

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U1804AMD64/ErrorLog/log_pytests.txt

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U22AMD64BUILD/config.log/config.log.gz

DejaGNU Unittests (make check) failed for Ubuntu 22.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U22AMD64BUILD/ErrorLog/log_pytests.txt
Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI009BUILD/frr.xref.xz/frr.xref.xz FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI009BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 11 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8884/artifact/CI009BUILD/ErrorLog/log_pytests.txt

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #41: FILE: /tmp/f1-903821/agentx.c:41:

NetDEF-CI · 2022-12-14T20:32:39Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8882/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #41: FILE: /tmp/f1-537178/agentx.c:41:

NetDEF-CI · 2022-12-14T22:25:13Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8885/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #41: FILE: /tmp/f1-1063550/agentx.c:41:

NetDEF-CI · 2022-12-14T23:28:12Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8886/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #41: FILE: /tmp/f1-1114931/agentx.c:41:

NetDEF-CI · 2022-12-15T00:27:51Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8887/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #41: FILE: /tmp/f1-1294714/agentx.c:41:

NetDEF-CI · 2022-12-15T01:23:27Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8888/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 1
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #41: FILE: /tmp/f1-1453530/agentx.c:41:

ton31337

LGTM, just frrbot comments need to be fixed.

donaldsharp · 2022-12-15T12:27:19Z

frrbot is asking me to change lines I never touched. so nope not gonna touch them.

donaldsharp · 2022-12-15T12:28:49Z

ci:rerun ospf_asbr sometimes fails :(

The bgp_fsm_change_status function takes an int for the new bgp state, which is an `enum bgp_fsm_status status` let's convert over to being explicit.bgpd: use the enum instead of an int Signed-off-by: Donald Sharp <sharpd@nvidia.com>

FRR is using this as a bool. Let's just use a bool. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

eqvinox

One minor thing :)

eqvinox · 2022-12-15T13:01:07Z

bgpd/bgp_main.c

@@ -82,6 +82,8 @@ static const struct option longopts[] = {
 	{"socket_size", required_argument, NULL, 's'},
 	{0}};

+DEFINE_HOOK(bgp_snmp_shutdown, (), ());


Nit: hooks should be named by their position / "always" function in the containing code, rather than the one random use case they were introduced for. Nothing about this hook is SNMP specific, and some other module that needs to do things on teardown may want to use the hook as well — and then the name would get confusing.

eqvinox · 2022-12-15T13:02:10Z

bgpd/bgp_main.c

+	/*
+	 * Let's intentionally just turn snmp off.
+	 */
+	hook_call(bgp_snmp_shutdown);


And the other thing here is — frr_early_fini() is already a hook. In fact, it's nothing other than a hook :D.

The SNMP code should really be registering itself with the frr_early_fini hook.

eqvinox · 2022-12-15T13:03:05Z

bgpd/bgp_snmp.c

+
+	return 0;
+}
+
 static int bgp_snmp_module_init(void)
 {
 	hook_register(peer_status_changed, bgpTrapEstablished);
 	hook_register(peer_backward_transition, bgpTrapBackwardTransition);
 	hook_register(frr_late_init, bgp_snmp_init);


… and the reason that SNMP should use frr_early_fini instead of bgp_snmp_shutdown comes full circle here: it's a match pair with frr_late_init.

yep fixed to do it better

NetDEF-CI · 2022-12-15T14:52:23Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8900/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-8900/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8900/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 9
Addresssanitizer topotests part 8
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 4
Ubuntu 20.04 deb pkg check
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 9
Static analyzer (clang)
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 6
Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-8900/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8900/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #41: FILE: /tmp/f1-1846178/agentx.c:41:

NetDEF-CI · 2022-12-15T15:02:27Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8901/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #41: FILE: /tmp/f1-1891687/agentx.c:41:

When shutting down ensure that any daemon operating with snmp tells it to stop operating so no more data is sent. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

Address Sanitizer found this: ================================================================= ==418623==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 4 object(s) allocated from: #0 0x4bd732 in calloc (/usr/lib/frr/zebra+0x4bd732) #1 0x7feaeab8f798 in qcalloc /home/sharpd/frr8/lib/memory.c:116:27 #2 0x7feaeaba40f4 in nexthop_group_new /home/sharpd/frr8/lib/nexthop_group.c:270:9 #3 0x56859b in netlink_route_change_read_unicast /home/sharpd/frr8/zebra/rt_netlink.c:950:9 #4 0x5651c2 in netlink_route_change /home/sharpd/frr8/zebra/rt_netlink.c:1204:2 #5 0x54af15 in netlink_information_fetch /home/sharpd/frr8/zebra/kernel_netlink.c:407:10 #6 0x53e7a3 in netlink_parse_info /home/sharpd/frr8/zebra/kernel_netlink.c:1184:12 #7 0x548d46 in kernel_read /home/sharpd/frr8/zebra/kernel_netlink.c:501:2 #8 0x7feaeacc87f6 in thread_call /home/sharpd/frr8/lib/thread.c:2006:2 #9 0x7feaeab36503 in frr_run /home/sharpd/frr8/lib/libfrr.c:1198:3 #10 0x550d38 in main /home/sharpd/frr8/zebra/main.c:476:2 #11 0x7feaea492d09 in __libc_start_main csu/../csu/libc-start.c:308:16 Indirect leak of 576 byte(s) in 4 object(s) allocated from: #0 0x4bd732 in calloc (/usr/lib/frr/zebra+0x4bd732) #1 0x7feaeab8f798 in qcalloc /home/sharpd/frr8/lib/memory.c:116:27 #2 0x7feaeab9b3f8 in nexthop_new /home/sharpd/frr8/lib/nexthop.c:373:7 #3 0x56875e in netlink_route_change_read_unicast /home/sharpd/frr8/zebra/rt_netlink.c:960:15 #4 0x5651c2 in netlink_route_change /home/sharpd/frr8/zebra/rt_netlink.c:1204:2 #5 0x54af15 in netlink_information_fetch /home/sharpd/frr8/zebra/kernel_netlink.c:407:10 #6 0x53e7a3 in netlink_parse_info /home/sharpd/frr8/zebra/kernel_netlink.c:1184:12 #7 0x548d46 in kernel_read /home/sharpd/frr8/zebra/kernel_netlink.c:501:2 #8 0x7feaeacc87f6 in thread_call /home/sharpd/frr8/lib/thread.c:2006:2 #9 0x7feaeab36503 in frr_run /home/sharpd/frr8/lib/libfrr.c:1198:3 #10 0x550d38 in main /home/sharpd/frr8/zebra/main.c:476:2 #11 0x7feaea492d09 in __libc_start_main csu/../csu/libc-start.c:308:16 SUMMARY: AddressSanitizer: 704 byte(s) leaked in 8 allocation(s). Fix this! Signed-off-by: Donald Sharp <sharpd@nvidia.com>

…-sanitizer Building FRR with --enable-address-sanitizer and then running the config_timing test makes the test run for over an hour on my machine. The goal of this test is to ensure that the test runs 10000 routes in/out in a reasonable amount of time. We cannot test this with address-sanitizer enabled. So just make the test meaningless from a timing perspective but keep it `alive` from a it might catch some address sanitizer issue with 50 -vs- 10000 routes Signed-off-by: Donald Sharp <sharpd@nvidia.com>

The wq->spec.errorfunc is never used in the code. It's been in the code base since 2005 and I also do not remember ever seeing it being called. No workqueue process function ever returns error. Since it's not used let's just remove it from the code base. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

The early route queue has a series of `struct zebra_early_route *` entries. Zebra is treating this memory as just a `struct route entry`. This is wrong. Correct this to free the memory correctly. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

When using auth keys in ospfv3, there are some memory leaks when you change the key or remove the interface Signed-off-by: Donald Sharp <sharpd@nvidia.com>

The list delete function on creation was set to srv6_locator_chunk_free Which takes a double pointer and dereferences it to free the data. When list_delete is called it calls the delete function like this: if (*list->del) (*list->del)(node->data); The data is not passed in by reference and as such we do not have a double pointer. Fortunately this list_delete is only really called on shutdown when the locator was deleted and we do not have a fun situation where we were suddenly freeing 'something'. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

…ture Signed-off-by: Donald Sharp <sharpd@nvidia.com>

NetDEF-CI · 2022-12-15T18:35:40Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8909/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for agentx.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #43: FILE: /tmp/f1-3409576/agentx.c:43:

frrbot bot added bgp libfrr tests Topotests, make check, etc zebra labels Dec 14, 2022

github-actions bot added master size/M labels Dec 14, 2022

donaldsharp force-pushed the some_various_stuff branch from e8aebec to a5be4bf Compare December 14, 2022 20:09

frrbot bot added the ospfv3 label Dec 14, 2022

github-actions bot added size/L and removed size/M labels Dec 14, 2022

ton31337 approved these changes Dec 15, 2022

View reviewed changes

donaldsharp added 2 commits December 15, 2022 07:31

bgpd: use the enum instead of an int

881979e

The bgp_fsm_change_status function takes an int for the new bgp state, which is an `enum bgp_fsm_status status` let's convert over to being explicit.bgpd: use the enum instead of an int Signed-off-by: Donald Sharp <sharpd@nvidia.com>

lib: Convert agentx_enabled to a bool

2fcd46f

FRR is using this as a bool. Let's just use a bool. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

donaldsharp force-pushed the some_various_stuff branch from 077369b to 64383a8 Compare December 15, 2022 12:33

eqvinox requested changes Dec 15, 2022

View reviewed changes

donaldsharp added 5 commits December 15, 2022 11:14

lib: On shutdown, disable snmp from working

6f83bbd

When shutting down ensure that any daemon operating with snmp tells it to stop operating so no more data is sent. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

donaldsharp added 3 commits December 15, 2022 11:15

ospf6d: Fix auth_key string memory leak

6354d63

When using auth keys in ospfv3, there are some memory leaks when you change the key or remove the interface Signed-off-by: Donald Sharp <sharpd@nvidia.com>

bgpd: If we don't find what we are looking for cleanup the json struc…

5a59e9b

…ture Signed-off-by: Donald Sharp <sharpd@nvidia.com>

donaldsharp force-pushed the some_various_stuff branch from 64383a8 to 5a59e9b Compare December 15, 2022 16:17

eqvinox approved these changes Dec 16, 2022

View reviewed changes

eqvinox merged commit 7b78f6c into FRRouting:master Dec 16, 2022

Some various stuff #12522

Some various stuff #12522

Conversation

donaldsharp commented Dec 14, 2022

NetDEF-CI commented Dec 14, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Dec 14, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Dec 14, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Dec 14, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Dec 15, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Dec 15, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

ton31337 left a comment

Choose a reason for hiding this comment

donaldsharp commented Dec 15, 2022

donaldsharp commented Dec 15, 2022

eqvinox left a comment

Choose a reason for hiding this comment

eqvinox Dec 15, 2022 • edited Loading

Choose a reason for hiding this comment

eqvinox Dec 15, 2022

Choose a reason for hiding this comment

eqvinox Dec 15, 2022

Choose a reason for hiding this comment

donaldsharp Dec 15, 2022

Choose a reason for hiding this comment

NetDEF-CI commented Dec 15, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Dec 15, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Dec 15, 2022

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Dec 14, 2022 •

edited

Loading

NetDEF-CI commented Dec 14, 2022 •

edited

Loading

NetDEF-CI commented Dec 14, 2022 •

edited

Loading

NetDEF-CI commented Dec 14, 2022 •

edited

Loading

NetDEF-CI commented Dec 15, 2022 •

edited

Loading

NetDEF-CI commented Dec 15, 2022 •

edited

Loading

eqvinox Dec 15, 2022 •

edited

Loading

NetDEF-CI commented Dec 15, 2022 •

edited

Loading

NetDEF-CI commented Dec 15, 2022 •

edited

Loading