bgpd: totalPrefixCounter incorectly shows sent prefix count #12463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using: show bgp ipv4 unicast neighbors 192.168.12.2 advertised-routes json
Before:
```
"bgpOriginatingDefaultNetwork":"0.0.0.0\/0",
"advertisedRoutes":{
"192.168.12.0\/24":{
"addrPrefix":"192.168.12.0",
"prefixLen":24,
"network":"192.168.12.0\/24",
"nextHop":"0.0.0.0",
"metric":0,
"weight":32768,
"path":"",
"bgpOriginCode":"?",
"appliedStatusSymbols":{
"*":true,
">":true
}
}
},
"totalPrefixCounter":1,
"filteredPrefixCounter":0
```
After:
```
"bgpOriginatingDefaultNetwork":"0.0.0.0\/0",
"advertisedRoutes":{
"192.168.12.0\/24":{
"addrPrefix":"192.168.12.0",
"prefixLen":24,
"network":"192.168.12.0\/24",
"nextHop":"0.0.0.0",
"metric":0,
"weight":32768,
"path":"",
"bgpOriginCode":"?",
"appliedStatusSymbols":{
"*":true,
">":true
}
}
},
"totalPrefixCounter":2,
"filteredPrefixCounter":0
```
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteCentOS 7 rpm pkg check: Incomplete(check logs for details)Ubuntu 18.04 deb pkg check: Incomplete(check logs for details)Debian 9 deb pkg check: Incomplete(check logs for details)Ubuntu 16.04 deb pkg check: Incomplete(check logs for details)Debian 10 deb pkg check: Incomplete(check logs for details)Ubuntu 20.04 deb pkg check: Incomplete(check logs for details)Fedora 29 rpm pkg check: Incomplete(check logs for details)Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8744/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.