doc: introduce FRR community "accords" #12430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Dec 2, 2022
This comment was marked as outdated.
This comment was marked as outdated.
qlyoung
approved these changes
Dec 6, 2022
|
I think this is a very good idea and I also agree with the two accords here. |
The idea here is to pass "non-code agreements" through the PR review mechanism, and have them visible in the git tree. Two "example" (but real) accords are included, mostly to illustrate the idea. Both of these should be non-controversial and have had some previous discussion in random places. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Done, added blurb in |
This comment was marked as outdated.
This comment was marked as outdated.
|
CI:rerun just… no… |
Continuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 4: Incomplete(check logs for details)Successful on other platforms/tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to pass "non-code agreements" through the PR review mechanism, and have them visible in the git tree.
Two "example" (but real) accords are included, mostly to illustrate the idea. Both of these should be non-controversial and have had some previous discussion in random places.